From nobody Tue May 7 21:12:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+101044+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101044+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1678534236; cv=none; d=zohomail.com; s=zohoarc; b=ZcY/5nBSj2u6BGtQSz8drwS/b3D3pt3dSyyoAInqiNCSUxOywoV2JlGnv7BSByMLTY7a+fT+jLCOCuLjviTVxi3G44WnyMIdTiQZSe+5aNgSFYfeZ7GA+DgN5ax0+QkH/nqvV7fYuM83lUsOzNaYdE5kw9N475w00YK5WHK3reo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678534236; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject; bh=Dd+SyHC60oR/yW+llN93qgMVS9tfxjEFGFQ+Sv34Gsk=; b=kfZzuf5Wrez02M3PjtHvZMDghmucOV5xZm3rYNRRrgGDpXCM5wJYSI7m4ClhSgOXKeUO15t6MN3ggEOCKeUcapE8UvIh5/QGPqAmFkRdih4DDAQJxCtKY5xb8+ORSu3f5a8YAZtM6483dTLsaZQdJuaVDYF04Xlhkq1APvGVc24= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101044+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1678534236289867.9509500204457; Sat, 11 Mar 2023 03:30:36 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id QnQLYY1788612xEM6DcFfsZv; Sat, 11 Mar 2023 03:30:35 -0800 X-Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mx.groups.io with SMTP id smtpd.web10.42923.1678534235161977628 for ; Sat, 11 Mar 2023 03:30:35 -0800 X-Received: by mail-lf1-f53.google.com with SMTP id m6so9976497lfq.5 for ; Sat, 11 Mar 2023 03:30:34 -0800 (PST) X-Gm-Message-State: EXVNk7PD7gJr52cnV0vcHf5vx1787277AA= X-Google-Smtp-Source: AK7set9mpUkG2vXxOCYiQqVsae6I8/wVxsQRsQv6KTYTj2FhAdLf+JFfJivkV/HiuuLqmXzFM+e6tA== X-Received: by 2002:ac2:54bb:0:b0:4dc:4c53:4460 with SMTP id w27-20020ac254bb000000b004dc4c534460mr6949849lfk.16.1678534233018; Sat, 11 Mar 2023 03:30:33 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id v27-20020a056512049b00b004db44e91e34sm291883lfq.43.2023.03.11.03.30.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 03:30:32 -0800 (PST) From: "Mike Maslenkin" To: Cc: devel@edk2.groups.io, Mike Maslenkin , Arunk , Isaac Oram , Nate DeSimone , Liming Gao Subject: [edk2-devel] [PATCH edk2-platforms 1/2] IpmiFeaturePkg: add missing update of BMC status after GetSelfTest Date: Sat, 11 Mar 2023 14:30:05 +0300 Message-Id: <20230311113006.18957-2-mike.maslenkin@gmail.com> In-Reply-To: <20230311113006.18957-1-mike.maslenkin@gmail.com> References: <20230311113006.18957-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1678534235; bh=cMP4sQ7638cGi9LuHhAn8hwWVuWRaxdsHwXDaRwNXzo=; h=Cc:Date:From:Reply-To:Subject:To; b=m8InyabX/BWC69ZBY/HdyGk4LdiMfelKa18CtvWMEWl6cEuwx01rchrDKsmM6PjUGHk sWg7D3/RRz+M5EI4igNUNv3T8EtT+mn1ZzktddYou19ujRDNxflQoXANgwk6GdLFO6xEZ pwK20xereUbcNpdlGMrWKIBeGkkG8ECsA4o= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1678534236645100003 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mike Maslenkin Cc: Arunk Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao --- .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericI= pmi/Dxe/IpmiInit.c index 79eb5f2b86e9..5bdbe47b6acb 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c @@ -198,6 +198,7 @@ Returns: break; =20 default: + IpmiInstance->BmcStatus =3D BMC_HARDFAIL; // // Call routine to check device specific failures. // --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101044): https://edk2.groups.io/g/devel/message/101044 Mute This Topic: https://groups.io/mt/97538999/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 7 21:12:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+101045+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101045+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1678534237; cv=none; d=zohomail.com; s=zohoarc; b=fP7/83WEhv61HZU4pSp0Ym7aN+5Noj/zOuDMbpZJ4Lf8aPnOMP+6fViy2vM1es8krvDUb6EmrvlOOSm6IdtBP7Co3AbqXLUQcgCESo9jZSH+u66g6DiVPmRGKRsQL0oSbHyEd5L9zsJXFA8WkMBCOjPRIC9eElKVtjSJy+Za3FE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678534237; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject; bh=4q4duxHzHsFjvCDjTSiRQeLEFBwvnZeiCx/wLe/uFt8=; b=O0VUF7aG7fbftGtjjhfvY6WQyRNXPHg3cyS9Nk0atwMGo+xiFKdGo+OaTwy6kjk7NZFJ56kPXKD1umN7dT+VZCRawzM6dxf+eH2kQhmFjdNnamITzyrAA8iVcn5Biob3mP/Z7Hpd8hfkHMLxcD6soWMcOnUHjY8sG3uKX9mdtmo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101045+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 167853423739093.12065124292974; Sat, 11 Mar 2023 03:30:37 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id rXIdYY1788612xC3CdGKUqN2; Sat, 11 Mar 2023 03:30:37 -0800 X-Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by mx.groups.io with SMTP id smtpd.web10.42924.1678534236311880563 for ; Sat, 11 Mar 2023 03:30:36 -0800 X-Received: by mail-lj1-f171.google.com with SMTP id b10so8040314ljr.0 for ; Sat, 11 Mar 2023 03:30:36 -0800 (PST) X-Gm-Message-State: C27oXvwqY2yQSdJdGgDdQw8Ox1787277AA= X-Google-Smtp-Source: AK7set+YMSr3J1/dG9IPArYD0ec6BVE9waRgvku9Em1ZoYrm4eYk4QWImQWWgwQ/XTIT4imMxpI+BQ== X-Received: by 2002:a2e:86d6:0:b0:290:6e31:dbfb with SMTP id n22-20020a2e86d6000000b002906e31dbfbmr8194377ljj.28.1678534234344; Sat, 11 Mar 2023 03:30:34 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id v27-20020a056512049b00b004db44e91e34sm291883lfq.43.2023.03.11.03.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 03:30:33 -0800 (PST) From: "Mike Maslenkin" To: Cc: devel@edk2.groups.io, Mike Maslenkin , Isaac Oram , Nate DeSimone , Liming Gao Subject: [edk2-devel] [PATCH edk2-platforms 2/2] IpmiFeaturePkg: fix IpmiSendCommand response size in GetDeviceId function Date: Sat, 11 Mar 2023 14:30:06 +0300 Message-Id: <20230311113006.18957-3-mike.maslenkin@gmail.com> In-Reply-To: <20230311113006.18957-1-mike.maslenkin@gmail.com> References: <20230311113006.18957-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1678534237; bh=cQnA4nqsvujVFusR9mN4lOeqi7jNisl+ZykEGTuTbJk=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=jYc6WWaw0P4kGzThejVIjvMuUxbB/JFlSjgx/F6USTduaXbIm5RWR5f+NCrA/1q1gwF x25jnGBC6bmkPAdRVZKf1fATiZppJtSI1BJELWeQ405EOnrGbU4nTpMMeY8I2RIRyAfaN c/ba7wWBM03RtiIQza6PzVObOsKxxk2DBTo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1678534238662100010 Content-Type: text/plain; charset="utf-8" It is required to reinitialize DataSize variable before subsequent IpmiSendCommand calls. It is especially required after processing IpmiSendCommand with IPMI_GET_BMC_EXECUTION_CONTEXT because it returns only 2 bytes as a response. So to the next call of IpmiSendCommand with IPMI_APP_GET_DEVICE_ID DataSize=3D2 will be passed. Probably this call will fail because the expected size of returned data either 12 or 16 bytes depending on IPMI version supported. Signed-off-by: Mike Maslenkin Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao --- .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericI= pmi/Dxe/IpmiInit.c index 5bdbe47b6acb..c333ca2e067a 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c @@ -305,6 +305,7 @@ Returns: mIpmiInstance->BmcStatus =3D BMC_OK; return EFI_SUCCESS; } else { + DataSize =3D sizeof (TempData); Status =3D IpmiSendCommand ( &IpmiInstance->IpmiTransport, IPMI_NETFN_FIRMWARE, 0, @@ -326,6 +327,7 @@ Returns: while (Retries-- !=3D 0) { MicroSecondDelay(1*1000*1000); //delay 1 seconds DEBUG ((EFI_D_ERROR, "[IPMI] UpdateMode Retries: %d \n",Retries)); + DataSize =3D sizeof (TempData); Status =3D IpmiSendCommand ( &IpmiInstance->IpmiTransport, IPMI_NETFN_APP, 0, --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101045): https://edk2.groups.io/g/devel/message/101045 Mute This Topic: https://groups.io/mt/97539000/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-