From nobody Mon Sep 16 19:44:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+101022+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101022+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1678473910; cv=none; d=zohomail.com; s=zohoarc; b=fVHGt9eJwr/pxbSy4JFqzaWkw8Yn5FWWooWO0FFb61pCpcAdxOiDdw+DeUx75ezo4FHIu24+SukVLnymVXbPLuO3/1OUhpDtAVN056LZsJscTaYkWNFjsHKw0VFB8J5j+lp6ukuB3IGDJrN7OdLF6RsnXO9GEZkRktloPd1AGvA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678473910; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=0prsyXNXFMizR08eNqmU6fG9pHHujXXPgboaEsF14Sk=; b=UMFbWSIwqoBLzkYn19EuCINY0eLwJ1GXbBysskPYLPurTux+KGDo1BOGM/FArBD6B4NR0UCc+Bq0socT8Jj+kSciWdNnJtsfc+OWFrxd0DYfPEssd4LUJxIdLxR2ne+2fZfI2HEbA+Z0zPij934N9N9OI51hnUzjNd5Kt0YRkLk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101022+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 167847391048014.906285515862123; Fri, 10 Mar 2023 10:45:10 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id CnfFYY1788612xZt4H7cj9YG; Fri, 10 Mar 2023 10:45:10 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.27846.1678473909650474653 for ; Fri, 10 Mar 2023 10:45:09 -0800 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 92A8C205765A; Fri, 10 Mar 2023 10:45:08 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 92A8C205765A From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Michael D Kinney , Sean Brogan , Yuwei Chen Subject: [edk2-devel] [PATCH v4 02/12] BaseTools/PatchCheck.py: Add PCCTS to tab exemption list Date: Fri, 10 Mar 2023 13:42:28 -0500 Message-Id: <20230310184238.2999-3-mikuback@linux.microsoft.com> In-Reply-To: <20230310184238.2999-1-mikuback@linux.microsoft.com> References: <20230310184238.2999-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: 4iASdblBqQuelcD39rua1TODx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1678473910; bh=UAOl5B0naa4OrNih5LOiibqenrEvN+Ll1guOpf5qSW8=; h=Cc:Date:From:Reply-To:Subject:To; b=CD52b+2EvecIe9q4RWjwOTz3R9Z3QlGpNuA46nepf5snPRx7Rx7L3DqkWew6E1ESk0q Kx7XGj6sDLepWma2sfT6pypoROyKTxyh+AynbPBeOzN8vtQwtsmyPvsAgQysb7QC1ITZG ev3j5JLU2hfhtbcmuynj9K0ApYYmecTyKRA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1678473911865100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki Purdue Compiler Construction Tool Set (PCCTS) source code was copied/ pasted into BaseTools/Source/C/VfrCompile/Pccts/. The code contains tab characters instead of spaces. PatchCheck.py gives an error on modifications to files that contain tabs. This change adds that directory to the pre-existing list of directories in which tab checks are ignored in PatchCheck.py. The goal of my upcoming change there is not to mix tabs and spaces but to fix a bug while preserving its current formatting characters. Cc: Bob Feng Cc: Liming Gao Cc: Michael D Kinney Cc: Sean Brogan Cc: Yuwei Chen Signed-off-by: Michael Kubacki Reviewed-by: Liming Gao Reviewed-by: Michael D Kinney --- BaseTools/Scripts/PatchCheck.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index fcdabfc8acea..84d56b8c8b70 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -383,7 +383,9 @@ class GitDiffCheck: self.force_crlf =3D False self.force_notabs =3D False if os.path.basename(self.filename) =3D=3D 'GNUmakefile' or= \ - os.path.basename(self.filename) =3D=3D 'Makefile': + os.path.basename(self.filename) =3D=3D 'Makefile' or \ + self.filename.startswith( + 'BaseTools/Source/C/VfrCompile/Pccts/'): self.force_notabs =3D False elif len(line.rstrip()) !=3D 0: self.format_error("didn't find diff command") --=20 2.39.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101022): https://edk2.groups.io/g/devel/message/101022 Mute This Topic: https://groups.io/mt/97526779/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-