From nobody Mon Sep 16 19:19:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+100884+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100884+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1678317538; cv=none; d=zohomail.com; s=zohoarc; b=M24dg5v7DUIeMDuaSu0Oavtgxr++QX9KiBGw7zzsjnG72lznWIXKbkex1tGSo7hxaZgGvvqI3VmWgzDnPpBTX4TdOzS7nPks5SfetWMjg67AebUXwctDXC7vrGGXdDwLAIoL/D+zF0ly14R12ZBxPmDBspvVwnlR+GXWp325V/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678317538; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject; bh=KWhrwj9Oq5MrBKneMF6aBc6M5wTruIaHKsAJKRg7Z9I=; b=dmSGfXckAaGurJ/ct3NRD4si1Z8LrLwR+Aqi/VGWvq24Q8u++j+IIXXZew6rnQwc7rQZ926rT11RymAf45Ga/EYG9gxUtt1AIBUa+GtDtJRnKQVgg2hq6UG8kys1uPKc9HkI/T9Z5XF929VZB44+7Vo94Ep3RcgLWyv9XE8xqew= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100884+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1678317538966131.16432760951966; Wed, 8 Mar 2023 15:18:58 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id EA3eYY1788612xNrpSRzjGdT; Wed, 08 Mar 2023 15:18:58 -0800 X-Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by mx.groups.io with SMTP id smtpd.web10.223.1678317537909317430 for ; Wed, 08 Mar 2023 15:18:58 -0800 X-Received: by mail-lj1-f170.google.com with SMTP id a32so60301ljq.1 for ; Wed, 08 Mar 2023 15:18:57 -0800 (PST) X-Gm-Message-State: GlcciZd9KLi7Gybx7tsoVmo6x1787277AA= X-Google-Smtp-Source: AK7set/zgKz2DTtpKEr7nqraDy7PH2OEpw5m/uVgOeqa+lY+hpeNZxc7O8qyyb8VnRElY/gE/v1XYA== X-Received: by 2002:a2e:a549:0:b0:298:6a87:7611 with SMTP id e9-20020a2ea549000000b002986a877611mr1540581ljn.50.1678317536120; Wed, 08 Mar 2023 15:18:56 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id w11-20020a05651c102b00b00293526a0c87sm2726630ljm.41.2023.03.08.15.18.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 15:18:55 -0800 (PST) From: "Mike Maslenkin" To: Cc: devel@edk2.groups.io, Mike Maslenkin , Isaac Oram , Nate DeSimone , Liming Gao Subject: [edk2-devel] [PATCH edk2-platforms v2 3/3] IpmiFeaturePkg: refine GetSelfTest function Date: Thu, 9 Mar 2023 02:18:45 +0300 Message-Id: <20230308231845.10895-4-mike.maslenkin@gmail.com> In-Reply-To: <20230308231845.10895-1-mike.maslenkin@gmail.com> References: <20230308231845.10895-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1678317538; bh=FM/JSJpU7cq1fWORrgJg8kJpIhCmolHRNdQTsPvtaiU=; h=Cc:Date:From:Reply-To:Subject:To; b=bDwEzagQ4Ecj8667S6N0fwWj4ZVN591PXEq8zYODJJuGZtZlnGxf3VpX/uoy4fq8w9K GMvcrLn2ub9osiK7fPH7GpfTC8uEeERvT8F9nplemv+ztwgl5Z2tP/m3oV0lAHpNpA147 MJur79PS7e+hMRo8pp02l3e0Q+WEH2im01A= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1678317540483100009 Content-Type: text/plain; charset="utf-8" Use predefined type while accessing IPMI command returned data instead of raw byte array. Signed-off-by: Mike Maslenkin Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao --- .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericI= pmi/Dxe/IpmiInit.c index 8a0c596a6434..79eb5f2b86e9 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c @@ -86,6 +86,8 @@ Returns: BOOLEAN bResultFlag =3D FALSE; UINT8 TempData[MAX_TEMP_DATA]; =20 + IPMI_SELF_TEST_RESULT_RESPONSE *SelfTestResult; + // // Get the SELF TEST Results. // @@ -100,7 +102,8 @@ Returns: =20 DataSize =3D sizeof (TempData); =20 - TempData[1] =3D 0; + SelfTestResult =3D (IPMI_SELF_TEST_RESULT_RESPONSE *) &TempData[0]; + SelfTestResult->Result =3D 0; =20 do { Status =3D IpmiSendCommand ( @@ -114,7 +117,7 @@ Returns: &DataSize ); if (Status =3D=3D EFI_SUCCESS) { - switch (TempData[1]) { + switch (SelfTestResult->Result) { case IPMI_APP_SELFTEST_NO_ERROR: case IPMI_APP_SELFTEST_NOT_IMPLEMENTED: case IPMI_APP_SELFTEST_ERROR: @@ -147,7 +150,7 @@ Returns: IpmiInstance->BmcStatus =3D BMC_HARDFAIL; return Status; } else { - DEBUG ((DEBUG_INFO, "[IPMI] BMC self-test result: %02X-%02X\n", TempDa= ta[1], TempData[2])); + DEBUG ((DEBUG_INFO, "[IPMI] BMC self-test result: %02X-%02X\n", SelfTe= stResult->Result, SelfTestResult->Param)); // // Copy the Self test results to Error Status. Data will be copied as= long as it // does not exceed the size of the ErrorStatus variable. @@ -162,7 +165,7 @@ Returns: // Check the IPMI defined self test results. // Additional Cases are device specific test results. // - switch (TempData[1]) { + switch (SelfTestResult->Result) { case IPMI_APP_SELFTEST_NO_ERROR: case IPMI_APP_SELFTEST_NOT_IMPLEMENTED: IpmiInstance->BmcStatus =3D BMC_OK; @@ -174,7 +177,7 @@ Returns: // BootBlock Firmware corruption, and Operational Firmware Corrupt= ion. All // other errors are BMC soft failures. // - if ((TempData[2] & (IPMI_APP_SELFTEST_FRU_CORRUPT | IPMI_APP_SELFT= EST_FW_BOOTBLOCK_CORRUPT | IPMI_APP_SELFTEST_FW_CORRUPT)) !=3D 0) { + if ((SelfTestResult->Param & (IPMI_APP_SELFTEST_FRU_CORRUPT | IPMI= _APP_SELFTEST_FW_BOOTBLOCK_CORRUPT | IPMI_APP_SELFTEST_FW_CORRUPT)) !=3D 0)= { IpmiInstance->BmcStatus =3D BMC_HARDFAIL; } else { IpmiInstance->BmcStatus =3D BMC_SOFTFAIL; @@ -182,7 +185,7 @@ Returns: // // Check if SDR repository is empty and report it if it is. // - if ((TempData[2] & IPMI_APP_SELFTEST_SDR_REPOSITORY_EMPTY) !=3D 0)= { + if ((SelfTestResult->Param & IPMI_APP_SELFTEST_SDR_REPOSITORY_EMPT= Y) !=3D 0) { if (*ErrorCount < MAX_SOFT_COUNT) { StatusCodeValue[*ErrorCount] =3D EFI_COMPUTING_UNIT_FIRMWARE_P= ROCESSOR | CU_FP_EC_SDR_EMPTY; (*ErrorCount)++; --=20 2.35.3 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100884): https://edk2.groups.io/g/devel/message/100884 Mute This Topic: https://groups.io/mt/97485243/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-