From nobody Mon Feb 9 23:44:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+100754+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100754+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1678124013; cv=none; d=zohomail.com; s=zohoarc; b=Goh0JIuBkjDHubnp7vzc9GWn8VgWKkxmJ3FyhRjKaPfKapbUOh9Vbsb0FQcyGDFZWkNFMnu7XADK/j9ICXNc+APURt3sanx9fNl5ecq25soXp2OnrzUXWX4xFLdu5TyVUMmwYhzJW8GDC0+6mLUKthL2fs47ZqwF+FkjVMEvjn4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678124013; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=LrtzdeEvbAuDkAAKLluVftjzwItFwjDpB3h9XvxkI/I=; b=CPsf1gWIsZ+QZVxUHet1nUkvcd0wXzFc/R9eezvREvIZsc50wk8v5SX0ywGjDgS7tJGNTLkfErCaUMLL6ztCq4CeE5+9U5iZPwhWdnUo1orXxsUqOeApziGufh3SV2e4bzrt4wjHeM8YlPnpyMNIJ2bJQgF/l6GdEGfzTOrbFiA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100754+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1678124013753135.39694406971773; Mon, 6 Mar 2023 09:33:33 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id h4OtYY1788612x9OqqtJNZEW; Mon, 06 Mar 2023 09:33:33 -0800 X-Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mx.groups.io with SMTP id smtpd.web11.1139.1678124006645284517 for ; Mon, 06 Mar 2023 09:33:32 -0800 X-Received: by mail-pf1-f179.google.com with SMTP id a7so6310770pfx.10 for ; Mon, 06 Mar 2023 09:33:32 -0800 (PST) X-Gm-Message-State: 90zd1p2LsfUgwQo1nprpFETQx1787277AA= X-Google-Smtp-Source: AK7set9XRlKLaqjhH00vtT+2mRJDMtCaTpaG/f28sx9r+0JpTTX1tXnMseyBxHBygoQ2pkjr4YYomQ== X-Received: by 2002:a62:4e83:0:b0:5cd:81a7:41cc with SMTP id c125-20020a624e83000000b005cd81a741ccmr9164024pfb.13.1678124012047; Mon, 06 Mar 2023 09:33:32 -0800 (PST) X-Received: from localhost.localdomain (c-174-50-177-95.hsd1.ca.comcast.net. [174.50.177.95]) by smtp.gmail.com with ESMTPSA id v6-20020aa78506000000b005dd975176c3sm6579722pfn.53.2023.03.06.09.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 09:33:31 -0800 (PST) From: "Tuan Phan" To: devel@edk2.groups.io Cc: michael.d.kinney@intel.com, gaoliming@byosoft.com.cn, zhiguang.liu@intel.com, sunilvl@ventanamicro.com, git@danielschaefer.me, andrei.warkentin@intel.com, Tuan Phan Subject: [edk2-devel] [PATCH 5/7] OvmfPkg/VirtNorFlashDxe: Not add memory space if it exists Date: Mon, 6 Mar 2023 09:33:14 -0800 Message-Id: <20230306173316.10319-6-tphan@ventanamicro.com> In-Reply-To: <20230306173316.10319-1-tphan@ventanamicro.com> References: <20230306173316.10319-1-tphan@ventanamicro.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tphan@ventanamicro.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1678124013; bh=slorckFueS/jsto5jkYUANrTerRkqNV54iuMmRMn6/s=; h=Cc:Date:From:Reply-To:Subject:To; b=bDzRSIfOBCl6GplnVosj9nBQnbQFQiKPsTEbBVSgzfWLTY38OJx5UOjgOTGeU81hgzr Geh1Ll/CaTz+GSVU0BQcDUSKj+/cpTEucmmQN3KKtRULTOyvGall8WyaE3lhUFx5k0sG3 6MDnuLRmUf95AcqjUj+n+Ci4eifA2bnj3go= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1678124015688100019 Content-Type: text/plain; charset="utf-8" The flash base address can be added to GCD before this driver run. So only add it if it has not been done. Signed-off-by: Tuan Phan --- OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.c | 25 +++++++++++++++-------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.c b/OvmfPkg/VirtNorFla= shDxe/VirtNorFlashDxe.c index f9a41f6aab0f..8875824f3333 100644 --- a/OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.c +++ b/OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.c @@ -372,10 +372,11 @@ NorFlashFvbInitialize ( IN NOR_FLASH_INSTANCE *Instance ) { - EFI_STATUS Status; - UINT32 FvbNumLba; - EFI_BOOT_MODE BootMode; - UINTN RuntimeMmioRegionSize; + EFI_STATUS Status; + UINT32 FvbNumLba; + EFI_BOOT_MODE BootMode; + UINTN RuntimeMmioRegionSize; + EFI_GCD_MEMORY_SPACE_DESCRIPTOR Desc; =20 DEBUG ((DEBUG_BLKIO, "NorFlashFvbInitialize\n")); ASSERT ((Instance !=3D NULL)); @@ -390,13 +391,19 @@ NorFlashFvbInitialize ( // is written as the base of the flash region (ie: Instance->Devic= eBaseAddress) RuntimeMmioRegionSize =3D (Instance->RegionBaseAddress - Instance->Devic= eBaseAddress) + Instance->Size; =20 - Status =3D gDS->AddMemorySpace ( - EfiGcdMemoryTypeMemoryMappedIo, + Status =3D gDS->GetMemorySpaceDescriptor ( Instance->DeviceBaseAddress, - RuntimeMmioRegionSize, - EFI_MEMORY_UC | EFI_MEMORY_RUNTIME + &Desc ); - ASSERT_EFI_ERROR (Status); + if (Status =3D=3D EFI_NOT_FOUND) { + Status =3D gDS->AddMemorySpace ( + EfiGcdMemoryTypeMemoryMappedIo, + Instance->DeviceBaseAddress, + RuntimeMmioRegionSize, + EFI_MEMORY_UC | EFI_MEMORY_RUNTIME + ); + ASSERT_EFI_ERROR (Status); + } =20 Status =3D gDS->SetMemorySpaceAttributes ( Instance->DeviceBaseAddress, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100754): https://edk2.groups.io/g/devel/message/100754 Mute This Topic: https://groups.io/mt/97430554/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-