From nobody Mon Feb 9 16:01:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+100707+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100707+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1678062135; cv=none; d=zohomail.com; s=zohoarc; b=QZfLDszcDEyWjeqssv32l2JUZP3Ff2JwGyvSx5U5HF4HZtgZ8WgbHkd1V+eVKRSbAFYo6XmdbxSDbuhwagt9V4TeFDEmQgKgG1br41cjIpLaZQpztfW2C2QSt7Nw4SItYr8dOz1SAJhZbtHjLulL/yxN/POYgyspNDAAgBublKI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678062135; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=W3c7PmIMxT9o+abVmDUbPOgEUPRB4CZNZk+753RT2OQ=; b=E9Vg5sRwX8lMsqgnVt0Qh4LoQfbzmW2nmQY1Ae1IcCUcIIWDfqSyOp+UQGNgwJr/MZWJNvrfzuqyPy6RirlDtrjO1eKKsj7kyE5FDby/r7iR0JccuZKTC0kZRvvnM6WksKMZfDzB2WdXQ/NqsKQDVAEBJMeqCCnJ0l+N/u48bmo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100707+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1678062135395227.63427975470165; Sun, 5 Mar 2023 16:22:15 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id N7Z1YY1788612xZr2TymE2Gi; Sun, 05 Mar 2023 16:22:15 -0800 X-Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.22191.1678062132259075315 for ; Sun, 05 Mar 2023 16:22:13 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10640"; a="337758115" X-IronPort-AV: E=Sophos;i="5.98,236,1673942400"; d="scan'208";a="337758115" X-Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2023 16:22:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10640"; a="669263316" X-IronPort-AV: E=Sophos;i="5.98,236,1673942400"; d="scan'208";a="669263316" X-Received: from nldesimo-desk.amr.corp.intel.com ([10.24.12.177]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2023 16:22:11 -0800 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Andrew Fish , Ray Ni , Michael D Kinney , Chasel Chiu Subject: [edk2-devel] [PATCH v1 3/6] EmulatorPkg: Fix PosixFileSystem function misspellings Date: Sun, 5 Mar 2023 16:22:02 -0800 Message-Id: <20230306002205.1640-4-nathaniel.l.desimone@intel.com> In-Reply-To: <20230306002205.1640-1-nathaniel.l.desimone@intel.com> References: <20230306002205.1640-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com X-Gm-Message-State: ahskbvYk1jM3OtRZjpv4Nqfrx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1678062135; bh=cYQ+lhTrbjSNpRk1vwYHKnwnjN0exZkbEBsFVsqNy28=; h=Cc:Date:From:Reply-To:Subject:To; b=tQCZDeLsRoELJ3+xHWX6pfFU28nQqq34n1e4cAoLljRDVPu5qHIB++BmZk4pjyjLoWt 4YoR0LF41juuL+g4xPG8oBmYUY56ABzTVpsnhixTKJFTagqwEi/TSfaU16UDuAt5yI/2q wWuH6FC8U2XxAFN6kLeHeM4e3Zw5BV3Brm8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1678062136121100011 Content-Type: text/plain; charset="utf-8" Fixes spelling errors in the following function names: GasketPosixFileCLose --> GasketPosixFileClose PosixFileCLose --> PosixFileClose GasketPosixFileSetPossition --> GasketPosixFileSetPosition PosixFileSetPossition --> PosixFileSetPosition GasketPosixFileGetPossition --> GasketPosixFileGetPosition PosixFileGetPossition --> PosixFileGetPosition GasketPosixFileSystmeThunkOpen --> GasketPosixFileSystemThunkOpen PosixFileSystmeThunkOpen --> PosixFileSystemThunkOpen GasketPosixFileSystmeThunkClose --> GasketPosixFileSystemThunkClose PosixFileSystmeThunkClose --> PosixFileSystemThunkClose Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/Unix/Host/Gasket.h | 12 +++++----- EmulatorPkg/Unix/Host/Ia32/Gasket.S | 31 +++++++++++++------------ EmulatorPkg/Unix/Host/PosixFileSystem.c | 22 +++++++++--------- EmulatorPkg/Unix/Host/X64/Gasket.S | 31 +++++++++++++------------ 4 files changed, 49 insertions(+), 47 deletions(-) diff --git a/EmulatorPkg/Unix/Host/Gasket.h b/EmulatorPkg/Unix/Host/Gasket.h index 6dafc903cf..90c591e024 100644 --- a/EmulatorPkg/Unix/Host/Gasket.h +++ b/EmulatorPkg/Unix/Host/Gasket.h @@ -1,7 +1,7 @@ /** @file =20 Copyright (c) 2008 - 2011, Apple Inc. All rights reserved.
- Copyright (c) 2011 - 2019, Intel Corporation. All rights reserved.
+ Copyright (c) 2011 - 2023, Intel Corporation. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -360,7 +360,7 @@ GasketPosixFileOpen ( =20 EFI_STATUS EFIAPI -GasketPosixFileCLose ( +GasketPosixFileClose ( IN EFI_FILE_PROTOCOL *This ); =20 @@ -388,14 +388,14 @@ GasketPosixFileWrite ( =20 EFI_STATUS EFIAPI -GasketPosixFileSetPossition ( +GasketPosixFileSetPosition ( IN EFI_FILE_PROTOCOL *This, IN UINT64 Position ); =20 EFI_STATUS EFIAPI -GasketPosixFileGetPossition ( +GasketPosixFileGetPosition ( IN EFI_FILE_PROTOCOL *This, OUT UINT64 *Position ); @@ -426,13 +426,13 @@ GasketPosixFileFlush ( =20 EFI_STATUS EFIAPI -GasketPosixFileSystmeThunkOpen ( +GasketPosixFileSystemThunkOpen ( IN EMU_IO_THUNK_PROTOCOL *This ); =20 EFI_STATUS EFIAPI -GasketPosixFileSystmeThunkClose ( +GasketPosixFileSystemThunkClose ( IN EMU_IO_THUNK_PROTOCOL *This ); =20 diff --git a/EmulatorPkg/Unix/Host/Ia32/Gasket.S b/EmulatorPkg/Unix/Host/Ia= 32/Gasket.S index 36197ff260..f4c2b456d8 100644 --- a/EmulatorPkg/Unix/Host/Ia32/Gasket.S +++ b/EmulatorPkg/Unix/Host/Ia32/Gasket.S @@ -7,6 +7,7 @@ # the code common. # # Copyright (c) 2008 - 2011, Apple Inc. All rights reserved.
+# Copyright (c) 2023, Intel Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # #-------------------------------------------------------------------------= ----- @@ -847,8 +848,8 @@ ASM_PFX(GasketPosixFileOpen): ret =20 =20 -ASM_GLOBAL ASM_PFX(GasketPosixFileCLose) -ASM_PFX(GasketPosixFileCLose): +ASM_GLOBAL ASM_PFX(GasketPosixFileClose) +ASM_PFX(GasketPosixFileClose): pushl %ebp movl %esp, %ebp subl $24, %esp // sub extra 16 from the stack for alignment @@ -856,7 +857,7 @@ ASM_PFX(GasketPosixFileCLose): movl 8(%ebp), %eax movl %eax, (%esp) =20 - call ASM_PFX(PosixFileCLose) + call ASM_PFX(PosixFileClose) =20 leave ret @@ -915,8 +916,8 @@ ASM_PFX(GasketPosixFileWrite): ret =20 =20 -ASM_GLOBAL ASM_PFX(GasketPosixFileSetPossition) -ASM_PFX(GasketPosixFileSetPossition): +ASM_GLOBAL ASM_PFX(GasketPosixFileSetPosition) +ASM_PFX(GasketPosixFileSetPosition): pushl %ebp movl %esp, %ebp subl $40, %esp // sub extra 16 from the stack for alignment @@ -928,14 +929,14 @@ ASM_PFX(GasketPosixFileSetPossition): movl 8(%ebp), %eax movl %eax, (%esp) =20 - call ASM_PFX(PosixFileSetPossition) + call ASM_PFX(PosixFileSetPosition) =20 leave ret =20 =20 -ASM_GLOBAL ASM_PFX(GasketPosixFileGetPossition) -ASM_PFX(GasketPosixFileGetPossition): +ASM_GLOBAL ASM_PFX(GasketPosixFileGetPosition) +ASM_PFX(GasketPosixFileGetPosition): pushl %ebp movl %esp, %ebp subl $24, %esp // sub extra 16 from the stack for alignment @@ -945,7 +946,7 @@ ASM_PFX(GasketPosixFileGetPossition): movl 8(%ebp), %eax movl %eax, (%esp) =20 - call ASM_PFX(PosixFileGetPossition) + call ASM_PFX(PosixFileGetPosition) =20 leave ret @@ -1008,8 +1009,8 @@ ASM_PFX(GasketPosixFileFlush): ret =20 =20 -ASM_GLOBAL ASM_PFX(GasketPosixFileSystmeThunkOpen) -ASM_PFX(GasketPosixFileSystmeThunkOpen): +ASM_GLOBAL ASM_PFX(GasketPosixFileSystemThunkOpen) +ASM_PFX(GasketPosixFileSystemThunkOpen): pushl %ebp movl %esp, %ebp subl $24, %esp // sub extra 16 from the stack for alignment @@ -1017,14 +1018,14 @@ ASM_PFX(GasketPosixFileSystmeThunkOpen): movl 8(%ebp), %eax movl %eax, (%esp) =20 - call ASM_PFX(PosixFileSystmeThunkOpen) + call ASM_PFX(PosixFileSystemThunkOpen) =20 leave ret =20 =20 -ASM_GLOBAL ASM_PFX(GasketPosixFileSystmeThunkClose) -ASM_PFX(GasketPosixFileSystmeThunkClose): +ASM_GLOBAL ASM_PFX(GasketPosixFileSystemThunkClose) +ASM_PFX(GasketPosixFileSystemThunkClose): pushl %ebp movl %esp, %ebp subl $24, %esp // sub extra 16 from the stack for alignment @@ -1032,7 +1033,7 @@ ASM_PFX(GasketPosixFileSystmeThunkClose): movl 8(%ebp), %eax movl %eax, (%esp) =20 - call ASM_PFX(PosixFileSystmeThunkClose) + call ASM_PFX(PosixFileSystemThunkClose) =20 leave ret diff --git a/EmulatorPkg/Unix/Host/PosixFileSystem.c b/EmulatorPkg/Unix/Hos= t/PosixFileSystem.c index b69d3d5520..3a86d6675c 100644 --- a/EmulatorPkg/Unix/Host/PosixFileSystem.c +++ b/EmulatorPkg/Unix/Host/PosixFileSystem.c @@ -2,7 +2,7 @@ POSIX Pthreads to emulate APs and implement threads =20 Copyright (c) 2011, Apple Inc. All rights reserved. -Copyright (c) 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2019 - 2023, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 =20 @@ -70,12 +70,12 @@ PosixFileSetInfo ( EFI_FILE_PROTOCOL gPosixFileProtocol =3D { EFI_FILE_REVISION, GasketPosixFileOpen, - GasketPosixFileCLose, + GasketPosixFileClose, GasketPosixFileDelete, GasketPosixFileRead, GasketPosixFileWrite, - GasketPosixFileGetPossition, - GasketPosixFileSetPossition, + GasketPosixFileGetPosition, + GasketPosixFileSetPosition, GasketPosixFileGetInfo, GasketPosixFileSetInfo, GasketPosixFileFlush @@ -643,7 +643,7 @@ Done:; =20 **/ EFI_STATUS -PosixFileCLose ( +PosixFileClose ( IN EFI_FILE_PROTOCOL *This ) { @@ -883,7 +883,7 @@ PosixFileWrite ( =20 **/ EFI_STATUS -PosixFileSetPossition ( +PosixFileSetPosition ( IN EFI_FILE_PROTOCOL *This, IN UINT64 Position ) @@ -930,7 +930,7 @@ PosixFileSetPossition ( =20 **/ EFI_STATUS -PosixFileGetPossition ( +PosixFileGetPosition ( IN EFI_FILE_PROTOCOL *This, OUT UINT64 *Position ) @@ -1473,7 +1473,7 @@ PosixFileFlush ( } =20 EFI_STATUS -PosixFileSystmeThunkOpen ( +PosixFileSystemThunkOpen ( IN EMU_IO_THUNK_PROTOCOL *This ) { @@ -1530,7 +1530,7 @@ PosixFileSystmeThunkOpen ( } =20 EFI_STATUS -PosixFileSystmeThunkClose ( +PosixFileSystemThunkClose ( IN EMU_IO_THUNK_PROTOCOL *This ) { @@ -1566,7 +1566,7 @@ EMU_IO_THUNK_PROTOCOL gPosixFileSystemThunkIo =3D { NULL, NULL, 0, - GasketPosixFileSystmeThunkOpen, - GasketPosixFileSystmeThunkClose, + GasketPosixFileSystemThunkOpen, + GasketPosixFileSystemThunkClose, NULL }; diff --git a/EmulatorPkg/Unix/Host/X64/Gasket.S b/EmulatorPkg/Unix/Host/X64= /Gasket.S index 030faa8e4c..e82c9d4ad6 100644 --- a/EmulatorPkg/Unix/Host/X64/Gasket.S +++ b/EmulatorPkg/Unix/Host/X64/Gasket.S @@ -8,6 +8,7 @@ # RSI, RDI calle-save on EFI, scatch on UNIX callign # # Copyright (c) 2008 - 2011, Apple Inc. All rights reserved.
+# Copyright (c) 2023, Intel Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # #-------------------------------------------------------------------------= ----- @@ -941,8 +942,8 @@ ASM_PFX(GasketPosixFileOpen): ret =20 =20 -ASM_GLOBAL ASM_PFX(GasketPosixFileCLose) -ASM_PFX(GasketPosixFileCLose): +ASM_GLOBAL ASM_PFX(GasketPosixFileClose) +ASM_PFX(GasketPosixFileClose): pushq %rbp // stack frame is for the debugger movq %rsp, %rbp =20 @@ -951,7 +952,7 @@ ASM_PFX(GasketPosixFileCLose): =20 movq %rcx, %rdi // Swizzle args =20 - call ASM_PFX(PosixFileCLose) + call ASM_PFX(PosixFileClose) =20 popq %rdi // restore state popq %rsi @@ -1017,8 +1018,8 @@ ASM_PFX(GasketPosixFileWrite): ret =20 =20 -ASM_GLOBAL ASM_PFX(GasketPosixFileSetPossition) -ASM_PFX(GasketPosixFileSetPossition): +ASM_GLOBAL ASM_PFX(GasketPosixFileSetPosition) +ASM_PFX(GasketPosixFileSetPosition): pushq %rbp // stack frame is for the debugger movq %rsp, %rbp =20 @@ -1028,7 +1029,7 @@ ASM_PFX(GasketPosixFileSetPossition): movq %rcx, %rdi // Swizzle args movq %rdx, %rsi =20 - call ASM_PFX(PosixFileSetPossition) + call ASM_PFX(PosixFileSetPosition) =20 popq %rdi // restore state popq %rsi @@ -1036,8 +1037,8 @@ ASM_PFX(GasketPosixFileSetPossition): ret =20 =20 -ASM_GLOBAL ASM_PFX(GasketPosixFileGetPossition) -ASM_PFX(GasketPosixFileGetPossition): +ASM_GLOBAL ASM_PFX(GasketPosixFileGetPosition) +ASM_PFX(GasketPosixFileGetPosition): pushq %rbp // stack frame is for the debugger movq %rsp, %rbp =20 @@ -1047,7 +1048,7 @@ ASM_PFX(GasketPosixFileGetPossition): movq %rcx, %rdi // Swizzle args movq %rdx, %rsi =20 - call ASM_PFX(PosixFileGetPossition) + call ASM_PFX(PosixFileGetPosition) =20 popq %rdi // restore state popq %rsi @@ -1115,8 +1116,8 @@ ASM_PFX(GasketPosixFileFlush): ret =20 =20 -ASM_GLOBAL ASM_PFX(GasketPosixFileSystmeThunkOpen) -ASM_PFX(GasketPosixFileSystmeThunkOpen): +ASM_GLOBAL ASM_PFX(GasketPosixFileSystemThunkOpen) +ASM_PFX(GasketPosixFileSystemThunkOpen): pushq %rbp // stack frame is for the debugger movq %rsp, %rbp =20 @@ -1125,7 +1126,7 @@ ASM_PFX(GasketPosixFileSystmeThunkOpen): =20 movq %rcx, %rdi // Swizzle args =20 - call ASM_PFX(PosixFileSystmeThunkOpen) + call ASM_PFX(PosixFileSystemThunkOpen) =20 popq %rdi // restore state popq %rsi @@ -1133,8 +1134,8 @@ ASM_PFX(GasketPosixFileSystmeThunkOpen): ret =20 =20 -ASM_GLOBAL ASM_PFX(GasketPosixFileSystmeThunkClose) -ASM_PFX(GasketPosixFileSystmeThunkClose): +ASM_GLOBAL ASM_PFX(GasketPosixFileSystemThunkClose) +ASM_PFX(GasketPosixFileSystemThunkClose): pushq %rbp // stack frame is for the debugger movq %rsp, %rbp =20 @@ -1143,7 +1144,7 @@ ASM_PFX(GasketPosixFileSystmeThunkClose): =20 movq %rcx, %rdi // Swizzle args =20 - call ASM_PFX(PosixFileSystmeThunkClose) + call ASM_PFX(PosixFileSystemThunkClose) =20 popq %rdi // restore state popq %rsi --=20 2.30.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100707): https://edk2.groups.io/g/devel/message/100707 Mute This Topic: https://groups.io/mt/97414911/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-