From nobody Sun Feb 8 12:39:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+100700+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100700+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1677866668; cv=none; d=zohomail.com; s=zohoarc; b=LcqsQW45g7mMDlVhWiJe7Y3VUF87fbbIgeSN6kzec+o/++FxPjkgWfo2Er1VNCaI/guToMhCc865UtyBE8ZWMbBLcJaFLf6sVGx9XmOv3dr7cUT9UZQc6q0MyT6AmOMWH5bfSA+O2oTZlHEp16ofSBerO8iVTqLWY5ZHcD2xElw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677866668; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=fIcRqx+mpLJCukeHObHZ1JOndv+OLB/PAP8gQR8wZa0=; b=HBmJHh7yAPldvtgBtfIt7YfpHb8mklrmNzDcipezD1grQmVG+RGFnPTfWnAsLV49qYf974YO4y+89BJr/aUY5R9d00djBh9AobC4gShvhxn66VoyAhUEZum9DhY+FitoVRmEhez3nLWIDxXKN6bLCyqdqdH31MfBT+XQSiT+uGY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100700+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1677866668722310.9505968369607; Fri, 3 Mar 2023 10:04:28 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id hUjMYY1788612xEp96u7z6xQ; Fri, 03 Mar 2023 10:04:28 -0800 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.30787.1677866666579516306 for ; Fri, 03 Mar 2023 10:04:27 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="332593504" X-IronPort-AV: E=Sophos;i="5.98,231,1673942400"; d="scan'208";a="332593504" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2023 10:04:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="849541902" X-IronPort-AV: E=Sophos;i="5.98,231,1673942400"; d="scan'208";a="849541902" X-Received: from snainar-mobl1.amr.corp.intel.com (HELO awarkent-mobl1.amr.corp.intel.com) ([10.212.75.200]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2023 10:04:23 -0800 From: "Andrei Warkentin" To: devel@edk2.groups.io Cc: Andrei Warkentin , Daniel Schaefer , Sunil V L Subject: [edk2-devel] [edk2 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec Date: Fri, 3 Mar 2023 12:04:10 -0600 Message-Id: <20230303180410.6344-4-andrei.warkentin@intel.com> In-Reply-To: <20230303180410.6344-1-andrei.warkentin@intel.com> References: <20230303180410.6344-1-andrei.warkentin@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,andrei.warkentin@intel.com X-Gm-Message-State: Vo8vkfHxO23urcHHAgHt9W5Yx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1677866668; bh=INLhxOJYnE1RT6Qc09gCAwDwV/KQtA1v/Z0tIqKRkHw=; h=Cc:Date:From:Reply-To:Subject:To; b=wheIXFrsdvhPByZ14NmG3gA3Rnbwk70kSA0gff6HKfxn+yaxQ9A5PQrsk/QN0gwtQzV 86q73wStWhK9JnToRCh20FEgL3dBxOiUJCkM8uhpzn1j9V1KJwKobh3aqkYZaAO+ATHVz LWqi8mtt9fj9RatEIOZHq4kGsQN7Echq9Js= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1677866669076100001 Content-Type: text/plain; charset="utf-8" If the SerialPortLib had any initialization needed, this would be skipped in the RiscVVirt Sec. Follow the example seen elsewhere (ArmVirtPkg PrePi). Seen with BaseSerialPortLibRiscVSbi not using DBCN in Sec, yet using DBCN elsewhere. Cc: Daniel Schaefer Cc: Sunil V L Signed-off-by: Andrei Warkentin Reviewed-by: Sunil V L --- OvmfPkg/RiscVVirt/Sec/SecMain.inf | 1 + OvmfPkg/RiscVVirt/Sec/SecMain.h | 1 + OvmfPkg/RiscVVirt/Sec/SecMain.c | 4 +++- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.inf b/OvmfPkg/RiscVVirt/Sec/SecM= ain.inf index aed35d3af596..0e2a5785e8a4 100644 --- a/OvmfPkg/RiscVVirt/Sec/SecMain.inf +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.inf @@ -48,6 +48,7 @@ [LibraryClasses] FdtLib MemoryAllocationLib HobLib + SerialPortLib =20 [Ppis] gEfiTemporaryRamSupportPpiGuid # PPI ALWAYS_PRODUCED diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.h b/OvmfPkg/RiscVVirt/Sec/SecMai= n.h index 83a8058efe40..7c7650f0d298 100644 --- a/OvmfPkg/RiscVVirt/Sec/SecMain.h +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.h @@ -29,6 +29,7 @@ #include #include #include +#include #include =20 /** diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.c b/OvmfPkg/RiscVVirt/Sec/SecMai= n.c index adf73f2eb66c..db309ebdf1a3 100644 --- a/OvmfPkg/RiscVVirt/Sec/SecMain.c +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.c @@ -1,7 +1,7 @@ /** @file RISC-V SEC phase module for Qemu Virt. =20 - Copyright (c) 2008 - 2015, Intel Corporation. All rights reserved.
+ Copyright (c) 2008 - 2013, Intel Corporation. All rights reserved.
Copyright (c) 2022, Ventana Micro Systems Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent @@ -57,6 +57,8 @@ SecStartup ( UINT64 StackBase; UINT32 StackSize; =20 + SerialPortInitialize (); + // // Report Status Code to indicate entering SEC core // --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100700): https://edk2.groups.io/g/devel/message/100700 Mute This Topic: https://groups.io/mt/97368169/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-