Hi Gerd,
Yes, just like you said, no code logic modified, just relocation.
And thanks for your suggestion, but since it is a simple code change, but contains too many patches, if it is ok for you, I don't plan to send the whole patch series this time.
Thanks
Zhiguang
> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Monday, February 27, 2023 5:21 PM
> To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen
> <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>
> Subject: Re: [edk2-devel] [PATCH v4 0/9] merge UefiCpuPkg/UefiCpuLib to
> MdePkg/CpuLib
>
> On Mon, Feb 27, 2023 at 03:23:57PM +0800, Zhiguang Liu wrote:
> > V4:
> > This patch set has already gotten reviewed-by except OvmfPkg. Also V4
> has a little code change for OvmfPkg.
> > So I only sent pathces about OvmfPkg (patch NO.1 and NO.4) to avoid
> disturbing other Package Maintainers.
> > Other patches can check the V3 version or check the PR link
> > https://github.com/tianocore/edk2/pull/4066
>
> It is perfectly fine to repost the whole series, especially when v3 was posted
> months ago. It's good to add any review tags to the patches though to make
> clear which are reviewed already and which are not.
>
> > UefiCpuPkg which does not meet the design spec. So merge UefiCpuLib to
> > CpuLib is a good way to sovle these problems. To minimize the
> > impact,this change is carried out in four steps.
>
> > rename {UefiCpuPkg/Library/BaseUefiCpuLib =>
> > MdePkg/Library/BaseCpuLib}/Ia32/InitializeFpu.nasm (100%) rename
> > {UefiCpuPkg/Library/BaseUefiCpuLib =>
> > MdePkg/Library/BaseCpuLib}/X64/InitializeFpu.nasm (100%) rename
> > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c =>
> > MdePkg/Library/BaseCpuLib/X86BaseCpuLib.c (93%)
>
> So in essence this series moves the code unmodified (other than some
> reaming due to the new location) and updates all references?
>
> take care,
> Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100530): https://edk2.groups.io/g/devel/message/100530
Mute This Topic: https://groups.io/mt/97261627/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-