From nobody Mon Apr 29 06:31:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+100475+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100475+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1677197891; cv=none; d=zohomail.com; s=zohoarc; b=bk1+Sb84vpYUOD/czhH8yOLFGD8UKNJw3+iZm2hM6uCtVHD/NKOOZp2o3iWTvU2nilMfOXgguFpW4yS3Sv039HfI4QET1RTfDvu3y2LWwhv+wfVOgO7tvJ4ymskhcDwpAHDgm91YMm/lxQ+wAPoCtUv21CL8lbHVOmBekHK696k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677197891; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ms/wFSWyaUXuBAvoxjttCgP0uYD937sIqA+o0PsOC7E=; b=hUsm0xHQnsIQSxiAz+tgzg+v9sJhdrNh51Yma5TONFannAd2SV+p3E7QVKDIRYT+0r8PdPP/R1u20hw71hLikMOhggHFNx1mb7wc5fJZuaa2clqp7S3NG6DEuwF0PMM6jaoBhEKAsFcQRAeTuqf9Ma4o0txtBHPIhB1Bz4Bf300= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100475+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1677197891060383.6993042243847; Thu, 23 Feb 2023 16:18:11 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id RaxpYY1788612xglCQQySoAk; Thu, 23 Feb 2023 16:18:10 -0800 X-Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx.groups.io with SMTP id smtpd.web11.6030.1677197889830630291 for ; Thu, 23 Feb 2023 16:18:10 -0800 X-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2CFD95C00F2; Thu, 23 Feb 2023 19:18:09 -0500 (EST) X-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 23 Feb 2023 19:18:09 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekvddgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepgeffueeuledvgefgvddvgfetvdduhfefkedukeeikedtudekfeetteeifedv leefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprh gvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Feb 2023 19:18:08 -0500 (EST) From: "Rebecca Cran" To: devel@edk2.groups.io, Jian J Wang , Liming Gao , Hao A Wu , Ray Ni Cc: Rebecca Cran Subject: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Improve formatting of DEBUG messages in UsbBusDxe Date: Thu, 23 Feb 2023 17:18:01 -0700 Message-Id: <20230224001801.77708-2-rebecca@bsdio.com> In-Reply-To: <20230224001801.77708-1-rebecca@bsdio.com> References: <20230224001801.77708-1-rebecca@bsdio.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com X-Gm-Message-State: d93AFhTq37BmEZd2EbhHxf19x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1677197890; bh=VWus0BCOAxJOSq0wKn094ln10N+kx2urTdMoX+T7uv4=; h=Cc:Date:From:Reply-To:Subject:To; b=c5/pGVvkyvHlkIBvu8RmPHRb5gzmQuPsN+Ejmx3mqCwZ4uTNH7nsNYGm1vH7Ofq1iMw +jJUPUMbHQJKZUhtXBosewPnmKls+imTZ+qkXdx4qKkAgFf+qLn7itcIhe5fhdxNPiZog +eh/GF4rRNS64XAwS1p5hGoFy135MZwADMU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1677197892859100001 Content-Type: text/plain; charset="utf-8" Improve the formatting of DEBUG messages in UsbBusDxe by adding a hyphen to separate the EFI_STATUS code. Signed-off-by: Rebecca Cran Reviewed-by: Hao A Wu . --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 12 ++++++------ MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c | 6 +++--- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 2 +- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c b/MdeModulePkg/Bus/Usb= /UsbBusDxe/UsbBus.c index 6a3ac63c3aa0..c25f3cc2f279 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c @@ -838,7 +838,7 @@ UsbIoPortReset ( if (EFI_ERROR (Status)) { DEBUG (( DEBUG_ERROR, - "UsbIoPortReset: failed to reset hub port %d@hub %d, %r \n", + "UsbIoPortReset: failed to reset hub port %d@hub %d - %r\n", Dev->ParentPort, Dev->ParentAddr, Status @@ -945,7 +945,7 @@ UsbBusBuildProtocol ( ); =20 if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to open device path %r\n", S= tatus)); + DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to open device path - %r\n",= Status)); =20 FreePool (UsbBus); return Status; @@ -978,7 +978,7 @@ UsbBusBuildProtocol ( ); =20 if (EFI_ERROR (Status) && EFI_ERROR (Status2)) { - DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to open USB_HC/USB2_HC %r\n"= , Status)); + DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to open USB_HC/USB2_HC - %r\= n", Status)); =20 Status =3D EFI_DEVICE_ERROR; goto CLOSE_HC; @@ -1006,7 +1006,7 @@ UsbBusBuildProtocol ( ); =20 if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to install bus protocol %r\n= ", Status)); + DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to install bus protocol - %r= \n", Status)); goto CLOSE_HC; } =20 @@ -1054,7 +1054,7 @@ UsbBusBuildProtocol ( Status =3D mUsbRootHubApi.Init (RootIf); =20 if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to init root hub %r\n", Stat= us)); + DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to init root hub - %r\n", St= atus)); goto FREE_ROOTHUB; } =20 @@ -1102,7 +1102,7 @@ UsbBusBuildProtocol ( ); FreePool (UsbBus); =20 - DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to start bus driver %r\n", Sta= tus)); + DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to start bus driver - %r\n", S= tatus)); return Status; } =20 diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c b/MdeModulePkg/Bus/Us= b/UsbBusDxe/UsbDesc.c index a620a670748c..8b078e7e4936 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c @@ -761,7 +761,7 @@ UsbGetOneConfig ( if (EFI_ERROR (Status)) { DEBUG (( DEBUG_ERROR, - "UsbGetOneConfig: failed to get descript length(%d) %r\n", + "UsbGetOneConfig: failed to get descript length(%d) - %r\n", Desc.TotalLength, Status )); @@ -787,7 +787,7 @@ UsbGetOneConfig ( Status =3D UsbCtrlGetDesc (UsbDev, USB_DESC_TYPE_CONFIG, Index, 0, Buf, = Desc.TotalLength); =20 if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "UsbGetOneConfig: failed to get full descript %r\= n", Status)); + DEBUG ((DEBUG_ERROR, "UsbGetOneConfig: failed to get full descript - %= r\n", Status)); =20 FreePool (Buf); return NULL; @@ -891,7 +891,7 @@ UsbBuildDescTable ( Status =3D UsbBuildLangTable (UsbDev); =20 if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_INFO, "UsbBuildDescTable: get language ID table %r\n", S= tatus)); + DEBUG ((DEBUG_INFO, "UsbBuildDescTable: get language ID table - %r\n",= Status)); } =20 return EFI_SUCCESS; diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c b/MdeModulePkg/Bus/= Usb/UsbBusDxe/UsbEnumer.c index aed34596f469..b3a40639f280 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c @@ -440,7 +440,7 @@ UsbSelectConfig ( if (EFI_ERROR (Status)) { DEBUG (( DEBUG_WARN, - "UsbSelectConfig: failed to connect driver %r, ignored\n", + "UsbSelectConfig: failed to connect driver - %r, ignored\n", Status )); } diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c b/MdeModulePkg/Bus/Usb= /UsbBusDxe/UsbHub.c index 0497a73f443c..1a473d099892 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c @@ -609,7 +609,7 @@ UsbHubInit ( Status =3D UsbHubReadDesc (HubDev, HubDesc); =20 if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "UsbHubInit: failed to read HUB descriptor %r\n",= Status)); + DEBUG ((DEBUG_ERROR, "UsbHubInit: failed to read HUB descriptor - %r\n= ", Status)); return Status; } =20 --=20 2.37.1 (Apple Git-137.1) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100475): https://edk2.groups.io/g/devel/message/100475 Mute This Topic: https://groups.io/mt/97196506/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-