From nobody Fri May 17 04:59:57 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100194+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 167641294003768.65483667333672; Tue, 14 Feb 2023 14:15:40 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id j1mNYY1788612xmKY4TktxF2; Tue, 14 Feb 2023 14:15:39 -0800 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.78]) by mx.groups.io with SMTP id smtpd.web11.1317.1676412938674509108 for ; Tue, 14 Feb 2023 14:15:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aKjDih4mtubLvnfK2LqWrtOQBBXhG2ct399NS2JlAtGgs1rSqteMkurALGwesMMaOWQ1In61a6MBIdz3pZx/wtMXY6+vAEgON+Ubh4kxbCFzEPqBTK+FNsiSUiciQe41vXvjufu0fLOP49QWuYLUtI9kLKGAhT/QmboHA8MGfmNOz5leG5ohozHgIToIMlzRLNqOWMaElfQ7dH30w5HZa9FNTl+1cgJBZ/xXgJ2vxJtmH9BwkIjT2bNUsFKRVB+Ta9AsHgi9YegOY1+24PclEKmdCp8GCZVRY7ohlWm3ae3Z3PpLbdSLEpl0o6peZKlX0OryFAXHrjTv6DIN4fZAzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ybxEqDaaKq73Zxqix1hSE9w2aX3rcHHnbl31EsWuV+g=; b=jEEVBvKQmhJCReciyUCueI71Rfb5TjcxuzjtmSMk1a66JN+x9GtHLyGSThuogpHvFpK1T0uAArwSqecuD21qOVrxLQwiYmmItCtDLjOXivL/BueShAh6W8Q7Uhvz97AAWKPTItOKews/OzJAGb2+TNvF/N1IdfL571sniqQI1s818F7kB03GeXzoEe7fMXsQZLnCCBisCknhjeuyZrBJNgfq6OqNF58wXD63r8cA4HDrnJYH16rup1/+aCaBTZqeCfITVEJdkeu/TjxkGPuwcKzklEhIb1XstSA3yI5zY8lnpvBRjrDC4cUx86CHWvQqLBX1nERnuqvNmizVD6O28Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from MW4PR04CA0322.namprd04.prod.outlook.com (2603:10b6:303:82::27) by DM6PR12MB4058.namprd12.prod.outlook.com (2603:10b6:5:21d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 22:15:36 +0000 X-Received: from CO1NAM11FT050.eop-nam11.prod.protection.outlook.com (2603:10b6:303:82:cafe::cf) by MW4PR04CA0322.outlook.office365.com (2603:10b6:303:82::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26 via Frontend Transport; Tue, 14 Feb 2023 22:15:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+100194+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT050.mail.protection.outlook.com (10.13.174.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.26 via Frontend Transport; Tue, 14 Feb 2023 22:15:36 +0000 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 14 Feb 2023 16:15:35 -0600 X-Received: from pankaj-M75q.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 14 Feb 2023 16:15:35 -0600 From: "Gupta, Pankaj via groups.io" To: CC: , , , , , , , , Subject: [edk2-devel] [PATCH] OvmfPkg: Remove gbs FreePool in AcceptAllMemory() Date: Tue, 14 Feb 2023 16:15:34 -0600 Message-ID: <20230214221534.3912898-1-pankaj.gupta@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT050:EE_|DM6PR12MB4058:EE_ X-MS-Office365-Filtering-Correlation-Id: 764fe28d-c52b-4ec8-eb36-08db0ed8ff6b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: /BWDERuF8wz0ZRuV3bJOwtu171sRPK89TzEMxtZKxvdyhaD93xkKrCVsv1F6ddAMFNbVG/OFtIH6dUFumvAXyfUsKCkqKbZStEiY/alHuS3v6/wwTG8Lx535tL/I2FZSCcMHd3407H4yD5lY49yHTWKgWEBJSMCbAcZmaNMQuszqUYdIavUcF59TFC98nyBrU6YkrMtOozObC7qS7LqpJ+dhQtxaY9qz/AyMLd54Y91jQajb7tbrYPVwBxOb2d+bZioLAFvHH73a6Q355HEao2uWUwofUErDlQ3rmwBwRR8/CAuqQv4nF46jUWGcVh3QmjX9OB7x+bAfLzbqETdvNYn+yJmcFQnuiaazv6ImEsRcbKln22zdjBnA4YMlzJ6YhJSU11jaA0AuzQfZdelqCiX/srh7NGh6X1M3tAv4F8G1Ew6CfLRwck5cLLKPVJ3QhKlagaWNIQqMWAJLRcum6ezpX5qfi3xiJOfuK7/inVS0BcyybVjBwr7P2SpTqt4LIHiwsGQoXtj7yG0GzBOCDY4XWeOwBktxGxkhHLXln3Vghep0rASFQvwbNfCs0rRL0LNaMZG0Fcy8ngM4f0JxAXdVgHOI6ict6KOPAtAEKN/cc1lXZjdJEsvMxiHyh+N/ric1Hha6povE+cQz2BBr/feyBg2oIsoSyi/Qvt+pX6vUQybib94DWyV3YHyaNZvTtD5o7spsCjPbfS180yiKDSHf4aPFYJvaUlOpgqZYaXw= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 22:15:36.2638 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 764fe28d-c52b-4ec8-eb36-08db0ed8ff6b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT050.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4058 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pankaj.gupta@amd.com X-Gm-Message-State: autn4RiiqfqdpoWEsHHLVjurx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1676412939; bh=NgwghW4dr5UgEgmAzXRgopopmn1TSl/DomPN+EsYtR8=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Fqfddck7i7iPUC+HerpbE5j0go7xylhmpEVJJxuS282X7mds1/kTuxGmmfIYQgu4VCe bKByrqGoyWcGuebWQUqBPMSf0dqx9/nPLKx5808ezWB0xFYKt8EoEGmgw4qe67tJBqihQ SFcbYh3QUEs4SGl2EhBnmcJrK1CGvK3OAnA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1676412940667100002 Content-Type: text/plain; charset="utf-8" System Memory map is changed when a memory range is Accepted. While returning from AcceptAllMemory(), "gBS->FreePool" is wrongly used which results in changing memory map and hence return an error. Fix this by removing the "gBs->FreePool" call altogether. Before this patch, KVM guest throws an error and control goes to the boat loader menu every time we select an OS: EFI stub: ERROR: exit_boot() failed! EFI stub: ERROR: efi_main() failed! StartImage failed: Invalid Parameter Fixes: a00e2e5513 ("OvmfPkg: Add memory acceptance event in AmdSevDxe") Signed-off-by: Pankaj Gupta --- OvmfPkg/AmdSevDxe/AmdSevDxe.c | 1 - 1 file changed, 1 deletion(-) diff --git a/OvmfPkg/AmdSevDxe/AmdSevDxe.c b/OvmfPkg/AmdSevDxe/AmdSevDxe.c index 6391d1f775..f52dbfe597 100644 --- a/OvmfPkg/AmdSevDxe/AmdSevDxe.c +++ b/OvmfPkg/AmdSevDxe/AmdSevDxe.c @@ -123,7 +123,6 @@ AcceptAllMemory ( } } =20 - gBS->FreePool (AllDescMap); return Status; } =20 --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100194): https://edk2.groups.io/g/devel/message/100194 Mute This Topic: https://groups.io/mt/96971535/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-