From nobody Mon Feb 9 21:21:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+100125+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100125+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1676316004; cv=none; d=zohomail.com; s=zohoarc; b=l1k/39EhuXsQh54Jkm9dqpXoxMvguIqIdsM7sMJpWTajakOJfNM9HR8NQvJXzLQmN0KZnM7zHA0/AT6/GA4DV78aGpgj1qzyagpDlKKoCqMTMo07o2bcNdILxF4NLDhGJ8Td/38oXDosyKHkeksVU0mw1+rPuoVE3c+sGEHGuhM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676316004; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=nxJwk4+E9nZ5noIRGBbCZrNyGjhLyoH2H9z9oLUCZwI=; b=VRj7Qaz4/OZp73/8YV4X+dkxHDKt8h2eXp1qRNYEXWFooWTMS3RTGwzWosfTgfUanoamo2R+L74ZSu6MkwX8F8JhEO4poD8srXtH0GnWSqb10Le7J6iB07ndqV31hrkOyszF43NIKUiwsU+KF4WqWS8+XG1C345dWsDKRTUNpWU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100125+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1676316004851527.6921091799397; Mon, 13 Feb 2023 11:20:04 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id o618YY1788612x23x2FxfOlY; Mon, 13 Feb 2023 11:20:04 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.24582.1676316003987385945 for ; Mon, 13 Feb 2023 11:20:04 -0800 X-Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-76-6GjJDboPNHKK0RlHSoskYg-1; Mon, 13 Feb 2023 14:20:01 -0500 X-MC-Unique: 6GjJDboPNHKK0RlHSoskYg-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3AD9E1C09041 for ; Mon, 13 Feb 2023 19:20:01 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 08B191121318; Mon, 13 Feb 2023 19:20:01 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 198F9180039F; Mon, 13 Feb 2023 20:19:58 +0100 (CET) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Oliver Steffen , Pawel Polawski , Gerd Hoffmann Subject: [edk2-devel] [PATCH 2/4] CryptoPkg/BaseCryptLib: avoid using SHA256() Date: Mon, 13 Feb 2023 20:19:56 +0100 Message-Id: <20230213191958.913689-3-kraxel@redhat.com> In-Reply-To: <20230213191958.913689-1-kraxel@redhat.com> References: <20230213191958.913689-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com X-Gm-Message-State: GeXvtNn83L3xG9f0G74radA4x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1676316004; bh=qWKoOUE38C/m0TdYNhpUlQcjRdLUZ9SqbGwfH2z5qrk=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=HRHkJmewF91TebjUA5gRCgKmr6LxSyKepD6L4WNpSUWxEFtcW9dXS1l2opa6WZuVbF5 RsbOd5Z7DWO+MmuCiCCvqGsI9Cu5AAN+/HM8BiCitUg/JtANDGdJ7mN+xhwHaG2o31D/R nxtkpMoaL45Cxd0p0BI9XYxJwFcFo3ZsdlM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1676316006253100010 Content-Type: text/plain; charset="utf-8"; x-default="true" In openssl 3.0 SHA256() goes through the provider logic, requiring a huge amount of openssl code. The individual functions do not, so use them instead. Signed-off-by: Gerd Hoffmann --- .../Library/BaseCryptLib/Hash/CryptSha256.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/Hash/CryptSha256.c b/CryptoPkg/= Library/BaseCryptLib/Hash/CryptSha256.c index f105e6e57708..4d7d92812c4d 100644 --- a/CryptoPkg/Library/BaseCryptLib/Hash/CryptSha256.c +++ b/CryptoPkg/Library/BaseCryptLib/Hash/CryptSha256.c @@ -202,6 +202,8 @@ Sha256HashAll ( OUT UINT8 *HashValue ) { + SHA256_CTX Context; + // // Check input parameters. // @@ -216,9 +218,17 @@ Sha256HashAll ( // // OpenSSL SHA-256 Hash Computation. // - if (SHA256 (Data, DataSize, HashValue) =3D=3D NULL) { + if (!SHA256_Init (&Context)) { return FALSE; - } else { - return TRUE; } + + if (!SHA256_Update (&Context, Data, DataSize)) { + return FALSE; + } + + if (!SHA256_Final (HashValue, &Context)) { + return FALSE; + } + + return TRUE; } --=20 2.39.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100125): https://edk2.groups.io/g/devel/message/100125 Mute This Topic: https://groups.io/mt/96943601/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-