From nobody Sun Feb 8 19:39:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+100103+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100103+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1676303387; cv=none; d=zohomail.com; s=zohoarc; b=QWE4jttJ700A9AFkOHPe0yUz8cz4VB+KhQE8G9RWNpBw7ErK/s2Fl+rPKwInUPAtuGQ/Xv+em4VuwLLJZtC0u++MA6NFHktHdKuToEiD3wrgb739NrFoOvcXUjx9schKi1yKhhuIl4fdmdN9t2myu0AToASUiSW1x5b6Vhjeyto= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676303387; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Skmr5Sr4SpOQ42fWoOYAfRHYTKMQewPUsoTphXJxsxw=; b=XjgL+EvBiFAAuProd5wJwqwH2OkJOB1fh+3YwIBnAqAvXApnlzk1+gjmLzOFHHdTP73qb9jezXZsJuUWRnd/cOgWGX+Adtifwv8IBLMN5J6N3ZtX8dPmkeJZgA+KWGG2RNeK/VSW/8iVC6toh3xQlRYzw3H5LQFOGtU5HhKutHc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100103+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1676303387892953.862026869914; Mon, 13 Feb 2023 07:49:47 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id Qrv6YY1788612xjAUIa3bvGw; Mon, 13 Feb 2023 07:49:47 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.17793.1676303386775606498 for ; Mon, 13 Feb 2023 07:49:46 -0800 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 58D1820C8B7C; Mon, 13 Feb 2023 07:49:45 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 58D1820C8B7C From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Michael D Kinney , Sean Brogan , Yuwei Chen Subject: [edk2-devel] [PATCH v3 02/12] BaseTools/PatchCheck.py: Add PCCTS to tab exemption list Date: Mon, 13 Feb 2023 10:48:58 -0500 Message-Id: <20230213154908.1993-3-mikuback@linux.microsoft.com> In-Reply-To: <20230213154908.1993-1-mikuback@linux.microsoft.com> References: <20230213154908.1993-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: 8OJ4iPg6qyicw9JztVsGf0gkx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1676303387; bh=sARWhH4UZyLrKn6Au5E4UigGFB+K9PpBbkCBuZ+A/WA=; h=Cc:Date:From:Reply-To:Subject:To; b=N+0OgFWEsADVct/5mx5yVuEZaFeBbkuMuQ6HrJZ/P5e1S5vxlA6DORjZ/AbeyazOdQc ejJD0Ffq0l3kMYlQLm5MR93FppMRoq2mUr0jcrPx6GMYvMCQhZEnqXPcgxjfVqFw1ERQd EiZvV97N5jeMw2OfWz66V86DzP+Z1c+GQhw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1676303388750100002 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki Purdue Compiler Construction Tool Set (PCCTS) source code was copied/ pasted into BaseTools/Source/C/VfrCompile/Pccts/. The code contains tab characters instead of spaces. PatchCheck.py gives an error on modifications to files that contain tabs. This change adds that directory to the pre-existing list of directories in which tab checks are ignored in PatchCheck.py. The goal of my upcoming change there is not to mix tabs and spaces but to fix a bug while preserving its current formatting characters. Cc: Bob Feng Cc: Liming Gao Cc: Michael D Kinney Cc: Sean Brogan Cc: Yuwei Chen Signed-off-by: Michael Kubacki Reviewed-by: Liming Gao Reviewed-by: Michael D Kinney --- BaseTools/Scripts/PatchCheck.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index fcdabfc8acea..84d56b8c8b70 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -383,7 +383,9 @@ class GitDiffCheck: self.force_crlf =3D False self.force_notabs =3D False if os.path.basename(self.filename) =3D=3D 'GNUmakefile' or= \ - os.path.basename(self.filename) =3D=3D 'Makefile': + os.path.basename(self.filename) =3D=3D 'Makefile' or \ + self.filename.startswith( + 'BaseTools/Source/C/VfrCompile/Pccts/'): self.force_notabs =3D False elif len(line.rstrip()) !=3D 0: self.format_error("didn't find diff command") --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100103): https://edk2.groups.io/g/devel/message/100103 Mute This Topic: https://groups.io/mt/96938296/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-