From nobody Mon Feb 9 19:30:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+100062+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100062+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1676277867; cv=none; d=zohomail.com; s=zohoarc; b=A903/FYgJEFMSUwR2L/aCKy6obeEKXWPEQKVqgMwZ6jawDnqzW+eULXrGX+zHIaYLnFs/44bibWSMKdrOcF0hVEwR6sp79dfrhaEyKH2AN7sPkqlDHqvj60oHmV6oO2waYFyRKF4Hm+SmYA5PNuv/k9+WheADtU4LDb7PgV5WGc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676277867; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=atlUTsEqv2Iab4rQlZa7Btou1wsl8JDBac2j9ZLVtww=; b=KOkj9beLOyKKiaP2KjKZAThf69xOTIlyBU+4+wj99w3H5aFdGeZhjjwHUdDGWNG58TANC2J4cxVyAt8YgkUzlZG1JR5Wea9nnaOSoXmqAP+dS590BwWqTh5b6wGuFKGMlzxhympHaeHV2qoH+J0g+eH7t+gXpsstooslIP3dw6k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+100062+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1676277867232446.5599273434857; Mon, 13 Feb 2023 00:44:27 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id TefcYY1788612xnGjUGGKkYC; Mon, 13 Feb 2023 00:44:26 -0800 X-Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.10224.1676277864494251584 for ; Mon, 13 Feb 2023 00:44:26 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10619"; a="310474662" X-IronPort-AV: E=Sophos;i="5.97,293,1669104000"; d="scan'208";a="310474662" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 00:44:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10619"; a="646309670" X-IronPort-AV: E=Sophos;i="5.97,293,1669104000"; d="scan'208";a="646309670" X-Received: from sh1gapp1009.ccr.corp.intel.com ([10.239.189.79]) by orsmga006.jf.intel.com with ESMTP; 13 Feb 2023 00:44:23 -0800 From: "Wu, Jiaxin" To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Zeng Star , Laszlo Ersek , Gerd Hoffmann , Rahul Kumar Subject: [edk2-devel] [PATCH v6 1/6] UefiCpuPkg/PiSmmCpuDxeSmm: Fix invalid InitializeMpSyncData call Date: Mon, 13 Feb 2023 16:44:12 +0800 Message-Id: <20230213084417.9232-2-jiaxin.wu@intel.com> In-Reply-To: <20230213084417.9232-1-jiaxin.wu@intel.com> References: <20230213084417.9232-1-jiaxin.wu@intel.com> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com X-Gm-Message-State: dUlZf2PLtzgeiCWiVgaUudOOx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1676277866; bh=Q+Bd17cIJ6aoxumg1yEzh79BywoJ72c9LTCiRxMZDzc=; h=Cc:Date:From:Reply-To:Subject:To; b=fwIV7jUPP/0KBVmpH1yrjGKo2cnxEsAoKU168CrwOD/0LQYdsv6W5xIhHx+0dmC0xJv D4vWFekyLUNX22poj2D2sKKjgVP66Qv1PrkOEX00e5X7RboXh3xZ6n+kEc7P982e6TtRy 9zX7eMdTydY49aWyQWjhyj/kJJH3ZonxqUY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1676277868894100005 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4338 No need call InitializeMpSyncData during normal boot SMI init, because mSmmMpSyncData is NULL at that time. mSmmMpSyncData is allocated in InitializeMpServiceData, which is invoked after normal boot SMI init (SmmRelocateBases). Cc: Eric Dong Cc: Ray Ni Cc: Zeng Star Cc: Laszlo Ersek Cc: Gerd Hoffmann Cc: Rahul Kumar Signed-off-by: Jiaxin Wu Reviewed-by: Ray Ni --- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c b/UefiCpuPkg/PiSmmC= puDxeSmm/PiSmmCpuDxeSmm.c index 655175a2c6..2ac655d032 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c @@ -1,9 +1,9 @@ /** @file Agent Module to load other modules to deploy SMM Entry Vector for X86 CPU. =20 -Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2009 - 2023, Intel Corporation. All rights reserved.
Copyright (c) 2017, AMD Incorporated. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -369,13 +369,11 @@ SmmInitHandler ( if (!mSmmS3Flag) { // // Check XD and BTS features on each processor on normal boot // CheckFeatureSupported (); - } - - if (mIsBsp) { + } else if (mIsBsp) { // // BSP rebase is already done above. // Initialize private data during S3 resume // InitializeMpSyncData (); --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100062): https://edk2.groups.io/g/devel/message/100062 Mute This Topic: https://groups.io/mt/96931997/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-