From nobody Tue Feb 10 10:04:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+99449+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99449+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1675333303; cv=none; d=zohomail.com; s=zohoarc; b=VVYozt97fDBGBmF/QHjvGDIDRWXyM447fgVN8S68JhKpBwbqHqCTyrcbmwFH2nBKB/j6kaXCbPGJmJVgwyme6ZCtHPsLmaObsvxZ6RGkgVJLZwbEfk/L055zD6xLjCzp8Yqbl0QLlxEQyJrUCpzOgKCE8u2Kra0SeJJKSaisJlM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675333303; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Pai2Ht5pWBuTTmpobkOcXDCy9qUkIn6CtiResz9CHZE=; b=gvyWLYZjwmwEc4dK11XbV3PW2iEFGetxBg/f4gGKarhNltM0r+uSdLD6LBHyxlsJbNIB5KhjzuVkIvoVmCmEu2ICvveJsl8SAH14tF7/V3KOaZPZYqCGEyalQnssu5n1IfvOurIRSIb/MfIVemRF8+C9QAlk74Xl1zxD68vLlqE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99449+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 167533330307071.51597650397991; Thu, 2 Feb 2023 02:21:43 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id lvWLYY1788612xnnWv5vYBZv; Thu, 02 Feb 2023 02:21:42 -0800 X-Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by mx.groups.io with SMTP id smtpd.web10.11488.1675333301816810625 for ; Thu, 02 Feb 2023 02:21:42 -0800 X-Received: by mail-ed1-f41.google.com with SMTP id eq11so1466605edb.6 for ; Thu, 02 Feb 2023 02:21:41 -0800 (PST) X-Gm-Message-State: plhQlJry8qiPwt3h4f7qMY2kx1787277AA= X-Google-Smtp-Source: AK7set+TImjv2BidbYL25VRFK7NI0t3SjyyEJ0GvqxBoz3liDkGX7baamApUn83WNYJ/E3dLxfdhPw== X-Received: by 2002:aa7:d481:0:b0:4a2:1618:d702 with SMTP id b1-20020aa7d481000000b004a21618d702mr5607537edr.18.1675333300129; Thu, 02 Feb 2023 02:21:40 -0800 (PST) X-Received: from localhost.localdomain ([176.62.67.29]) by smtp.gmail.com with ESMTPSA id ci22-20020a170906c35600b0087bcda2b07bsm10013121ejb.202.2023.02.02.02.21.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 02 Feb 2023 02:21:39 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-devel] [edk2-platforms][PATCH v4 03/12] Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group Date: Thu, 2 Feb 2023 16:21:24 +0600 Message-Id: <20230202102133.51606-4-savvamtr@gmail.com> In-Reply-To: <20230202102133.51606-1-savvamtr@gmail.com> References: <20230202102133.51606-1-savvamtr@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,savvamtr@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1675333302; bh=rPEQR0XPh1sEI82eVy7EbT6bF1627ojQ7Zv94/C3YGY=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=InT28aWTZ9PnskrfYoGkFnEv6mKtS6bEbdxfDOaj7GLRVc+SgbTvgX9RZIC9r/vRtEE DK64UwGm4oiBw/wUJN8y0S9F5PFgH+kDflivBtQGv4toXs7AvCNwGFFg1KyIC0Z3FsCrj OpXlXTnUELwULU5Oc/Tz1UXjel7h02ETeRk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1675333305250100015 Content-Type: text/plain; charset="utf-8" Superblock s_inodes_per_group field can't be zero, it leads to division by zero in BlockGroup routine Ext4ReadInode Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.") Signed-off-by: Savva Mitrofanov Reviewed-by: Pedro Falcato Reviewed-by: Marvin H=C3=A4user --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext4D= xe/Superblock.c index 35dcf3c007c8..be3527e4d618 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c @@ -243,6 +243,11 @@ Ext4OpenSuperblock ( =20 DEBUG ((DEBUG_FS, "Read only =3D %u\n", Partition->ReadOnly)); =20 + if (Sb->s_inodes_per_group =3D=3D 0) { + DEBUG ((DEBUG_ERROR, "[ext4] Inodes per group can not be zero\n")); + return EFI_VOLUME_CORRUPTED; + } + Partition->BlockSize =3D (UINT32)LShiftU64 (1024, Sb->s_log_block_size); =20 // The size of a block group can also be calculated as 8 * Partition->Bl= ockSize --=20 2.39.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99449): https://edk2.groups.io/g/devel/message/99449 Mute This Topic: https://groups.io/mt/96697368/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-