From nobody Tue Feb 10 10:04:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+99448+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99448+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1675333301; cv=none; d=zohomail.com; s=zohoarc; b=YofN3caQbUqFhLgwojnMW2rE5Pl6wTnrZ3VZiAVq2fHKx0mRY24qUsgX9aqcWLKU/k+pqNSGZa9zkC3EkILB3BPYercG4qQagB2CUHoIoIk4WvDy2Ta5dwlhS9g30aXIWbsVoMhc/JS1cAR9leqW93zQpqHu8bLkOe/PW/NJxP0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675333301; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=JJOjgJurbrWYhozRSJ6dVGx0aIN2b08iKPWFtbbipoM=; b=JwXtEWIYF1KNugXJcxrCUytGa/PhmEN6iD2L2DMrc4RwUS25mk/fgNy0K03IgXvh+A5s2Dxc7m2RBV8VvVHnFI3PpZQI8OkWI7CvfYT9Qkqoxg5W4Rt7v4c8ecSqk9TwtS7G4p9BTyZYxajX80dDhw7yTS1yDaAUgrwIyTI4CBE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99448+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1675333301845271.88241299435015; Thu, 2 Feb 2023 02:21:41 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id DWXSYY1788612x8JVdXAnjCw; Thu, 02 Feb 2023 02:21:41 -0800 X-Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by mx.groups.io with SMTP id smtpd.web10.11487.1675333300851208931 for ; Thu, 02 Feb 2023 02:21:41 -0800 X-Received: by mail-ej1-f49.google.com with SMTP id m2so4524644ejb.8 for ; Thu, 02 Feb 2023 02:21:40 -0800 (PST) X-Gm-Message-State: co8xcDjSb8UufCrploRU7PRex1787277AA= X-Google-Smtp-Source: AK7set+SnRzfAuGRRl35pW898svXH0qkzGkSkOgq5Dc/b+3c5G1nDWfyEKQE3u+Shgk22quK2ZeCVw== X-Received: by 2002:a17:906:a246:b0:881:9531:35a1 with SMTP id bi6-20020a170906a24600b00881953135a1mr5922310ejb.41.1675333299021; Thu, 02 Feb 2023 02:21:39 -0800 (PST) X-Received: from localhost.localdomain ([176.62.67.29]) by smtp.gmail.com with ESMTPSA id ci22-20020a170906c35600b0087bcda2b07bsm10013121ejb.202.2023.02.02.02.21.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 02 Feb 2023 02:21:38 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-devel] [edk2-platforms][PATCH v4 02/12] Ext4Pkg: Fix incorrect checksum metadata feature check Date: Thu, 2 Feb 2023 16:21:23 +0600 Message-Id: <20230202102133.51606-3-savvamtr@gmail.com> In-Reply-To: <20230202102133.51606-1-savvamtr@gmail.com> References: <20230202102133.51606-1-savvamtr@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,savvamtr@gmail.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1675333301; bh=Fd7YRRkndmAY264nbUGJVHoY6oNOExYwkOlI3XvBI+Y=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=OYIvH4VjsI8xw6qL1sSTjoXkvpdFU/L73WDoRhCwDVwINWm6WU4VVeno6Y4ceywIW+I k3YP0PnnyHdhCx7F3Xw3kQl//QY6Ws039L5uV6qRBAgs02PRwrTO5QtuwCA/db29Tatlk CFlMOV9/ozHRNHhbUi+oc/rlr8r4U1YSE6k= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1675333303213100011 We need to check EXT4_FEATURE_RO_COMPAT_METADATA_CSUM in the FeatureRoCompat field instead of FeaturesCompat. The proper way to do this is to use macro EXT4_HAS_METADATA_CSUM. Also, replace the EXT4_FEATURE_INCOMPAT_CSUM_SEED check with predefined macro EXT4_HAS_INCOMPAT Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.") Signed-off-by: Savva Mitrofanov Reviewed-by: Pedro Falcato Reviewed-by: Marvin H=C3=A4user --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext4D= xe/Superblock.c index 5a3c7f478187..35dcf3c007c8 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c @@ -220,13 +220,11 @@ Ext4OpenSuperblock ( } =20 // At the time of writing, it's the only supported checksum. - if (Partition->FeaturesCompat & EXT4_FEATURE_RO_COMPAT_METADATA_CSUM && - (Sb->s_checksum_type !=3D EXT4_CHECKSUM_CRC32C)) - { + if (EXT4_HAS_METADATA_CSUM (Partition) && (Sb->s_checksum_type !=3D EXT4= _CHECKSUM_CRC32C)) { return EFI_UNSUPPORTED; } =20 - if ((Partition->FeaturesIncompat & EXT4_FEATURE_INCOMPAT_CSUM_SEED) !=3D= 0) { + if (EXT4_HAS_INCOMPAT (Partition, EXT4_FEATURE_INCOMPAT_CSUM_SEED)) { Partition->InitialSeed =3D Sb->s_checksum_seed; } else { Partition->InitialSeed =3D Ext4CalculateChecksum (Partition, Sb->s_uui= d, 16, ~0U); --=20 2.39.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99448): https://edk2.groups.io/g/devel/message/99448 Mute This Topic: https://groups.io/mt/96697367/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-