From nobody Tue Feb 10 10:04:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+99455+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99455+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1675333309; cv=none; d=zohomail.com; s=zohoarc; b=dewSXyotSru4kHznKocxIZUUxfBP8rDduDFj1/CQkg+2P4McztXOuvCUCstLktxzpet8LsS7RSP4NWEfsDX6v2Yh4Bhx75ZCKv1FBastxnk/cP4vZcO+CZDv+i4uZ8RxvU0pvCMajdYd2G+gcVk9n3a2vPP8rmaeXQD9GiDmhv0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675333309; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=vAQ5kOw8tWbF3ddWjLnJpmrim6XBk6do66whsWJyVRU=; b=FM8gkDhW/2hnbpaznAnpNql9407T7dRpTS3s6ENmZ33uw2EJo0LygK1zDcV6ja9BGpfa+5GhuT09p+ZjByDnlzQ443hKwrnNeiXuvsTtTFECHe2fKsZzCJoez3npKL8q4BAhgNcCRSnLi7TD8a52AK5xDhpsuEQhjGZlcJxGEIQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99455+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1675333309457168.71189170808702; Thu, 2 Feb 2023 02:21:49 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id uUKmYY1788612x2mWrdtRoqV; Thu, 02 Feb 2023 02:21:49 -0800 X-Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by mx.groups.io with SMTP id smtpd.web10.11492.1675333308245637613 for ; Thu, 02 Feb 2023 02:21:48 -0800 X-Received: by mail-ej1-f53.google.com with SMTP id k4so4622209eje.1 for ; Thu, 02 Feb 2023 02:21:48 -0800 (PST) X-Gm-Message-State: ISqa7p9iR4pK4Njn3tdpMe5tx1787277AA= X-Google-Smtp-Source: AK7set9q3GKw/DHpEH0PRL2CkWszUtMaKeZWshdoSND+OV1SipXQ9iDkrkfzqvANTWTqThkKLyMcpQ== X-Received: by 2002:a17:906:5ac7:b0:882:1b70:8962 with SMTP id x7-20020a1709065ac700b008821b708962mr5492645ejs.76.1675333306640; Thu, 02 Feb 2023 02:21:46 -0800 (PST) X-Received: from localhost.localdomain ([176.62.67.29]) by smtp.gmail.com with ESMTPSA id ci22-20020a170906c35600b0087bcda2b07bsm10013121ejb.202.2023.02.02.02.21.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 02 Feb 2023 02:21:46 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-devel] [edk2-platforms][PATCH v4 09/12] Ext4Pkg: Add missing exit Status in Ext4OpenDirent Date: Thu, 2 Feb 2023 16:21:30 +0600 Message-Id: <20230202102133.51606-10-savvamtr@gmail.com> In-Reply-To: <20230202102133.51606-1-savvamtr@gmail.com> References: <20230202102133.51606-1-savvamtr@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,savvamtr@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1675333309; bh=TTJh252Kv8xpDg9uRT7jH8O+R4V9o4nbIITb/+m+lbE=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=hkgICK+uZOJaeikyYXMrxxFydty829yFx1l5TH8SzKFLn6RB7REHWHZnhAqNHI3WRaD riwTbCDFr5loKRjIjmlOakENIH+Pr3D1GtmRhFe2QXDKDH6wE49IRSpie6l6C2gJfMel1 OfXtFA6S8e0gUsCYAJsNK/Nsg99ZlwpV6tA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1675333311354100002 Content-Type: text/plain; charset="utf-8" Missing EFI_OUT_OF_RESOURCES exit status on failed Ext4CreateDentry leads to NULL-pointer dereference in Ext4GetFileInfo (passing NULL buffer in Ext4ReadDir) Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: 21b1853880d5 ("Ext4Pkg: Add a directory entry tree.") Signed-off-by: Savva Mitrofanov Reviewed-by: Pedro Falcato Reviewed-by: Marvin H=C3=A4user --- Features/Ext4Pkg/Ext4Dxe/Directory.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Directory.c b/Features/Ext4Pkg/Ext4Dx= e/Directory.c index c7992cc72717..dee8cfc66cb7 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Directory.c +++ b/Features/Ext4Pkg/Ext4Dxe/Directory.c @@ -267,7 +267,8 @@ Ext4OpenDirent ( } else { File->Dentry =3D Ext4CreateDentry (FileName, Directory->Dentry); =20 - if (!File->Dentry) { + if (File->Dentry =3D=3D NULL) { + Status =3D EFI_OUT_OF_RESOURCES; goto Error; } } --=20 2.39.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99455): https://edk2.groups.io/g/devel/message/99455 Mute This Topic: https://groups.io/mt/96697374/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-