From nobody Sun May 19 18:10:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99377+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1675218629544586.8653633134655; Tue, 31 Jan 2023 18:30:29 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id ukwvYY1788612xO2RpS0P1MM; Tue, 31 Jan 2023 18:30:29 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.81]) by mx.groups.io with SMTP id smtpd.web11.14238.1675218628546818727 for ; Tue, 31 Jan 2023 18:30:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OD9eArBOQvNLY35WKAQEm7JIXzvGCK/+8e1gCQqJ89XKFG9CQbVA/UVcbAeepZaOgIjFwTX5Xm8qssrm2wOHsFp6dpvLQavTfySL8Ho7QbmW0rPNaI90vhwQXBv2Gx2vHA9NRtyiVCQ74abDjDY9MOZaxOnR397+c9VGNrqZlADbRByTnP5VO4LkGaZvxKv5ylNTb30PAqnXGWKlmBBSymzx/v0l0xEJwyHTHlegVZdyvS9wZfJDW4g88f6RpdCUNk4lTksb9zTv61E2bDQ+04gGNsNgxCVSlkx3MZ3LgnlX2WRY148qwVh2X0V4OEPSkxPS7ZM2o7yBYQNttsDnfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sZB9YCdyr4gd3DjLpyKTOvWCVoHu/c6vKVVTe8xQzos=; b=IOVWgTIxroPxZPStwXbkZ1t2QkRquKov6/8g42J6p6+AigdMIr+TEyZlJ3GR+pqkAZTZsQoEtEzRbRaK54Iih6QkdZwO80KRFT4YpNYYkwTB/7KvFqcVq7JGrX2DZJh6+VBgFgWzaquvua2OKPK3+OfmLhS37iwpkw366f4852mNwUJeF3Nw0KmPr/tlqkTldn6DESt/Ohsono3jXYdcxfXjrf5oY5t5m9OJvlFaHhryGkCc9+K+XvTPuJ0ed/ZJoNusX40Xa6M1FwbkK9pEPkz56q2YKjlgC45QtgtMq8mWAUR/7UIbHuZGNexD+NTwX8GZgjRct8RtbP5grYnHUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from MW4P220CA0014.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::19) by CH3PR12MB8076.namprd12.prod.outlook.com (2603:10b6:610:127::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Wed, 1 Feb 2023 02:30:26 +0000 X-Received: from CO1NAM11FT080.eop-nam11.prod.protection.outlook.com (2603:10b6:303:115:cafe::cb) by MW4P220CA0014.outlook.office365.com (2603:10b6:303:115::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38 via Frontend Transport; Wed, 1 Feb 2023 02:30:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+99377+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT080.mail.protection.outlook.com (10.13.174.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21 via Frontend Transport; Wed, 1 Feb 2023 02:30:26 +0000 X-Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 31 Jan 2023 18:30:14 -0800 X-Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 31 Jan 2023 18:30:14 -0800 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.986.36 via Frontend Transport; Tue, 31 Jan 2023 18:30:13 -0800 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [edk2-devel] [PATCH] RedfishPkg: fix multiple SMBIOS type 42 version issue Date: Wed, 1 Feb 2023 10:30:12 +0800 Message-ID: <20230201023012.122-1-nicklew@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT080:EE_|CH3PR12MB8076:EE_ X-MS-Office365-Filtering-Correlation-Id: 71260189-379e-4f2c-899b-08db03fc4735 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: jPTVfxEdDpK9uBS2vlyHPCxmU1JaHzuWrRSjBdSX0dedo40BCoMz67+z84yTTBD/UdpvZOnROuOqzomsa06INMGXonS9E/C1wvoIn1b5ci+eofpzoqfNUUshOjKzn3ZikVocMqQYu9M2h4/NwhgitIX/E5LZmeH50X1vokoEieS0B2eYHuvjTofLLsGZL0YMVo27CX7V0K8RxIi49ogG4GKU4okK8qbde9/vT3ADmeSIRCVv+nYqaZ2pvZFefW5UjBoTSOh7wABnXFRzd6zimSteQpKohzjBfXtq+9nsLdDgMtufxdFwIHRTu9tujl645UMGccWr6jGsfWHD26m2iI4gWmbKxd7+oZhxuLOldkODyHtMxu4Mgi9aIyco8PJEC9aJUeR7ae7IucT+Jr+2/GZ2+7BLHRF0eR7/2HqguJ2tyc1WXv3hw9TpsvQr6rnr4MFd62u8L8okUypGM2jwLpCBrRvgnvKgeAwXCTQeUDfdC322TTquAaSf3JgLCYI5Az6TT1qQr8+jPP16XAJg/+o7RE9w4V6vkWTD0EuzXzaYzg3mAgeMl0UhyA2B1QbECA2H4Ul3fLS02Q7Len1m06mbyt2HFsS8pArMOudnwdBdO/Pgzvf8wvXmFXnh0rFxsAGPJOaEgPuDUCP/86pjCB/Lnel8Gi1aJXPawuN58lhxXQ21uw2/V3xUgTpuByi8jVZc3w7iInvgvhYHgKv3iA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 02:30:26.3452 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71260189-379e-4f2c-899b-08db03fc4735 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT080.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8076 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com X-Gm-Message-State: uXgZ9plhPYZcyqVWCyxkquBCx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1675218629; bh=S9QGhdLwrxmem1/Fvn7OpWK2rfRYQ6w2oZ491xR9SEg=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=o6wPhCcxCseDAYRUcmSjiQiyDyu8yvBUWLDKuK0y7WY/41UNO5npJybRo0xgfl9nDVR KtOqYHqpCOPbe3p3cQbDHcDotBysiR/ANTwjC1E3bJgYaiAgkWPFaAkRaGStegTjNG9h7 i4jZwdr0EsXvdrj7PplydhzVng42Zk9GMqo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1675218629924100002 Content-Type: text/plain; charset="utf-8" RedfishHostInterfaceDxe does not close protocol notify event in event callback function. This could cause multiple version of type 42 records issue if the protocol is installed more than once. Close the event in callback function so we only create one type 42 record. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- .../RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c b= /RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c index 3e12e0c8b9..872cf3ae06 100644 --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c @@ -7,6 +7,7 @@ Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
+ Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -260,6 +261,13 @@ PlatformHostInterfaceInformationReady ( DEBUG ((DEBUG_INFO, "%a: Platform Redfish Host Interface informtion is r= eady\n", __FUNCTION__)); =20 RedfishCreateSmbiosTable42 (); + + // + // Close event so we don't create multiple type 42 records + // + gBS->CloseEvent (Event); + mPlatformHostInterfaceReadylEvent =3D NULL; + return; } =20 --=20 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99377): https://edk2.groups.io/g/devel/message/99377 Mute This Topic: https://groups.io/mt/96668185/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-