From nobody Sat Feb 7 07:10:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+99145+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99145+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1674811798; cv=none; d=zohomail.com; s=zohoarc; b=cEHpU5/dTDul6zu/gH3ea4VxIYXDOWuGmX70LKSg8zvhvMKI6TPRT1TYeZCJk+3wTqcx5tLb9jN1ATr7py4XLdP5nqHGQgYbb/CYtD6jKUKYdDbwfyzjtwVoqqx38a0p5QJ19zwecwKVgSIcJEgwvPTRPYcqmPb31Yx6OeJ0R2s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674811798; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=+WkLI8UD2bm1xsoBsue/5KExmhEvGej3z2l0sWxXD9Y=; b=VtfbmlJMcxKaYtRzI6C905Zx8O20Xt7lC03Fz+928mnuQo8+4DQa8EgHgx5LTU2l2OlkNsOZB6wYdqYGOBi+UfpZ8v90LVwka+2MQt7jbenlXYGmylZ+Fxoi1SEjT4BwJiNrg65JlKRBb5SzKddGqVAL6e9AzLksvOzKziSmBNk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99145+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1674811798589603.8625302288704; Fri, 27 Jan 2023 01:29:58 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id uYgNYY1788612x1nhNCIcD24; Fri, 27 Jan 2023 01:29:58 -0800 X-Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by mx.groups.io with SMTP id smtpd.web10.98483.1674811796503971478 for ; Fri, 27 Jan 2023 01:29:56 -0800 X-Received: by mail-lf1-f43.google.com with SMTP id br9so7244170lfb.4 for ; Fri, 27 Jan 2023 01:29:56 -0800 (PST) X-Gm-Message-State: ErYuBxmzlUODu0P0XybcTbTdx1787277AA= X-Google-Smtp-Source: AMrXdXuBlZN+3uRDNHi0ye/5ic9zI85kn/yeSBSFdJ6bd2jPiFfV79lBCq5gTjdK9+qFJ8mqukVxuQ== X-Received: by 2002:ac2:44d5:0:b0:4cc:8572:c7bc with SMTP id d21-20020ac244d5000000b004cc8572c7bcmr9270934lfm.65.1674811794634; Fri, 27 Jan 2023 01:29:54 -0800 (PST) X-Received: from localhost.localdomain ([176.62.67.29]) by smtp.gmail.com with ESMTPSA id t11-20020a056512068b00b004cc8196a308sm229071lfe.98.2023.01.27.01.29.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 27 Jan 2023 01:29:54 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-devel] [edk2-platforms][PATCH v3 08/11] Ext4Pkg: Check VolumeName allocation correctness in Ext4GetVolumeName Date: Fri, 27 Jan 2023 15:29:42 +0600 Message-Id: <20230127092945.94389-9-savvamtr@gmail.com> In-Reply-To: <20230127092945.94389-1-savvamtr@gmail.com> References: <20230127092945.94389-1-savvamtr@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,savvamtr@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1674811798; bh=bcn0WcmIXfCRdstDeNctk4koseAx0vlsKzLO49/hJ2Q=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=qyklgXrcOZGK0++3pso3b4vxqAsJ4ynxJtmeOKSRhtN3V5FOwH1j+dabacA5IXCi+SJ 7iATkL6PdGXf7Mc8WG9wk8j3JP2I4JQMxGd/pr7qUba79DrprfyPMIW3S1sEXwm80mhsW 2P8vv+j/vCFqoUVZkIoK0WrqyHOMUlT+o68= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1674811800646100039 Content-Type: text/plain; charset="utf-8" Missing check in some cases leads to failed StrCpyS call in Ext4GetVolumeLabelInfo. Also correct condition that checks Inode pointer for being NULL in Ext4AllocateInode Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: cfbbae595eec ("Ext4Pkg: Add handling of EFI_FILE_SYSTEM_VOLUME_LABEL= GetInfo().") Signed-off-by: Savva Mitrofanov Reviewed-by: Marvin H=C3=A4user Reviewed-by: Pedro Falcato --- Features/Ext4Pkg/Ext4Dxe/File.c | 10 ++++++++-- Features/Ext4Pkg/Ext4Dxe/Inode.c | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/File.c b/Features/Ext4Pkg/Ext4Dxe/Fil= e.c index 9dde4a5d1a2d..677caf88fbdc 100644 --- a/Features/Ext4Pkg/Ext4Dxe/File.c +++ b/Features/Ext4Pkg/Ext4Dxe/File.c @@ -719,7 +719,11 @@ Ext4GetVolumeName ( =20 VolNameLength =3D StrLen (VolumeName); } else { - VolumeName =3D AllocateZeroPool (sizeof (CHAR16)); + VolumeName =3D AllocateZeroPool (sizeof (CHAR16)); + if (VolumeName =3D=3D NULL) { + return EFI_OUT_OF_RESOURCES; + } + VolNameLength =3D 0; } =20 @@ -786,7 +790,9 @@ Ext4GetFilesystemInfo ( Info->VolumeSize =3D MultU64x32 (TotalBlocks, Part->BlockSize); Info->FreeSpace =3D MultU64x32 (FreeBlocks, Part->BlockSize); =20 - StrCpyS (Info->VolumeLabel, VolNameLength + 1, VolumeName); + Status =3D StrCpyS (Info->VolumeLabel, VolNameLength + 1, VolumeName); + + ASSERT_EFI_ERROR (Status); =20 FreePool (VolumeName); =20 diff --git a/Features/Ext4Pkg/Ext4Dxe/Inode.c b/Features/Ext4Pkg/Ext4Dxe/In= ode.c index e44b5638599f..90e3eb88f523 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Inode.c +++ b/Features/Ext4Pkg/Ext4Dxe/Inode.c @@ -230,7 +230,7 @@ Ext4AllocateInode ( =20 Inode =3D AllocateZeroPool (InodeSize); =20 - if (!Inode) { + if (Inode =3D=3D NULL) { return NULL; } =20 --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99145): https://edk2.groups.io/g/devel/message/99145 Mute This Topic: https://groups.io/mt/96562698/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-