From nobody Sat Feb 7 07:10:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+99138+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99138+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1674811792; cv=none; d=zohomail.com; s=zohoarc; b=SVBQsFTya/TBS2xtHk/saeqfe1v5SCyJbtPipP/KZSgv4k/GaqgdBmL3Iayhhk0+kCvMkTVEhnjZ/utSpDkWv7Wdvk8WXayG89BgNbMPn54+zSpbBCaHOpfxgJp1rleZMN/wZL76c5pULPaCz4H6CJi4J3ydEsep1EKwiu6J0eI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674811792; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=UNA+znyxRLrHEMAQYttwQiWcIV4Q/TBEP7vSsV45c9s=; b=m+F9O0QNfgwWANK97Ee343FSvX3SNJJNlqhdgzCQSuxx1G4yNpAJXlUkA9EEHftbF9/+ykZb6T/xJkwoBrJ2IvFOaxGeLhrZmZ/5sq7RR94SAE12qoW83uBRHKT2olAfJVpbrZpXa5zmj4L+0eoCnhrw6asMoz7+6Nn4NPpQEK0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99138+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1674811792250243.61645559347187; Fri, 27 Jan 2023 01:29:52 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id dcDTYY1788612x5SexmqWRN0; Fri, 27 Jan 2023 01:29:51 -0800 X-Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by mx.groups.io with SMTP id smtpd.web10.98478.1674811791016216494 for ; Fri, 27 Jan 2023 01:29:51 -0800 X-Received: by mail-lf1-f43.google.com with SMTP id d30so7204309lfv.8 for ; Fri, 27 Jan 2023 01:29:50 -0800 (PST) X-Gm-Message-State: BuXHNQryiBxSsPaZmW2SZJ9xx1787277AA= X-Google-Smtp-Source: AMrXdXvoxL1NGvGk/FUVL+BEoKEX+bp0mfFDF6sDIXtspZ47QGiqYgCt2waa/QphK9s+F9u6ED05ng== X-Received: by 2002:a05:6512:3048:b0:4b9:a91c:b0c9 with SMTP id b8-20020a056512304800b004b9a91cb0c9mr13230709lfb.7.1674811789233; Fri, 27 Jan 2023 01:29:49 -0800 (PST) X-Received: from localhost.localdomain ([176.62.67.29]) by smtp.gmail.com with ESMTPSA id t11-20020a056512068b00b004cc8196a308sm229071lfe.98.2023.01.27.01.29.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 27 Jan 2023 01:29:48 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-devel] [edk2-platforms][PATCH v3 02/11] Ext4Pkg: Fix incorrect checksum metadata feature check Date: Fri, 27 Jan 2023 15:29:36 +0600 Message-Id: <20230127092945.94389-3-savvamtr@gmail.com> In-Reply-To: <20230127092945.94389-1-savvamtr@gmail.com> References: <20230127092945.94389-1-savvamtr@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,savvamtr@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1674811791; bh=+uJJ9KDwP3wJI7dV4C13DBSkdje9wSyMjbm0zAx5uS4=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=O/qloDKJUOxzCNsZ+o0jP8/e3yZnT4d8fpQvFoeI4ROWf/k2pIDDB/wsy9m80nMgBDM bX0xVhPKhAiMW3Q0vfwOuOsB/ih0Iy1oAzoZRtkr3djmgzXkMOqHkBofI7ZfGX5tvd5fH Uyx25MH0GDarNObj5WyzJXYm4p0mHg9uBbE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1674811792596100005 Content-Type: text/plain; charset="utf-8" Missing comparison !=3D 0 leads to broken logic condition. Also replaced CSUM_SEED feature_incompat check with predefined macro EXT4_HAS_INCOMPAT Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.") Signed-off-by: Savva Mitrofanov Reviewed-by: Marvin H=C3=A4user Reviewed-by: Pedro Falcato --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext4D= xe/Superblock.c index 5a3c7f478187..35dcf3c007c8 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c @@ -220,13 +220,11 @@ Ext4OpenSuperblock ( } =20 // At the time of writing, it's the only supported checksum. - if (Partition->FeaturesCompat & EXT4_FEATURE_RO_COMPAT_METADATA_CSUM && - (Sb->s_checksum_type !=3D EXT4_CHECKSUM_CRC32C)) - { + if (EXT4_HAS_METADATA_CSUM (Partition) && (Sb->s_checksum_type !=3D EXT4= _CHECKSUM_CRC32C)) { return EFI_UNSUPPORTED; } =20 - if ((Partition->FeaturesIncompat & EXT4_FEATURE_INCOMPAT_CSUM_SEED) !=3D= 0) { + if (EXT4_HAS_INCOMPAT (Partition, EXT4_FEATURE_INCOMPAT_CSUM_SEED)) { Partition->InitialSeed =3D Sb->s_checksum_seed; } else { Partition->InitialSeed =3D Ext4CalculateChecksum (Partition, Sb->s_uui= d, 16, ~0U); --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99138): https://edk2.groups.io/g/devel/message/99138 Mute This Topic: https://groups.io/mt/96562691/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-