From nobody Mon Feb 9 13:22:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+98789+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+98789+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1674035788; cv=none; d=zohomail.com; s=zohoarc; b=RLU7eR5kPKPIhShuP+anBLFWUUwRS7iWUSj3ctYJtABSp2cpFTRL8Ltp/FA8iz2H2PRWm2fyN0NpYHRhGX1tK2tSWLc1fDT55seoHmlADrH8dNA5S8c9ylqKeE6NpT8EU4hravlvfOH/aCmiLVhfs62eAdP/15rTjBdQOIRxqxg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674035788; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=ZVxeZTpdnBVt8a2P8OTaet6CilJdYbeZV5yCjZclaxA=; b=A5ITia0gkELvt0UhO5UGlDPvif5APyG3740YxNRHnMaGeDJ89HhztKAhENHlF/B5B9HjZpfXzlQzei8njy3zgrE8uaSIjBeabnNBAWanCwD9xDRWxNcBl6uMtiwv43cj5woE03tQZFhCiLjLKVyy9C+uAmSztQD62eQ4tndNNWY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+98789+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1674035788532923.6793346601993; Wed, 18 Jan 2023 01:56:28 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZNK5YY1788612xqhnOBbHP2y; Wed, 18 Jan 2023 01:56:28 -0800 X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.11831.1674035783379019296 for ; Wed, 18 Jan 2023 01:56:27 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="411184065" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="411184065" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 01:56:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="723026331" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="723026331" X-Received: from sh1gapp1009.ccr.corp.intel.com ([10.239.189.79]) by fmsmga008.fm.intel.com with ESMTP; 18 Jan 2023 01:56:25 -0800 From: "Wu, Jiaxin" To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Zeng Star , Laszlo Ersek , Gerd Hoffmann , Rahul Kumar Subject: [edk2-devel] [PATCH v3 2/5] UefiCpuPkg/PiSmmCpuDxeSmm: Fix invalid InitializeMpSyncData call Date: Wed, 18 Jan 2023 17:56:17 +0800 Message-Id: <20230118095620.9860-3-jiaxin.wu@intel.com> In-Reply-To: <20230118095620.9860-1-jiaxin.wu@intel.com> References: <20230118095620.9860-1-jiaxin.wu@intel.com> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com X-Gm-Message-State: Jy0rEseuNfoF4MLjdP9AVouHx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1674035788; bh=Gy20SNDEjGAt18CyysTMOHzX9nSEmDThYbIDzq446sY=; h=Cc:Date:From:Reply-To:Subject:To; b=jJQnfoQnjCm8HtWoZawazef4NiDJq3gz7CRHtl21iHwrm+MAtAnDKpr1/esd+bA2IFt TW3gnd9SQgagq3LJGvw+KlPx4ZBhG/XLpJwrgIo3hiT0z471ueIHLtDU9qNnj8T2izwU8 ptJUCI6AHJXrKGfQNbyPZgngxgs3Bi6y9X8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1674035789278100009 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" No need call InitializeMpSyncData during normal boot SMI init, because mSmmMpSyncData is NULL at that time. mSmmMpSyncData is allocated in InitializeMpServiceData, which is invoked after normal boot SMI init (SmmRelocateBases). Cc: Eric Dong Cc: Ray Ni Cc: Zeng Star Cc: Laszlo Ersek Cc: Gerd Hoffmann Cc: Rahul Kumar Signed-off-by: Jiaxin Wu --- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c b/UefiCpuPkg/PiSmmC= puDxeSmm/PiSmmCpuDxeSmm.c index 655175a2c6..f723b1d253 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c @@ -369,13 +369,11 @@ SmmInitHandler ( if (!mSmmS3Flag) { // // Check XD and BTS features on each processor on normal boot // CheckFeatureSupported (); - } - - if (mIsBsp) { + } else if (mIsBsp) { // // BSP rebase is already done above. // Initialize private data during S3 resume // InitializeMpSyncData (); --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98789): https://edk2.groups.io/g/devel/message/98789 Mute This Topic: https://groups.io/mt/96350761/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-