From nobody Mon Feb 9 19:52:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+98261+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+98261+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1673400254; cv=none; d=zohomail.com; s=zohoarc; b=lija2/23UPGXv3xrOlGopIluz/2qC8ny2JNBiQF0koQ1h/8eZ4R+g1VsasRw8sqPWlGTWtON5ZLAiJvreSY0vQC56ey205IeWf9fYtiIS244vxg6PhD/zPEZ2AZ07I+zqBtJ9sxC1w3BCeE26MC2PVZF5ZnYExRqJ/GUvfGvKB0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673400254; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=jpdtMgvCgLkUmPxC7fIM2EfKbJQDNxh9fYLt5j/M9C4=; b=bNupMKfko2FRgfa/6BtQe80Kz0+OytcYzOZdyJqhOdcYGENZrkmmoBf9KwTRheIUvj4BeJhHCQhfayrd3yeQFwhKDooR60HYattNTMBWj3G+1b/tjiSGrqVsR9dwV+XPzQuH2RdoSBnHal23hdDVkfuXvoEEGzd95ctaM3yFqXM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+98261+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1673400254572201.91191843438844; Tue, 10 Jan 2023 17:24:14 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id L69WYY1788612x4NZRW1X3KM; Tue, 10 Jan 2023 17:24:14 -0800 X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.12270.1673400253669081955 for ; Tue, 10 Jan 2023 17:24:13 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="387764414" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="387764414" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 17:24:12 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="659192805" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="659192805" X-Received: from mxu9-mobl1.ccr.corp.intel.com ([10.213.42.137]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 17:24:03 -0800 From: "Min Xu" To: devel@edk2.groups.io Cc: Min M Xu , Laszlo Ersek , Erdem Aktas , James Bottomley , Jiewen Yao , Gerd Hoffmann , Tom Lendacky Subject: [edk2-devel] [PATCH V3 3/6] OvmfPkg/AcpiPlatformDxe: Use local variable in QemuFwCfgAcpi.c Date: Wed, 11 Jan 2023 09:22:32 +0800 Message-Id: <20230111012235.189-4-min.m.xu@intel.com> In-Reply-To: <20230111012235.189-1-min.m.xu@intel.com> References: <20230111012235.189-1-min.m.xu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,min.m.xu@intel.com X-Gm-Message-State: bsjpAMGrYfn8WGXh89N0xsI0x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1673400254; bh=TSQJDZ4uVQM6eWiUA885MMzsz3enxoQuJLusM0+RZSY=; h=Cc:Date:From:Reply-To:Subject:To; b=jTdubijLItYJ0M2wEDQNNGiTuFxTWCsXvTdqIeEGORZamJUl/FQdC7BsyD/45zaxzjh JbTq0O3GaeZBrHgq0L4h6XHthPyK+EVM4xhULwPtjvhyWrO1O0Aew7B0PnGl0IuSPGo5n PS/+M0VEztQMgQ5fzZl+m0W69urv/CV+1xE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1673400255388100001 Content-Type: text/plain; charset="utf-8" From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4237 The handle of mQemuAcpiHandle is not needed for anything, beyond the scope of the InstallQemuFwCfgTables(). So a local variable will suffice for storing the handle. Cc: Laszlo Ersek Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Tom Lendacky Reported-by: Laszlo Ersek Reviewed-by: Laszlo Ersek Signed-off-by: Min Xu --- OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c b/OvmfPkg/AcpiPlatform= Dxe/QemuFwCfgAcpi.c index 1a3852904df9..9711335c6cac 100644 --- a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c +++ b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c @@ -20,7 +20,6 @@ #include // gBS =20 #include "AcpiPlatform.h" -EFI_HANDLE mQemuAcpiHandle =3D NULL; =20 // // The user structure for the ordered collection that will track the fw_cfg @@ -1101,6 +1100,7 @@ InstallQemuFwCfgTables ( ORDERED_COLLECTION_ENTRY *TrackerEntry, *TrackerEntry2; ORDERED_COLLECTION *SeenPointers; ORDERED_COLLECTION_ENTRY *SeenPointerEntry, *SeenPointerEntry2; + EFI_HANDLE QemuAcpiHandle; =20 Status =3D QemuFwCfgFindFile ("etc/table-loader", &FwCfgItem, &FwCfgSize= ); if (EFI_ERROR (Status)) { @@ -1278,8 +1278,9 @@ UninstallAcpiTables: // Install a protocol to notify that the ACPI table provided by Qemu is // ready. // + QemuAcpiHandle =3D NULL; gBS->InstallProtocolInterface ( - &mQemuAcpiHandle, + &QemuAcpiHandle, &gQemuAcpiTableNotifyProtocolGuid, EFI_NATIVE_INTERFACE, NULL --=20 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98261): https://edk2.groups.io/g/devel/message/98261 Mute This Topic: https://groups.io/mt/96191595/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-