From nobody Mon Feb 9 16:02:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+98184+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+98184+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1673272805; cv=none; d=zohomail.com; s=zohoarc; b=N1LE2jM8Wg9acIcsEZx+rVKX1DoY09mFmH+CJViHMkEjoHBz3jlttptjfehdjX5FXWt9NcxhJLqpkqmuRi5vJbAOnis4bDZdyx5nOJroMJiCxBuyVu7TqSa8ICt5xTdZuSka8NgWVZfCjfkRCyqCPqF/3XE4c2g9/xQNcumgsUI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673272805; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=YKnVolUXkFVHXc/FK0LbwnU+753Z/QMeJl7Bpk4P0sY=; b=NcJHXNj4F8PLmAvA+e63A4tX3MGLmIDJwuTo7EjtHBLkUZN4il32qOY8dvzw8Lg+bBLeNudIDi9BT43hc2iM33Bbtespy75569WOFsss4ICljUMgUBMY+TCO701EHaqL4+Ol8S1IqIKvEss63KbEYQs46QqzJWepLu2/nLyygtM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+98184+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1673272805617357.3842996280471; Mon, 9 Jan 2023 06:00:05 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id OCFrYY1788612xMCog2agW5Z; Mon, 09 Jan 2023 06:00:05 -0800 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.72183.1673272804664614480 for ; Mon, 09 Jan 2023 06:00:04 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="306394414" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="306394414" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2023 05:59:37 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="634217677" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="634217677" X-Received: from mxu9-mobl1.ccr.corp.intel.com ([10.255.30.4]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2023 05:59:34 -0800 From: "Min Xu" To: devel@edk2.groups.io Cc: Min M Xu , Laszlo Ersek , Erdem Aktas , James Bottomley , Jiewen Yao , Gerd Hoffmann , Tom Lendacky , Sebastien Boeuf Subject: [edk2-devel] [PATCH V2 2/6] OvmfPkg/AcpiPlatformDxe: Use local variable in CloudHvAcpi.c Date: Mon, 9 Jan 2023 21:59:13 +0800 Message-Id: <20230109135917.1752-3-min.m.xu@intel.com> In-Reply-To: <20230109135917.1752-1-min.m.xu@intel.com> References: <20230109135917.1752-1-min.m.xu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,min.m.xu@intel.com X-Gm-Message-State: YZ2qrlqTqmg4PUdytxPn2bVjx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1673272805; bh=cUaR2LDc78ac4Usqq4t0fkevqvrWLN+9kU/I18fThng=; h=Cc:Date:From:Reply-To:Subject:To; b=seppnfy0Nm2oNR0GG6gAYahUGF4izRnNkL/HdSKuh4RqfaAoJjOHKH1QAGNTClnaop6 RwRd03N4VTT8ImroJW5zlZb1AQiSu3sOkw4umoBBvXk/Qtfve2q2mnJto61W+EcjZkV+F 7tM4dRwM7nHCAOYNdOP+YG8bhP0ewTPr8l4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1673272807285100001 Content-Type: text/plain; charset="utf-8" From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4237 The handle of mChAcpiHandle is not needed for anything, beyond the scope of the InstallCloudHvTablesTdx (). A local variable (ChAcpiHandle) suffices for storing the handle. Cc: Laszlo Ersek Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Tom Lendacky Cc: Sebastien Boeuf Reported-by: Laszlo Ersek Signed-off-by: Min Xu --- OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c b/OvmfPkg/AcpiPlatformDx= e/CloudHvAcpi.c index ad39e4253478..d849a59526b5 100644 --- a/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c +++ b/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c @@ -20,8 +20,6 @@ =20 #include "AcpiPlatform.h" =20 -EFI_HANDLE mChAcpiHandle =3D NULL; - EFI_STATUS EFIAPI InstallCloudHvTablesTdx ( @@ -30,13 +28,15 @@ InstallCloudHvTablesTdx ( { EFI_STATUS Status; UINTN TableHandle; + EFI_HANDLE ChAcpiHandle; =20 EFI_PEI_HOB_POINTERS Hob; EFI_ACPI_DESCRIPTION_HEADER *CurrentTable; EFI_ACPI_DESCRIPTION_HEADER *DsdtTable; =20 - DsdtTable =3D NULL; - TableHandle =3D 0; + DsdtTable =3D NULL; + TableHandle =3D 0; + ChAcpiHandle =3D NULL; =20 Hob.Guid =3D (EFI_HOB_GUID_TYPE *)GetFirstGuidHob (&gUefiOvmfPkgTdxAcpiH= obGuid); =20 @@ -90,7 +90,7 @@ InstallCloudHvTablesTdx ( // ready. // gBS->InstallProtocolInterface ( - &mChAcpiHandle, + &ChAcpiHandle, &gQemuAcpiTableNotifyProtocolGuid, EFI_NATIVE_INTERFACE, NULL --=20 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98184): https://edk2.groups.io/g/devel/message/98184 Mute This Topic: https://groups.io/mt/96152529/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-