From nobody Mon Feb 9 07:55:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+98124+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+98124+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1673013851; cv=none; d=zohomail.com; s=zohoarc; b=C0Ow97DOtVRTjYHOSWvtC0eDxT0UeqWNkUvFkHigcXMBlbIZfVXv6IkMuOA1+QLdQIZsZkAnDnHRzP6vOh0fM2j+XK16VBP8zmfru643AHc5CKEIvICxEf5z9eiLA+eVES1xDNd8GzxoP2Dr2pDciBB/2qjCFmffgFEcQHoG6dQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673013851; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=gn+1TTILdCzjFBkztGxuxsrvfPVJvMX2ZtKZ67a03BI=; b=HaLR2SVCepXfBcsdQJiT8BpeY6M18lbTSzIcKThl8h3e9gdcN1kTlp3ReDtT+dWKG9uHaSpnjcSgxdHJSvhJlBVJpzc1tULYw1SeBQR8PB/dGbFP43MaN+piRoWq53F5V/Nlm4OkSXte+DoHQpLuZ5e/XCZvnqqmywPqIeMG29M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+98124+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1673013851557896.4548612282725; Fri, 6 Jan 2023 06:04:11 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id J7zBYY1788612xwdx5sXlSow; Fri, 06 Jan 2023 06:04:11 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.13902.1673013850327382170 for ; Fri, 06 Jan 2023 06:04:10 -0800 X-Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-55-tp9cu63eMg2aANr0ptT0yg-1; Fri, 06 Jan 2023 09:04:05 -0500 X-MC-Unique: tp9cu63eMg2aANr0ptT0yg-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E16971C00422; Fri, 6 Jan 2023 14:04:04 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.238]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D59839D6D; Fri, 6 Jan 2023 14:04:04 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 2EBFD18009A7; Fri, 6 Jan 2023 15:04:03 +0100 (CET) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Ard Biesheuvel , =?UTF-8?q?L=C3=A1szl=C3=B3=20=C3=89rsek?= , Jordan Justen , Pawel Polawski , Oliver Steffen , Jiewen Yao , Gerd Hoffmann Subject: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram documentation Date: Fri, 6 Jan 2023 15:04:02 +0100 Message-Id: <20230106140403.2889131-2-kraxel@redhat.com> In-Reply-To: <20230106140403.2889131-1-kraxel@redhat.com> References: <20230106140403.2889131-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com X-Gm-Message-State: 9WCoEzC14d0UhRb7Dr7WvYe2x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1673013851; bh=G0OTQ7xWqu1b8tGWqKO7nD0U2vI+rBMQYNqMMgiEL/I=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=ut89tSqD7fCoRMl9FGjEBtU/ujB6W12wZfELDBTMn5ZCpRj/VYJdj/eLDsHwjDXjg79 c+jMYlQObhdYvb5EKLHLsC3vK3Jm3X9ksBXPlBWR33XnNfr6GpyZubi3o3CCrkrQOFMXd mpY4SkW7XWgRR12s/wwE1Pyn37jjbgEB9+4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1673013852845100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Documentation of PlatformScanOrAdd64BitE820Ram() ran out of sync with the implementation. Fix that. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Library/PlatformInitLib/MemDetect.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/OvmfPkg/Library/PlatformInitLib/MemDetect.c b/OvmfPkg/Library/= PlatformInitLib/MemDetect.c index 0c4956852689..1255d6300fdd 100644 --- a/OvmfPkg/Library/PlatformInitLib/MemDetect.c +++ b/OvmfPkg/Library/PlatformInitLib/MemDetect.c @@ -121,15 +121,19 @@ PlatformQemuUc32BaseInitialization ( Find the highest exclusive >=3D4GB RAM address, or produce memory resour= ce descriptor HOBs for RAM entries that start at or above 4GB. =20 - @param[out] MaxAddress If MaxAddress is NULL, then PlatformScanOrAdd64B= itE820Ram() + @param[in] AddHighHob If True then PlatformScanOrAdd64BitE820Ram() produces memory resource descriptor HOBs for RAM entries that start at or above 4GB. + It also produces HOBs for reserved entries. =20 - Otherwise, MaxAddress holds the highest exclusive - >=3D4GB RAM address on output. If QEMU's fw_cfg = E820 - RAM map contains no RAM entry that starts outsid= e of - the 32-bit address range, then MaxAddress is exa= ctly - 4GB on output. + @param[out] LowMemory If Lowmemory is not NULL, then Lowmemory MaxAddre= ss + holds the amout of emory below 4G on output. + + @param[out] MaxAddress If MaxAddress is not NULL, then MaxAddress holds + the highest exclusive >=3D4GB RAM address on out= put. + If QEMU's fw_cfg E820 RAM map contains no RAM en= try + that starts outside of the 32-bit address range, + then MaxAddress is exactly 4GB on output. =20 @retval EFI_SUCCESS The fw_cfg E820 RAM map was found and proces= sed. =20 --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98124): https://edk2.groups.io/g/devel/message/98124 Mute This Topic: https://groups.io/mt/96093485/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-