From nobody Sat Feb 7 09:03:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+97619+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97619+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1671525779; cv=none; d=zohomail.com; s=zohoarc; b=GmUtCLPdm46aPgU9+9dWmZqmGXm/mxCgoQqr2k+M06/lfvnUh5qZArl+A6tqbZnwMnDy/to1lR2+jP21CCwBi1lKTvfCfmp+F/4YG2NQ7MqTqBPA7ZnmJOU9GVizZvV6dDYhEUm/50098qxqZ7cfr1rQNROuXvZhkG5gb80BW2g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671525779; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=KwVRYGS8vMcl0M/5BXjzEk7TjMvL1YR/Q8wQbQoIo2A=; b=V774s+bYKWIupKO8o9ojp13X6hE/KOWOGU5MNHbD4PxNxs6wInO1Y7ncbcucLcOr7wL4Sb3Ra5fbl5kBIccfBcQMYWqijUAO0d+uszVnACTFUIQl5CLh49esHpw4ftPwIjIdOwPYZsnZda1WZtADSC6LEdIO+DJuEXAizlGLUSI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97619+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1671525779603960.0392953109856; Tue, 20 Dec 2022 00:42:59 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id VTQmYY1788612xTph422IKJG; Tue, 20 Dec 2022 00:42:59 -0800 X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.46058.1671525777169185136 for ; Tue, 20 Dec 2022 00:42:58 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="383908214" X-IronPort-AV: E=Sophos;i="5.96,258,1665471600"; d="scan'208";a="383908214" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2022 00:42:58 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="628644646" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="628644646" X-Received: from mxu9-mobl1.ccr.corp.intel.com ([10.255.29.12]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2022 00:42:56 -0800 From: "Min Xu" To: devel@edk2.groups.io Cc: Min M Xu , Erdem Aktas , Gerd Hoffmann , James Bottomley , Jiewen Yao , Tom Lendacky Subject: [edk2-devel] [PATCH V2 1/6] OvmfPkg/TdxMailboxLib: Delete global variables Date: Tue, 20 Dec 2022 16:42:35 +0800 Message-Id: <20221220084240.1922-2-min.m.xu@intel.com> In-Reply-To: <20221220084240.1922-1-min.m.xu@intel.com> References: <20221220084240.1922-1-min.m.xu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,min.m.xu@intel.com X-Gm-Message-State: EJQvwx3bCxFLOcbn2mig6Obax1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1671525779; bh=x7bj3ujWk2FmkCS75GyoL7MmXTkwTQKaMfy7qJGCO2c=; h=Cc:Date:From:Reply-To:Subject:To; b=rU+8/5YemaNKy4Bs3lDjvE2XW696gzHoPjQpDGbCs8RJe/zuBxAzId3zqCF8WiX6ZsT Mge6++Z5RAkPqaYKUiuCpXcM2pNs9uyqkbhz+wLjLLu6G21ez6mKNwouyCzd0Ye7VX4Bq 1JqAd1GYzO5QvqW/i3Lq+mjrjD5mJhEU1Y0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1671525780767100002 Content-Type: text/plain; charset="utf-8" From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4172 TdxMailboxLib once was designed to be used in DXE phase. But now it is going to be used in SEC/PEI phase (in the following patches). Global variables are not allowed. The library is refactored after those global variables are deleted. Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Signed-off-by: Min Xu --- OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c b/OvmfPkg/Library/T= dxMailboxLib/TdxMailbox.c index 74cb55611fe3..c580a2885603 100644 --- a/OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c +++ b/OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c @@ -13,14 +13,10 @@ #include #include #include -#include #include #include #include =20 -volatile VOID *mMailBox =3D NULL; -UINT32 mNumOfCpus =3D 0; - /** This function will be called by BSP to get the CPU number. =20 @@ -32,11 +28,17 @@ GetCpusNum ( VOID ) { - if (mNumOfCpus =3D=3D 0) { - mNumOfCpus =3D TdVCpuNum (); + UINT64 Status; + TD_RETURN_DATA TdReturnData; + + Status =3D TdCall (TDCALL_TDINFO, 0, 0, 0, &TdReturnData); + if (Status =3D=3D TDX_EXIT_REASON_SUCCESS) { + return TdReturnData.TdInfo.NumVcpus; + } else { + DEBUG ((DEBUG_ERROR, "Failed call TDCALL_TDINFO. %llx\n", Status)); } =20 - return mNumOfCpus; + return 0; } =20 /** @@ -48,11 +50,7 @@ GetTdxMailBox ( VOID ) { - if (mMailBox =3D=3D NULL) { - mMailBox =3D (VOID *)(UINTN)PcdGet32 (PcdOvmfSecGhcbBackupBase); - } - - return mMailBox; + return (VOID *)(UINTN)PcdGet32 (PcdOvmfSecGhcbBackupBase); } =20 /** --=20 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97619): https://edk2.groups.io/g/devel/message/97619 Mute This Topic: https://groups.io/mt/95782427/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-