From nobody Mon Feb 9 03:13:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+97427+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97427+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1671093897; cv=none; d=zohomail.com; s=zohoarc; b=a+O724BKI8yl9OM1Kt4Wd2OMtaQpDPjrK8V5Qc49u2SHX2/m6n8oX5U2l5ioufC7RNevITgzGaYDzWGTwF5aCtYSZdXEZCxfLlcjXZ5X4+wc33zAHMTABopJC9S/qBzG6UPNmbboVcc7E8f6G8KDzD4Izu776l7+anFHSn1dESc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671093897; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=a6nS/M4fX8PEB2c/VbOoznuoXnJbeEYL/LL0prSl0To=; b=Ez5ES2KClngH10lMnTOF2XtwPU27PsdwXCXbQ8VFRSlPDU3tD8Fu4tBgbpo3P9VY6a1BB7GB38Ifdv93zb+aHhwIhSW6M/Hu90Vnu9COIour16wcs8bgCS1z0I9ShF06Hky9ySF3C2FJQN+uM5XI/35MdHTPvMawD4qs9dFdMrA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97427+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1671093897235379.02519310071625; Thu, 15 Dec 2022 00:44:57 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id uQdpYY1788612xiuMJtq7fxi; Thu, 15 Dec 2022 00:44:56 -0800 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.128317.1671093895214005705 for ; Thu, 15 Dec 2022 00:44:56 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="298967864" X-IronPort-AV: E=Sophos;i="5.96,246,1665471600"; d="scan'208";a="298967864" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2022 00:44:56 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="651464804" X-IronPort-AV: E=Sophos;i="5.96,246,1665471600"; d="scan'208";a="651464804" X-Received: from mxu9-mobl1.ccr.corp.intel.com ([10.249.170.19]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2022 00:44:54 -0800 From: "Min Xu" To: devel@edk2.groups.io Cc: Min M Xu , Erdem Aktas , Gerd Hoffmann , James Bottomley , Jiewen Yao , Tom Lendacky Subject: [edk2-devel] [PATCH V1 1/6] OvmfPkg/TdxMailboxLib: Delete global variables Date: Thu, 15 Dec 2022 16:44:35 +0800 Message-Id: <20221215084440.481-2-min.m.xu@intel.com> In-Reply-To: <20221215084440.481-1-min.m.xu@intel.com> References: <20221215084440.481-1-min.m.xu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,min.m.xu@intel.com X-Gm-Message-State: et1Hj6UgOueKxwsCp43DSzuZx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1671093896; bh=UddIfeUwbIBVTZ+emykHpZAaTMz/ceNX2saoueKQnQM=; h=Cc:Date:From:Reply-To:Subject:To; b=d+3YZK9uoaVpZACbxfU0fDJEoeDtAeluVVodNa2AVKeGFpNiIudBlNRJXA/heTVVmzT pZmpVvgSB92W33CtaTb3Puw0Ry/H8KAc7EHEXZD1Y9DXIodC74J4vDvyOVhLVWHHKBkG3 WxisBJ9oL5EeIYFjL2Dyz/oqq/jGXPU36kM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1671093898314100002 Content-Type: text/plain; charset="utf-8" From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4172 TdxMailboxLib once was designed to be used in DXE phase. But now it is going to be used in SEC/PEI phase (in the following patches). Global variables are not allowed. The library is refactored after those global variables are deleted. Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Signed-off-by: Min Xu --- OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c b/OvmfPkg/Library/T= dxMailboxLib/TdxMailbox.c index 74cb55611fe3..c580a2885603 100644 --- a/OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c +++ b/OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c @@ -13,14 +13,10 @@ #include #include #include -#include #include #include #include =20 -volatile VOID *mMailBox =3D NULL; -UINT32 mNumOfCpus =3D 0; - /** This function will be called by BSP to get the CPU number. =20 @@ -32,11 +28,17 @@ GetCpusNum ( VOID ) { - if (mNumOfCpus =3D=3D 0) { - mNumOfCpus =3D TdVCpuNum (); + UINT64 Status; + TD_RETURN_DATA TdReturnData; + + Status =3D TdCall (TDCALL_TDINFO, 0, 0, 0, &TdReturnData); + if (Status =3D=3D TDX_EXIT_REASON_SUCCESS) { + return TdReturnData.TdInfo.NumVcpus; + } else { + DEBUG ((DEBUG_ERROR, "Failed call TDCALL_TDINFO. %llx\n", Status)); } =20 - return mNumOfCpus; + return 0; } =20 /** @@ -48,11 +50,7 @@ GetTdxMailBox ( VOID ) { - if (mMailBox =3D=3D NULL) { - mMailBox =3D (VOID *)(UINTN)PcdGet32 (PcdOvmfSecGhcbBackupBase); - } - - return mMailBox; + return (VOID *)(UINTN)PcdGet32 (PcdOvmfSecGhcbBackupBase); } =20 /** --=20 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97427): https://edk2.groups.io/g/devel/message/97427 Mute This Topic: https://groups.io/mt/95684987/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-