From nobody Fri May 3 06:56:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+97315+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97315+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1670948546; cv=none; d=zohomail.com; s=zohoarc; b=On8gMQaKMPgzUSnstpzY2aqIANdEvt2GJjfV7SvCKzpCP8rPohn4sfPW72/+wd9AnMKSUmIZDJNyYHx8P8NmzX/5zw75MnCZfvyy4Xfcqf4YSB8oqGFb9m8oSgwR4cGryzt8iOupgced+TPnmmyuUd+EyejeueKnwR+Vm/RhExE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670948546; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=XCc67qSR+TTOpuUjR3YHWKhM0M4yz4eXnU8zaEFaUbk=; b=EsjKQmihFtfx2lEKbgfQKyheH/aWwgfHCGlwg7IH0pzJJlT954owkuZsGCdljBGve5lOs3PeV6HCOU5l9Of0xPx8KbPhxPlNMBSfkKt/kFXzE2kCKc5PFmGEo9pSiwQlRrrQAqJPnB3GOScp2F83s9e9N/tEicpj4kTG5WBjk+Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97315+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1670948546462514.2377351670841; Tue, 13 Dec 2022 08:22:26 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id yBdeYY1788612xUABNJF90UJ; Tue, 13 Dec 2022 08:22:26 -0800 X-Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web10.77948.1670948545369207626 for ; Tue, 13 Dec 2022 08:22:25 -0800 X-Received: by mail-lj1-f175.google.com with SMTP id f20so3816837lja.4 for ; Tue, 13 Dec 2022 08:22:25 -0800 (PST) X-Gm-Message-State: bq2l333UAUkwWKgrRd33bXmkx1787277AA= X-Google-Smtp-Source: AA0mqf4JzNb+Bg4mqTzX8wKCJdFIMjQbx5xYAxvH0aDDIsc2dKY6oDWs1jV0iMzUxnOkmmjTHC+apg== X-Received: by 2002:a05:651c:1248:b0:279:bbe1:72e1 with SMTP id h8-20020a05651c124800b00279bbe172e1mr4924059ljh.18.1670948543276; Tue, 13 Dec 2022 08:22:23 -0800 (PST) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id w28-20020a05651c119c00b0026dfbdfc1ddsm317677ljo.11.2022.12.13.08.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 08:22:22 -0800 (PST) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: bob.c.feng@intel.com, gaoliming@byosoft.com.cn, yuwei.chen@intel.com, jake@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH] Fix cyclic dependency error on OptionROM build Date: Tue, 13 Dec 2022 19:22:22 +0300 Message-Id: <20221213162222.590-1-aladyshev22@gmail.com> In-Reply-To: <20221212130924.8156-1-aladyshev22@gmail.com> References: <20221212130924.8156-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1670948546; bh=vGCBTPWpXeS+GzvP80yAx/5Ru0FygbsfOH4hMoWfRFg=; h=Cc:Date:From:Reply-To:Subject:To; b=MoF+HPeDjYH5+g6B5x8aLNlEoEoUa8NBaOwCh2rTGTwbhkLFwWLBDhht1iV5KCOyeyy I3nyXK4CmcDyiURMvXxU1sI66C9fKu1stpg9kLwD87BxbCZnPj+j39PCh2WC177Ub32SS XJkWphN6SEIbr9BNpSyZKSzbqZmfrQP1WjY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1670948547698100001 Content-Type: text/plain; charset="utf-8" EDKII build system supports OptionROM generation if particular PCI_* defines are present in the module INF file: ``` [Defines] ... PCI_VENDOR_ID =3D <...> PCI_DEVICE_ID =3D <...> PCI_CLASS_CODE =3D <...> PCI_REVISION =3D <...> ``` Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698 ("BaseTools/Conf: Fix Dynamic-Library-File template") it is no longer possible. The build system fails with the error: ``` Cyclic dependency detected while generating rule for "<...>/DEBUG/<...>.efi" file ``` Remove "$(DEBUG_DIR)(+)$(MODULE_NAME).efi" from the 'dll' output files to fix the cyclic dependency. Reviewed-by: Bob Feng --- BaseTools/Conf/build_rule.template | 1 - 1 file changed, 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index af4819de92..21ccd864fa 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -342,7 +342,6 @@ =20 $(OUTPUT_DIR)(+)$(MODULE_NAME).efi - $(DEBUG_DIR)(+)$(MODULE_NAME).efi $(OUTPUT_DIR)(+)$(MODULE_NAME).map =20 --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97315): https://edk2.groups.io/g/devel/message/97315 Mute This Topic: https://groups.io/mt/95647902/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-