From nobody Mon Feb 9 10:29:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+97265+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97265+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1670856426; cv=none; d=zohomail.com; s=zohoarc; b=cMU3uG7gKKMuRAdG+vKhv4ZANUutWZSeyI2a9gN7e7g9/mI/WKZm0khd71ELGa2jQniNhiWCcLwzaEN/1SJi8VM+sSl9AdUWIFA0TKFdHZI8DSC0pMcSFfKTFM0w7eKy2UcR2+PpbE6Wv7sJ1aJ5K7AeLDfWLH/TnYK+frkmoLk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670856426; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=kO3mMUUqv3nvpKiZv+aI+vl5Xy3scVvMLN2aqRn1Xs4=; b=cfdyPGUupIvsF7754XwS/ULgX481zxHOJsaREEeM/z9fuN+LoF5NNRp/woMKBCU7F1Py3ERuk4qT+zZwusN9slbM4/di6LLRGOyN2sglQs8XI/2rkRJVWefFJCHDu9X44VrcM6cRTSLItdSGe5xzcW0nZqzCHLCdsYhYPiV9xFE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97265+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1670856426538826.7446082310274; Mon, 12 Dec 2022 06:47:06 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4sKbYY1788612xc0qCnRa2Ut; Mon, 12 Dec 2022 06:47:06 -0800 X-Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mx.groups.io with SMTP id smtpd.web10.44805.1670856425579707957 for ; Mon, 12 Dec 2022 06:47:05 -0800 X-Received: by mail-lf1-f44.google.com with SMTP id cf42so19016136lfb.1 for ; Mon, 12 Dec 2022 06:47:05 -0800 (PST) X-Gm-Message-State: 1mHoFbXMAAgGciGw45RlGEYBx1787277AA= X-Google-Smtp-Source: AA0mqf53qZM6Jd860mJYyb8NTFSiaW07/fiCZpdgPx2eJAuPqSZrNyb7lE+AwlQAqUxOnHG8kQjzlg== X-Received: by 2002:a19:ad05:0:b0:4b5:b8cd:d2c6 with SMTP id t5-20020a19ad05000000b004b5b8cdd2c6mr2246305lfc.14.1670856423667; Mon, 12 Dec 2022 06:47:03 -0800 (PST) X-Received: from localhost.localdomain ([77.221.215.144]) by smtp.gmail.com with ESMTPSA id t4-20020a056512030400b0049c29292250sm1643313lfp.149.2022.12.12.06.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 06:47:03 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-devel] [edk2-platforms][PATCH v2 05/11] Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group Date: Mon, 12 Dec 2022 20:46:48 +0600 Message-Id: <20221212144654.2650-6-savvamtr@gmail.com> In-Reply-To: <20221212144654.2650-1-savvamtr@gmail.com> References: <20221212144654.2650-1-savvamtr@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,savvamtr@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1670856426; bh=KCLlbUmrgmJMPgfeXykPXN/Mf8ue35d8JlYNDkUTUaU=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=c9rhpmnni+UAF7lt/zdu46v43eCa6CRD/bZWgiAFxDntK9T4vriNZ/cS6P5gxFBxf29 yu5MJSYGELlI8pk7Wwj8CwiYKlQd8+nsYvFiODkJaYNz9FuYnsUf+eApGIeGrlz0ERbyj GP8SyJSeer2jNifmZJWfOGsgyj7t8x8wqyc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1670856428278100022 Content-Type: text/plain; charset="utf-8" Superblock s_inodes_per_group field can't be zero, it leads to division by zero in BlockGroup routine Ext4ReadInode Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: e55f0527dde48a5f139c1b8f35acc4e6b59dd794 Signed-off-by: Savva Mitrofanov --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext4D= xe/Superblock.c index 4c662bd1784f..adaf475ea54d 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c @@ -243,6 +243,11 @@ Ext4OpenSuperblock ( =20 DEBUG ((DEBUG_FS, "Read only =3D %u\n", Partition->ReadOnly)); =20 + if (Sb->s_inodes_per_group =3D=3D 0) { + DEBUG ((DEBUG_ERROR, "[ext4] Inodes per group can not be zero\n")); + return EFI_VOLUME_CORRUPTED; + } + Partition->BlockSize =3D (UINT32)LShiftU64 (1024, Sb->s_log_block_size); =20 // The size of a block group can also be calculated as 8 * Partition->Bl= ockSize --=20 2.38.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97265): https://edk2.groups.io/g/devel/message/97265 Mute This Topic: https://groups.io/mt/95622333/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-