From nobody Wed May 1 07:32:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+97258+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97258+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1670850595; cv=none; d=zohomail.com; s=zohoarc; b=gwjCDBYmrEbzTL8hWK508eVBFZQ4Q51mWZj4FWnypL07LI8UUjRDQqVaXXVlbPyeFaBa2ZDMtRIhAO4cKJJnE+EldA2iOqvd8+1W3alpDYHA9/DQp+EhXcfrLBh4R9AsyDD5NBLMz3JRaBqH4P5UCMGArC2NJvGAyZSCJeMCtc8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670850595; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=hZDpTTNcv9SpcZkNlXtkaXNSBdmV/6HedJpoqLEN/PI=; b=XUoShJEzPn1ZslAtsYxtaMVXwFBYCxpjMhS2/1gC1MrROcxyO4tfBRVUibVxcufyiwX6GUpqp1+BTorwtLERrp1/Ee7yowQr6OHrmI9QKu3FveDnoJEdM/fz9Bj2J4c37jk7qTX0+zhEPuHNCPWU7IhyKzKJKDGXVnTsEHuGBIQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+97258+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1670850595604449.57822969467054; Mon, 12 Dec 2022 05:09:55 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id dsHeYY1788612xkaB8KpC00f; Mon, 12 Dec 2022 05:09:55 -0800 X-Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by mx.groups.io with SMTP id smtpd.web10.42494.1670850594341658231 for ; Mon, 12 Dec 2022 05:09:54 -0800 X-Received: by mail-lj1-f174.google.com with SMTP id y4so3483750ljc.9 for ; Mon, 12 Dec 2022 05:09:54 -0800 (PST) X-Gm-Message-State: TG6PvQ1FVzPjL9hwEM09aP7nx1787277AA= X-Google-Smtp-Source: AA0mqf6cLDIGo9NWg8seszJKuVxQ3F9WSCtQ5ou67JFN1ba32FZHmICzI4maKyijjdaaKYo1l/DGKg== X-Received: by 2002:a05:651c:1947:b0:279:8a9c:ffd4 with SMTP id bs7-20020a05651c194700b002798a9cffd4mr4525201ljb.12.1670850591981; Mon, 12 Dec 2022 05:09:51 -0800 (PST) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id k3-20020a2ea263000000b0026c4305e5e2sm1213013ljm.53.2022.12.12.05.09.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 05:09:50 -0800 (PST) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: bob.c.feng@intel.com, gaoliming@byosoft.com.cn, yuwei.chen@intel.com, jake@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH] Revert "BaseTools/Conf: Fix Dynamic-Library-File template" Date: Mon, 12 Dec 2022 16:09:24 +0300 Message-Id: <20221212130924.8156-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1670850595; bh=ixsP5UL1g5NkCtDNU5xIGZsb3K2aEwcAu0DFuiVH/KA=; h=Cc:Date:From:Reply-To:Subject:To; b=NIS16CB63YYytmMQD9Po0y6YXan1PGKq1xE6/PPrvvxLt2Mf4nqE0oQOdQfP4Frbvt0 DALePxN0UpmRY1wj9yrSUpEcPsexyqE1Brkjk6ZEFbhfxnjGRgMa8GUHdmuzcfPdliECM bq4CjnTB2eiOeWv1SkWiNI8tKZ3q1rNA3FQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1670850610477100001 Content-Type: text/plain; charset="utf-8" Revert commit d372ab585a2cdc5348af5f701c56c631235fe698. EdkII build system supports OptionROM generation if particular PCI_* defines are present in the module INF file: ``` [Defines] ... PCI_VENDOR_ID =3D <...> PCI_DEVICE_ID =3D <...> PCI_CLASS_CODE =3D <...> PCI_REVISION =3D <...> ``` Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698 it is no longer possible. The build system fails with the error: ``` Cyclic dependency detected while generating rule for "<...>/DEBUG/<...>.efi" file ``` Revert d372ab585a2cdc5348af5f701c56c631235fe698 until the issue is resolved. --- BaseTools/Conf/build_rule.template | 2 -- 1 file changed, 2 deletions(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index af4819de92..32053f6353 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -342,8 +342,6 @@ =20 $(OUTPUT_DIR)(+)$(MODULE_NAME).efi - $(DEBUG_DIR)(+)$(MODULE_NAME).efi - $(OUTPUT_DIR)(+)$(MODULE_NAME).map =20 "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS) --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97258): https://edk2.groups.io/g/devel/message/97258 Mute This Topic: https://groups.io/mt/95620341/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-