From nobody Fri May 3 12:47:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+96678+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96678+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1669730061; cv=none; d=zohomail.com; s=zohoarc; b=FJf4lL7aFk+gqp+2EPvted6u5VKi+lo78gk9vd/6R8UyZDLCWlg4tgEeMyggQiyV0SqiW5hxnkMUJ31cDmgpYzwWeRjkDvPUKVu4+cBASGIcyKN8b8Ij14aMJduVjLou8fC9bRCEiOjS48xvu1OZqlA1yk6j0K2pmrGd1R518oU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669730061; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=WidZ+gf7RbyF+YF0zoV7WC0/48tLCSC6fDRkKByV9jw=; b=fqJqaj/QuIXDSq145lSPcy6SBDy3EfO3A03lbA8rSw4l4aV2kg7XJskIVmS/K9Ey4wvMDNT6k9wwpKnVyp41eOIp/FgCO1ntsYLENVkG4HXE+85QMhDp/ftC9jvHVyrvYpjSxTRF5j/xROyh1DitgwhkgHMJXZBfwSKqjIbIfak= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96678+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1669730061957584.7600379098373; Tue, 29 Nov 2022 05:54:21 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id UkF4YY1788612xTdaGeTTkKA; Tue, 29 Nov 2022 05:54:21 -0800 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.150163.1669730061003421822 for ; Tue, 29 Nov 2022 05:54:21 -0800 X-Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ATBPOtE021519; Tue, 29 Nov 2022 13:54:17 GMT X-Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3m56vca02w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Nov 2022 13:54:17 +0000 X-Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2ATDsGpV022713 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Nov 2022 13:54:16 GMT X-Received: from linbox.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 29 Nov 2022 05:54:16 -0800 From: "Rebecca Cran" To: , Ard Biesheuvel , "Thomas Abraham" , Sami Mujawar CC: Rebecca Cran Subject: [edk2-devel] [PATCH edk2-platforms 1/3] Platform/ARM/JunoPkg: Switch to MdeModulePkg/Universal/Metronome driver Date: Tue, 29 Nov 2022 06:53:56 -0700 Message-ID: <20221129135358.136555-2-rebecca@quicinc.com> In-Reply-To: <20221129135358.136555-1-rebecca@quicinc.com> References: <20221129135358.136555-1-rebecca@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-GUID: TXQApPzgGn6F-0VLq-9QOxP4wvLxVSWL X-Proofpoint-ORIG-GUID: TXQApPzgGn6F-0VLq-9QOxP4wvLxVSWL Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_rcran@quicinc.com X-Gm-Message-State: OJcqybeAMOnvFzOUPARQ7hDyx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1669730061; bh=58GZshmD78pUoIg5OSSAHIERgsbLFXvJudexVOHpAZI=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=S3F9xufofwh9b2fXFTFIL7UZ08WETH5yIKYB3KSigPjkF2pmX7hz2Y7zKCpvkG73aWI 4+oQs5OFrkwwGST9mB+Tv7SdXaiqOy69f8GgLMc9XDlSkDaDcphwtBHmznNx9KjDUNNNH 7Bo2Kvm9WmcXBtBY+IiHUqmsC4yx8xqG6EY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1669730062782100005 Content-Type: text/plain; charset="utf-8" The MetronomeDxe driver uses the PCD PcdMetronomeTickPeriod to calculate how many ticks to wait in MicroSecondDelay. Given that the timer clock on Juno runs at 50 MHz, it ticks every 20 ns; therefore, a setting of 1000 is wrong: for example it causes a call to gBS->Stall (1) to take 10 us. The driver in MdeModulePkg/Universal/Metronome assumes the clock ticks at least every 100 ns, which is the minimum allowed by the Metronome protocol. Since that's the case on Juno, switch from EmbeddedPkg/MetronomeDxe to MdeModulePkg/Universal/Metronome. Signed-off-by: Rebecca Cran --- Platform/ARM/JunoPkg/ArmJuno.dsc | 3 +-- Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJun= o.dsc index a00b866c5e9a..9cde4c862651 100644 --- a/Platform/ARM/JunoPkg/ArmJuno.dsc +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc @@ -189,7 +189,6 @@ [PcdsFixedAtBuild.common] # ARM Architectural Timer Frequency # gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|50000000 - gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000 =20 gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FAL= SE =20 @@ -248,10 +247,10 @@ [Components.common] MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf + MdeModulePkg/Universal/Metronome/Metronome.inf MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntim= eDxe.inf MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf - EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf =20 MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf diff --git a/Platform/ARM/JunoPkg/ArmJuno.fdf b/Platform/ARM/JunoPkg/ArmJun= o.fdf index fca5a78cee6c..836d3cde8781 100644 --- a/Platform/ARM/JunoPkg/ArmJuno.fdf +++ b/Platform/ARM/JunoPkg/ArmJuno.fdf @@ -96,10 +96,10 @@ [FV.FvMain] INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf INF MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf + INF MdeModulePkg/Universal/Metronome/Metronome.inf INF MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRu= ntimeDxe.inf INF MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.i= nf INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf - INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf =20 INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.i= nf --=20 2.30.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96678): https://edk2.groups.io/g/devel/message/96678 Mute This Topic: https://groups.io/mt/95334363/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 12:47:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+96680+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96680+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1669730062; cv=none; d=zohomail.com; s=zohoarc; b=MIkXfXlbz6OivRQLo6eW1kCaOqdG927/SQnr+LB2pFWxaWqnBn+BL+UoNZUG5Nb4zwRwf8R6E0Gmgm4sk1ogoRYfOJXZR1uajzazGf2buL6ZrgP7y3xRMo362csWUL3gXyvHOIfW0aN8Ba9wwfyKH3tesup9UzkTPCWq3W/Stng= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669730062; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Bo11QneoqPzSfQxVZyoYzQshRjnQiB/xaJ2pkM6WWCE=; b=EJWhE77BgEkSVndu9cp7KhkwkyRu/XSIuNV1CGDxrL4xXJXMu8Td3QxPW4mn1Rj6RgBu+x7be+WpXk0mZOG7CuO8HXLVaeheDQTKi9YYiTrcO93fMN6VEr34SkSn7NnjhwLqx8zG6MpjyZH5NOo043LflD2qi8cM/SPGizmuH4Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96680+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1669730062688418.4910627952203; Tue, 29 Nov 2022 05:54:22 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id f0frYY1788612xLrh0I15P6r; Tue, 29 Nov 2022 05:54:22 -0800 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.150164.1669730061678352182 for ; Tue, 29 Nov 2022 05:54:21 -0800 X-Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ATDo8ti028951; Tue, 29 Nov 2022 13:54:18 GMT X-Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3m5fjx0jge-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Nov 2022 13:54:18 +0000 X-Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2ATDsHfY018169 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Nov 2022 13:54:17 GMT X-Received: from linbox.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 29 Nov 2022 05:54:16 -0800 From: "Rebecca Cran" To: , Ard Biesheuvel , "Thomas Abraham" , Sami Mujawar CC: Rebecca Cran Subject: [edk2-devel] [PATCH edk2-platforms 2/3] Platform/ARM/JunoPkg: Override PcdTimerPeriod to be 10000 Date: Tue, 29 Nov 2022 06:53:57 -0700 Message-ID: <20221129135358.136555-3-rebecca@quicinc.com> In-Reply-To: <20221129135358.136555-1-rebecca@quicinc.com> References: <20221129135358.136555-1-rebecca@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: 0Qc8Ifa4OoDJYzRaRGJ2xQ2z74dl0A1g X-Proofpoint-GUID: 0Qc8Ifa4OoDJYzRaRGJ2xQ2z74dl0A1g Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_rcran@quicinc.com X-Gm-Message-State: 6V0ds9QqLVmHlqhaECs3EwvKx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1669730062; bh=aXMziZmC7qNUlxtrar6JZCpe0dwsBa9g416lUbAKL2I=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=o8p7QrQlOo6SvogblxBOuiib3BqgtwW8fKGobfW2369csPYkHFnxjQh5WqV/QnWeSy6 4ppH5I76TdlMLMCHaaGh5EPnv8IGObWcFJmY2gk3dYSYCpziWKfJL0PzkkFKl6O+Km6WZ agcDqzXF0WW8ewvBHwwTSL6Nv1FdXIQgLes= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1669730064727100013 Content-Type: text/plain; charset="utf-8" The PCD PcdTimerPeriod is used in TimerDxe to calculate how many ticks to wait between timer interrupts. The default value of 100000 results in waiting 10 ms, while the driver wants interrupts to occur every 1ms. Override the value of PcdTimerPeriod in ArmJuno.dsc to be 10000. Signed-off-by: Rebecca Cran --- Platform/ARM/JunoPkg/ArmJuno.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJun= o.dsc index 9cde4c862651..9b63a8914f03 100644 --- a/Platform/ARM/JunoPkg/ArmJuno.dsc +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc @@ -189,6 +189,7 @@ [PcdsFixedAtBuild.common] # ARM Architectural Timer Frequency # gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|50000000 + gEmbeddedTokenSpaceGuid.PcdTimerPeriod|10000 =20 gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FAL= SE =20 --=20 2.30.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96680): https://edk2.groups.io/g/devel/message/96680 Mute This Topic: https://groups.io/mt/95334365/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 12:47:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+96679+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96679+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1669730062; cv=none; d=zohomail.com; s=zohoarc; b=l4rQsfJtofsfGsM0Ot1sapKIXBLgFMBCatyybghsWEteIFNi8+utjoMF0MBuyva1R738mnCdljqAbKTnxgcrghKtcZv6MMKCNvlk9iMXQfPdSX0CZSY01MT5M1cTf2NCa1cFhK69NCmcps6CQzVEUaaLu8P+Uo91g2CVuyvRCMI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669730062; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=kgJyxkIJa0JEkctwbpU6UMVeuXVZ8vxEPStPlkudrXg=; b=nj6pcSEFoLjyUhTOSbfdUYU8PsPeHik7sBmQGMzgHhipERHlRnTdKF86JifKXakEuVY7gQG30NENm1lOFwbTB4nReGA63Y8n5aYPOirZHbJDspCCOhKz0V6ZprGdA0WGiUdkOIemWT7lzkKDL164/bNlCTHw7WtUbXbBoDQ5S5U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96679+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1669730062322757.996035075169; Tue, 29 Nov 2022 05:54:22 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id zIx8YY1788612x8WNTvBtvqY; Tue, 29 Nov 2022 05:54:22 -0800 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.149725.1669730061437992539 for ; Tue, 29 Nov 2022 05:54:21 -0800 X-Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AT9nQEs003715; Tue, 29 Nov 2022 13:54:18 GMT X-Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3m56vca030-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Nov 2022 13:54:18 +0000 X-Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2ATDsHMu018536 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Nov 2022 13:54:17 GMT X-Received: from linbox.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 29 Nov 2022 05:54:17 -0800 From: "Rebecca Cran" To: , Ard Biesheuvel , "Thomas Abraham" , Sami Mujawar CC: Rebecca Cran Subject: [edk2-devel] [PATCH edk2-platforms 3/3] Platform/ARM/JunoPkg: Set PcdArmArchTimerFreqInHz to 0 to read from CNTFRQ_EL0 Date: Tue, 29 Nov 2022 06:53:58 -0700 Message-ID: <20221129135358.136555-4-rebecca@quicinc.com> In-Reply-To: <20221129135358.136555-1-rebecca@quicinc.com> References: <20221129135358.136555-1-rebecca@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-GUID: d4jZapp09LDfK51j95NfFgl3_BXPQO9P X-Proofpoint-ORIG-GUID: d4jZapp09LDfK51j95NfFgl3_BXPQO9P Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_rcran@quicinc.com X-Gm-Message-State: qPfl2UJSOBdOQsuQcOQkZNLmx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1669730062; bh=H2vOtJ6D2EoCDLoCzujRpWZ0LSyRLUK2a01F+TNMB7U=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=mpqMv/JtzmSRxLXyYNg3TLf1uoYYvJ64rSZapXDW9hKp/BZ7AQvv9xE88eCuiIU6hq0 mgEa33AS6VfAP+6+iOhUyUJZhD7DdBVki3qwtntDRVuaOt5IHjZiADcUfYVGo6Sx6Flzq WiUYP6zSnO2J6aoLwvIDRBnSc5bQG86JhK0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1669730062779100004 Content-Type: text/plain; charset="utf-8" If PcdArmArchTimerFreqInHz is zero, the value of the timer frequency will be read from CNTFRQ_EL0. Avoid hard-coding the value in ArmJuno.dsc and instead let the ArmArchTimerLib driver read it from the SoC. Signed-off-by: Rebecca Cran --- Platform/ARM/JunoPkg/ArmJuno.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJun= o.dsc index 9b63a8914f03..e40005862072 100644 --- a/Platform/ARM/JunoPkg/ArmJuno.dsc +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc @@ -188,7 +188,8 @@ [PcdsFixedAtBuild.common] # # ARM Architectural Timer Frequency # - gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|50000000 + # Set to 0 so ArmArchTimerLib will read its value from CNTFRQ_EL0 + gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0 gEmbeddedTokenSpaceGuid.PcdTimerPeriod|10000 =20 gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FAL= SE --=20 2.30.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96679): https://edk2.groups.io/g/devel/message/96679 Mute This Topic: https://groups.io/mt/95334364/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-