From nobody Tue Feb 10 12:42:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+96618+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96618+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1669306712; cv=none; d=zohomail.com; s=zohoarc; b=c7ZncYd6Zuryoxi/uTq3NbjfhPbhN6/Zh4dV3+9KHd2UOuJKM86m1W5FCujswHqvTsQHua0+6yCQnH1hPaOJwpMjKWMrk37H0LL3+EPocnBF8RFzsgSyyo1LwIz2yMnLZKjT9Sx4rCI6Snae21LwjyW8+TNt3FGjT3dtXWEx+Uw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669306712; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Uc3n//tLoRd7WNsey0wmlKHryZlX2lavhP6YVWftpQY=; b=GbwWYOz4pIbG2i7Q8py4elAJjKnN4gMHE9WP0L4MAl48VEwhujOEYH+pGJj57+Ym4qQ4K4TUZx/D0m4Wc6FBzRe8TwVTrMzZdj1nDirmGjyGIFQ3KX7wPyhoFzvWlhLN67GPoy6cbCqShnaMYyQIno6zzq1jfTSCRlnN5NrclJ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96618+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16693067122061014.9781794603921; Thu, 24 Nov 2022 08:18:32 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id DC0FYY1788612xgeWKtBQ7FA; Thu, 24 Nov 2022 08:18:31 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.27829.1669306710399724122 for ; Thu, 24 Nov 2022 08:18:30 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 816C4106F; Thu, 24 Nov 2022 08:18:36 -0800 (PST) X-Received: from pierre123.nice.arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A49F73F587; Thu, 24 Nov 2022 08:18:28 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Jiewen Yao , Jian J Wang Subject: [edk2-devel] [PATCH v3 1/4] ArmPkg/ArmTrngLib: Remove ASSERTs in ArmTrngLibConstructor() Date: Thu, 24 Nov 2022 17:17:53 +0100 Message-Id: <20221124161756.216996-2-Pierre.Gondois@arm.com> In-Reply-To: <20221124161756.216996-1-Pierre.Gondois@arm.com> References: <20221124161756.216996-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: k4Seky4Ig0YMVWp7Pb7BdzlZx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1669306711; bh=i7+5YEl9+5w0MLIzZGnYMgaa4FmGq3rdXIMz4bqPaKw=; h=Cc:Date:From:Reply-To:Subject:To; b=Xg9bC0mgHQcYF1Kx67EM07oeoXMPouG+Gaf+NmnwIdXfJP27ASBlRIN0Rv2WG/CY+uU mwBLicao+wI8Thgy2kh4sWaYra4zcWTsnoQPzswOL1DDB+MpVaOabURuoVvox1ppDnWq1 wDbgrUnNNN/V5cm+Jt5EEhxVjkg6w/AyHTI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1669306712999100006 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois Remove ASSERTs in ArmTrngLibConstructor() that prevent from booting on DEBUG builds. Signed-off-by: Pierre Gondois --- ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c b/ArmPkg/Library/ArmTrn= gLib/ArmTrngLib.c index 3278722320c8..c2555f3ea6fe 100644 --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c @@ -331,14 +331,12 @@ ArmTrngLibConstructor ( ArmMonitorCall (&Parameters); Status =3D TrngStatusToReturnStatus ((INT32)Parameters.Arg0); if (RETURN_ERROR (Status)) { - ASSERT_RETURN_ERROR (Status); goto ErrorHandler; } =20 // Cf [1] s2.1.3 'Caller responsibilities', // SMCCC version must be greater or equal than 1.1 if ((INT32)Parameters.Arg0 < 0x10001) { - ASSERT_RETURN_ERROR (RETURN_UNSUPPORTED); goto ErrorHandler; } =20 @@ -350,14 +348,12 @@ ArmTrngLibConstructor ( // Check that the required features are present. Status =3D GetArmTrngFeatures (ARM_SMC_ID_TRNG_RND, NULL); if (RETURN_ERROR (Status)) { - ASSERT_RETURN_ERROR (Status); goto ErrorHandler; } =20 // Check if TRNG UUID is supported and if so trace the GUID. Status =3D GetArmTrngFeatures (ARM_SMC_ID_TRNG_GET_UUID, NULL); if (RETURN_ERROR (Status)) { - ASSERT_RETURN_ERROR (Status); goto ErrorHandler; } =20 @@ -365,7 +361,6 @@ ArmTrngLibConstructor ( =20 Status =3D GetArmTrngUuid (&Guid); if (RETURN_ERROR (Status)) { - ASSERT_RETURN_ERROR (Status); goto ErrorHandler; } =20 --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96618): https://edk2.groups.io/g/devel/message/96618 Mute This Topic: https://groups.io/mt/95240504/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-