From nobody Thu Apr 18 13:21:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+96464+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96464+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1668664906; cv=none; d=zohomail.com; s=zohoarc; b=n/8DbiaOIdQ6E07GbIRhWoiJG5tn2ASZCN2mb3HqL2KZ8eP9lFG8mNqprvu50Ga8+Ny/PvUxQjG19BJ9VCXiQLO/Gs/IO2mvvKUX3m/vrWpM9pNvCb0DenwadqtxjDJOwKV7h94W4TjyUzUPr53rFggQefqGZaFzyITwSVRHfEk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668664906; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=0Y/sdzIX5DyiwQgHx4nq4GBlVhY8WMrsPVKj+WZoi7Q=; b=cbJtz1pq28suSrwfqWz3s9P0Fu+8IK/uHo2NPEdKwZlDdc+9QEkZpHTmG5dozCqGiqq2zrjLM/1yizZguPcS3eq084ycqkTMd1NHk+2rAFD1ykniFfE13eGxhDUIaqQxJfdArTVLe6ovsXYxuc5ZXFLQuO9y4WuLhmNRbNCl2RE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96464+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1668664906199688.9347521645001; Wed, 16 Nov 2022 22:01:46 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id PvDBYY1788612xwQqDijuLGI; Wed, 16 Nov 2022 22:01:45 -0800 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.9321.1668664903833211691 for ; Wed, 16 Nov 2022 22:01:44 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="312780159" X-IronPort-AV: E=Sophos;i="5.96,169,1665471600"; d="scan'208";a="312780159" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2022 22:01:43 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="708477285" X-IronPort-AV: E=Sophos;i="5.96,169,1665471600"; d="scan'208";a="708477285" X-Received: from lins2x-desk1.gar.corp.intel.com ([10.225.33.149]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2022 22:01:41 -0800 From: "JackX Lin" To: devel@edk2.groups.io Cc: JackX Lin , JackX Lin , Chasel Chiu , Nate DeSimone , Isaac Oram , Liming Gao , Eric Dong , Donald Kuo , Chandana C Kumar Subject: [edk2-devel] [edk2-platforms: PATCH] BIOS needs to present cores in order of relative performance in MADT Date: Thu, 17 Nov 2022 14:01:23 +0800 Message-Id: <20221117060123.209-1-jackx.lin@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,JackX.Lin@intel.com X-Gm-Message-State: DViSCK9ky9YgVoiZYakuTGnbx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1668664905; bh=Qzfqd4qxi1wX5D1KRwMP44N0KXAaSEOEftn8ruu9/No=; h=Cc:Date:From:Reply-To:Subject:To; b=Lc1ljoTWtXwOYOADWqwo+svePgv0RRyzCtzxSv8QRzAlqRsY8u/TGe2HnHNaQwYhvAs v+2S9QNFuEEexhQp3jPRGRj/o85M7lCeMtUTDn19IueHy3RDq12tM+RP5jbLU5QI8iKC6 3z0aMBL1FZ7/1ql4kgd+wZ480rF5DZHzJkI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1668664908137100003 Content-Type: text/plain; charset="utf-8" BIOS should keep MADT ordering by big core first then small core Signed-off-by: JackX Lin Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Cc: Donald Kuo Cc: Chandana C Kumar Cc: JackX Lin Reviewed-by: Michael D Kinney --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 111 +++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++------- 1 file changed, 104 insertions(+), 7 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b= /Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index 6e57b638e0..894790f246 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -18,6 +18,7 @@ typedef struct { UINT32 Flags; UINT32 SocketNum; UINT32 Thread; + UINT8 CpuCoreType; } EFI_CPU_ID_ORDER_MAP; =20 // @@ -131,6 +132,49 @@ AppendCpuMapTableEntry ( =20 } =20 +/** + Function will go through all processors to identify Core or Atom + by checking Core Type and update in IsBigCore. + + @param[in] CpuApicIdOrderTable Point to a buffer which will be f= illed in Core type information. +**/ +VOID +STATIC +EFIAPI +CollectCpuCoreType ( + IN EFI_CPU_ID_ORDER_MAP *CpuApicIdOrderTable + ) +{ + CPUID_STRUCTURED_EXTENDED_FEATURE_FLAGS_EDX Edx; + UINT32 Eax; + UINTN ApNumber; + EFI_STATUS Status; + UINT8 CoreType; + + Status =3D mMpService->WhoAmI ( + mMpService, + &ApNumber + ); + ASSERT_EFI_ERROR (Status); + + /// + /// Check Hetero feature is supported + /// with CPUID.(EAX=3D7,ECX=3D0):EDX[15]=3D1 + /// + AsmCpuidEx (CPUID_STRUCTURED_EXTENDED_FEATURE_FLAGS, 0, NULL, NULL, NULL= , &Edx.Uint32); + if (Edx.Bits.Hybrid =3D=3D 1) { + // + // Check which is the running core by reading CPUID.(EAX=3D1AH, ECX=3D= 00H):EAX + // + AsmCpuid (CPUID_HYBRID_INFORMATION, &Eax, NULL, NULL, NULL); + CoreType =3D (UINT8) ((Eax & 0xFF000000) >> 24); + } else { + CoreType =3D CPUID_CORE_TYPE_INTEL_CORE; + } + + CpuApicIdOrderTable[ApNumber].CpuCoreType =3D CoreType; +} + /** Collect all processors information and create a Cpu Apic Id table. =20 @@ -138,7 +182,7 @@ AppendCpuMapTableEntry ( **/ EFI_STATUS CreateCpuLocalApicInTable ( - IN EFI_CPU_ID_ORDER_MAP *CpuApicIdOrderTable + IN EFI_CPU_ID_ORDER_MAP *CpuApicIdOrderTable ) { EFI_STATUS Status; @@ -146,9 +190,24 @@ CreateCpuLocalApicInTable ( UINT32 Index; UINT32 CurrProcessor; EFI_CPU_ID_ORDER_MAP *CpuIdMapPtr; + EFI_CPU_ID_ORDER_MAP *TempCpuApicIdOrderTable; UINT32 Socket; =20 - Status =3D EFI_SUCCESS; + TempCpuApicIdOrderTable =3D AllocateZeroPool (mNumberOfCpus * sizeof (EF= I_CPU_ID_ORDER_MAP)); + if (TempCpuApicIdOrderTable =3D=3D NULL) { + return EFI_UNSUPPORTED; + } + + CollectCpuCoreType (TempCpuApicIdOrderTable); + mMpService->StartupAllAPs ( + mMpService, // This + (EFI_AP_PROCEDURE) CollectCpuCoreType, // Procedure + TRUE, // SingleThread + NULL, // WaitEvent + 0, // TimeoutInMicr= osecsond + TempCpuApicIdOrderTable, // ProcedureArgu= ment + NULL // FailedCpuList + ); =20 for (CurrProcessor =3D 0, Index =3D 0; CurrProcessor < mNumberOfCpus; Cu= rrProcessor++, Index++) { Status =3D mMpService->GetProcessorInfo ( @@ -157,9 +216,9 @@ CreateCpuLocalApicInTable ( &ProcessorInfoBuffer ); =20 - CpuIdMapPtr =3D (EFI_CPU_ID_ORDER_MAP *) &CpuApicIdOrderTable[Index]; + CpuIdMapPtr =3D (EFI_CPU_ID_ORDER_MAP *) &TempCpuApicIdOrderTable[Inde= x]; if ((ProcessorInfoBuffer.StatusFlag & PROCESSOR_ENABLED_BIT) !=3D 0) { - CpuIdMapPtr->ApicId =3D (UINT32)ProcessorInfoBuffer.ProcessorId; + CpuIdMapPtr->ApicId =3D (UINT32) ProcessorInfoBuffer.ProcessorId; CpuIdMapPtr->Thread =3D ProcessorInfoBuffer.Location.Thread; CpuIdMapPtr->Flags =3D ((ProcessorInfoBuffer.StatusFlag & PROCESSO= R_ENABLED_BIT) !=3D 0); CpuIdMapPtr->SocketNum =3D ProcessorInfoBuffer.Location.Package; @@ -184,22 +243,60 @@ CreateCpuLocalApicInTable ( // DEBUG ((DEBUG_INFO, "BspApicId - 0x%x\n", GetApicId ())); =20 - // // Fill in AcpiProcessorUid. // for (Socket =3D 0; Socket < FixedPcdGet32 (PcdMaxCpuSocketCount); Socket= ++) { for (CurrProcessor =3D 0, Index =3D 0; CurrProcessor < mNumberOfCpus; = CurrProcessor++) { - if (CpuApicIdOrderTable[CurrProcessor].Flags && (CpuApicIdOrderTable= [CurrProcessor].SocketNum =3D=3D Socket)) { - CpuApicIdOrderTable[CurrProcessor].AcpiProcessorUid =3D (CpuApicId= OrderTable[CurrProcessor].SocketNum << mNumOfBitShift) + Index; + if (TempCpuApicIdOrderTable[CurrProcessor].Flags && (TempCpuApicIdOr= derTable[CurrProcessor].SocketNum =3D=3D Socket)) { + TempCpuApicIdOrderTable[CurrProcessor].AcpiProcessorUid =3D (TempC= puApicIdOrderTable[CurrProcessor].SocketNum << mNumOfBitShift) + Index; Index++; } } } =20 + // + // Re-ordering Cpu cores information to CpuApicIdOrderTable + // by big core first, then small core. + // + for (Index =3D 0, CurrProcessor =3D 0; Index < mNumberOfCpus; Index++) { + if (TempCpuApicIdOrderTable[Index].CpuCoreType =3D=3D CPUID_CORE_TYPE_= INTEL_CORE) { + CopyMem (&CpuApicIdOrderTable[CurrProcessor], &TempCpuApicIdOrderTab= le[Index], sizeof (EFI_CPU_ID_ORDER_MAP)); + CurrProcessor++; + } + } + + for (Index =3D 0; Index < mNumberOfCpus; Index++) { + if (TempCpuApicIdOrderTable[Index].CpuCoreType =3D=3D CPUID_CORE_TYPE_= INTEL_ATOM) { + CopyMem (&CpuApicIdOrderTable[CurrProcessor], &TempCpuApicIdOrderTab= le[Index], sizeof (EFI_CPU_ID_ORDER_MAP)); + CurrProcessor++; + } + } + + // + // Add unknown cpu core types to the bottom of the table + // + for (Index =3D 0; Index < mNumberOfCpus; Index++) { + if ((TempCpuApicIdOrderTable[Index].CpuCoreType !=3D CPUID_CORE_TYPE_I= NTEL_CORE) && (TempCpuApicIdOrderTable[Index].CpuCoreType !=3D CPUID_CORE_T= YPE_INTEL_ATOM)) { + DEBUG (( + DEBUG_INFO, + "Unknown Cpu Core type found: Apic =3D 0x%x, CoreType =3D 0x%x\n", + TempCpuApicIdOrderTable[Index].ApicId, + TempCpuApicIdOrderTable[Index].CpuCoreType + )); + + CopyMem (&CpuApicIdOrderTable[CurrProcessor], &TempCpuApicIdOrderTab= le[Index], sizeof (EFI_CPU_ID_ORDER_MAP)); + CurrProcessor++; + } + } + DEBUG ((DEBUG_INFO, "::ACPI:: APIC ID Order Table Init. mNumOfBitShif= t =3D %x\n", mNumOfBitShift)); DebugDisplayReOrderTable (CpuApicIdOrderTable); =20 + if (TempCpuApicIdOrderTable !=3D NULL) { + FreePool (TempCpuApicIdOrderTable); + } + return Status; } =20 --=20 2.32.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96464): https://edk2.groups.io/g/devel/message/96464 Mute This Topic: https://groups.io/mt/95059445/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-