From nobody Thu Apr 25 10:01:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+96424+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96424+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1668587067; cv=none; d=zohomail.com; s=zohoarc; b=P+j+OUWzNkAwpwzJEuCBy5uagrvnkUD3gYDEZutqIaQjI5EOF2+TCBcgnEyoyxhtUAmbTUOhFbaIzj72iXpdB86Y2uD9Sos44RpLmBqii4S5XrnO7dj92fOEMrAhj8+Y8AKFIE5UK5MAgJPfuJcZGcXjCBOU6sDAmOC+heu7waw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668587067; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=cUSG0CtBjqDWA9YFJ1NfUfM7/kEyJ8voOAYrQrW4L3s=; b=T/gkR56bIrNhwR1sTKpPsKawey4VSgLoBR6VUA/b4mCajFFQKhRsonNWitn74+gS0ErZFSXk0jtVrSKmGKNGgqWZ7hlAO7dcaNGvsSilUGYmaUaTgI96qO67DHHkBmuhykwABD7jOSruFeV7Oxihi1gMTzdRvWojeR8SUjGIRgg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96424+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1668587066942350.6141874199716; Wed, 16 Nov 2022 00:24:26 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id X9HPYY1788612xaCBDkSOXHh; Wed, 16 Nov 2022 00:24:26 -0800 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web08.4354.1668587065770801430 for ; Wed, 16 Nov 2022 00:24:26 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10532"; a="313635031" X-IronPort-AV: E=Sophos;i="5.96,167,1665471600"; d="scan'208";a="313635031" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2022 00:24:25 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10532"; a="670412148" X-IronPort-AV: E=Sophos;i="5.96,167,1665471600"; d="scan'208";a="670412148" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.255.229.111]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2022 00:24:25 -0800 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Ray Ni , Rangasai V Chaganty , Isaac Oram , Ashraf Ali S Subject: [edk2-devel] [Patch] IntelSiliconPkg/IntelVTdDmarPei: Fix CLANG detected incorrect return Date: Wed, 16 Nov 2022 00:24:17 -0800 Message-Id: <20221116082418.259-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com X-Gm-Message-State: jXOklzuBVW65bd5SNtHKtbcHx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1668587066; bh=aGFVTm+zUbkdKnW81f8FTcmy2SNqPuUS6vjS9KUAY2w=; h=Cc:Date:From:Reply-To:Subject:To; b=AthRLK76CsEU4soI1KdbkuL7mW2NyUE5lm8oNtb2AT9zT8OfED/0aaY1f4RXIB6DU5w /vKUYN3lJiWBnDKG1SWPU5BlYypbCyfhPva4IQVUegqdES8DSPEaagXWLxQD6dPCsd0bL tWOskk+pMKtAX08PhngsHX0cgzpmghH6+Nk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1668587068868100002 Content-Type: text/plain; charset="utf-8" CreateSecondLevelPagingEntryTable() has a return type of VTD_SECOND_LEVEL_PAGING_ENTRY * and an error condition returns a value of NULL. Change return value of EFI_SUCCESS (value 0) to NULL to address CLANG compiler detection of incorrect return type. Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Isaac Oram Cc: Ashraf Ali S Signed-off-by: Michael D Kinney Reviewed-by: Ray Ni Reviewed-by: S, Ashraf Ali --- .../Feature/VTd/IntelVTdDmarPei/TranslationTable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Tran= slationTable.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/= TranslationTable.c index a806c4c000..bb121a608e 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Translation= Table.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Translation= Table.c @@ -109,7 +109,7 @@ CreateSecondLevelPagingEntryTable ( BOOLEAN Is5LevelPaging; =20 if (MemoryLimit =3D=3D 0) { - return EFI_SUCCESS; + return NULL; } =20 Lvl4PagesStart =3D 0; --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96424): https://edk2.groups.io/g/devel/message/96424 Mute This Topic: https://groups.io/mt/95062535/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-