[edk2-devel] [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions

Michael Kubacki posted 2 patches 2 weeks, 5 days ago
Failed in applying to current master (apply log)
pip-requirements.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[edk2-devel] [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
Posted by Michael Kubacki 2 weeks, 5 days ago
From: Michael Kubacki <michael.kubacki@microsoft.com>

1. Updates edk2-pytool-library to 0.12.1
   - Picks up a minor bug fix

2. Updates edk2-pytool-extensions to 0.20.0
   - Picks up a major release

The changes in each update are in the respective patch commit
messages.

CI was run against both of these patches in this pull request:
https://github.com/tianocore/edk2/pull/3632

These changes are recommended to be included in the edk2-stable202211
tag for the following reasons:

1. edk2-pytool-library 0.12.0 to 0.12.1 includes a single bug fix
   that simply returns file paths from
   Edk2Path.GetContainingModules() with the original case used by
   the operating system. This allow case sensitive callers to match
   paths returned by the function correctly.

   This can impact flows such as PR Eval that use this function to
   determine which modules were impacted by a code change. Without
   this change PR eval may not return consistent/expected results
   across operating systems.

2. The edk2-pytool-library change requires edk2-pytool-extensions
   0.20.0. For this reason, edk2-pytool-extensions setup.py was
   updated in 0.20.0 to specify 0.12.1 as the edk2-pytool-library
   requirement. The logic of determining a package in pytool-library
   (Edk2Path.GetContainingPackage()) needs a corresponding change in
   the edk2-pytool-extensions 0.20.0 release.

   Without this change, flows such as PR Eval will not have updated
   logic for calling the function and return incorrect results.

These changes have been tested against edk2 in pytool integration
testing, the PR linked above, and against similar code in Mu.

V2 changes:

1. Add stable tag to patch subject
2. Explain why changes should be included in stable tag
3. Add Reviewed-by tags to patches from v1

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (2):
  pip-requirements.txt: Update to edk2-pytool-library 0.12.1
  pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0

 pip-requirements.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.28.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96366): https://edk2.groups.io/g/devel/message/96366
Mute This Topic: https://groups.io/mt/95033514/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] 回复: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
Posted by gaoliming via groups.io 2 weeks, 5 days ago
Michael:
  I have no comments to merge this patch set for the stable tag. 

Thanks
Liming
> -----邮件原件-----
> 发件人: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> 发送时间: 2022年11月15日 8:19
> 收件人: devel@edk2.groups.io
> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Michael Kubacki
> <mikuback@linux.microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>
> 主题: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> 1. Updates edk2-pytool-library to 0.12.1
>    - Picks up a minor bug fix
> 
> 2. Updates edk2-pytool-extensions to 0.20.0
>    - Picks up a major release
> 
> The changes in each update are in the respective patch commit
> messages.
> 
> CI was run against both of these patches in this pull request:
> https://github.com/tianocore/edk2/pull/3632
> 
> These changes are recommended to be included in the edk2-stable202211
> tag for the following reasons:
> 
> 1. edk2-pytool-library 0.12.0 to 0.12.1 includes a single bug fix
>    that simply returns file paths from
>    Edk2Path.GetContainingModules() with the original case used by
>    the operating system. This allow case sensitive callers to match
>    paths returned by the function correctly.
> 
>    This can impact flows such as PR Eval that use this function to
>    determine which modules were impacted by a code change. Without
>    this change PR eval may not return consistent/expected results
>    across operating systems.
> 
> 2. The edk2-pytool-library change requires edk2-pytool-extensions
>    0.20.0. For this reason, edk2-pytool-extensions setup.py was
>    updated in 0.20.0 to specify 0.12.1 as the edk2-pytool-library
>    requirement. The logic of determining a package in pytool-library
>    (Edk2Path.GetContainingPackage()) needs a corresponding change in
>    the edk2-pytool-extensions 0.20.0 release.
> 
>    Without this change, flows such as PR Eval will not have updated
>    logic for calling the function and return incorrect results.
> 
> These changes have been tested against edk2 in pytool integration
> testing, the PR linked above, and against similar code in Mu.
> 
> V2 changes:
> 
> 1. Add stable tag to patch subject
> 2. Explain why changes should be included in stable tag
> 3. Add Reviewed-by tags to patches from v1
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (2):
>   pip-requirements.txt: Update to edk2-pytool-library 0.12.1
>   pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0
> 
>  pip-requirements.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --
> 2.28.0.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96375): https://edk2.groups.io/g/devel/message/96375
Mute This Topic: https://groups.io/mt/95036176/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] 回复: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
Posted by Michael Kubacki 2 weeks, 5 days ago
I would like to elaborate on some of the information in this cover 
letter to better emphasize why this should be included in the 
edk2-stable202211 stable tag.

These releases of edk2-pytool-library and edk2-pytool-extensions must be 
paired together. The edk2-pytool-library release already being used by 
edk2 (0.12.0) requires the edk2-pytool-extensions 0.20.0 release.

The updates in this series should be considered "required" as opposed to 
"recommended" to ensure compatibility in the stable tag release.

The reasoning for updating edk2-pytool-library from 0.12.0 to 0.12.1 is 
straightforward, it fixes the bug described in the cover letter.

The issue with not taking in the 0.20.0 edk2-pytool-extensions update is 
that PR Evaluation, which is used in CI to determine what packages to 
build, will not build the code in some cases causing build failures to 
potentially creep through.

For example, without this update, a PR with a file only changed outside 
a package, such as pip-requirements.txt or a file in .pytool, will not 
trigger a full build to test the change as a file is not modified within 
an edk2 package.

Thanks,
Michael

On 11/14/2022 10:00 PM, gaoliming via groups.io wrote:
> Michael:
>    I have no comments to merge this patch set for the stable tag.
> 
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
>> 发送时间: 2022年11月15日 8:19
>> 收件人: devel@edk2.groups.io
>> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Michael Kubacki
>> <mikuback@linux.microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>> Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>
>> 主题: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> 1. Updates edk2-pytool-library to 0.12.1
>>     - Picks up a minor bug fix
>>
>> 2. Updates edk2-pytool-extensions to 0.20.0
>>     - Picks up a major release
>>
>> The changes in each update are in the respective patch commit
>> messages.
>>
>> CI was run against both of these patches in this pull request:
>> https://github.com/tianocore/edk2/pull/3632
>>
>> These changes are recommended to be included in the edk2-stable202211
>> tag for the following reasons:
>>
>> 1. edk2-pytool-library 0.12.0 to 0.12.1 includes a single bug fix
>>     that simply returns file paths from
>>     Edk2Path.GetContainingModules() with the original case used by
>>     the operating system. This allow case sensitive callers to match
>>     paths returned by the function correctly.
>>
>>     This can impact flows such as PR Eval that use this function to
>>     determine which modules were impacted by a code change. Without
>>     this change PR eval may not return consistent/expected results
>>     across operating systems.
>>
>> 2. The edk2-pytool-library change requires edk2-pytool-extensions
>>     0.20.0. For this reason, edk2-pytool-extensions setup.py was
>>     updated in 0.20.0 to specify 0.12.1 as the edk2-pytool-library
>>     requirement. The logic of determining a package in pytool-library
>>     (Edk2Path.GetContainingPackage()) needs a corresponding change in
>>     the edk2-pytool-extensions 0.20.0 release.
>>
>>     Without this change, flows such as PR Eval will not have updated
>>     logic for calling the function and return incorrect results.
>>
>> These changes have been tested against edk2 in pytool integration
>> testing, the PR linked above, and against similar code in Mu.
>>
>> V2 changes:
>>
>> 1. Add stable tag to patch subject
>> 2. Explain why changes should be included in stable tag
>> 3. Add Reviewed-by tags to patches from v1
>>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Michael Kubacki (2):
>>    pip-requirements.txt: Update to edk2-pytool-library 0.12.1
>>    pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0
>>
>>   pip-requirements.txt | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> --
>> 2.28.0.windows.1
> 
> 
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96377): https://edk2.groups.io/g/devel/message/96377
Mute This Topic: https://groups.io/mt/95036176/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] 回复: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
Posted by Michael D Kinney 2 weeks, 5 days ago
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Approved for edk2-stable202211

Mike

> -----Original Message-----
> From: Michael Kubacki <mikuback@linux.microsoft.com>
> Sent: Monday, November 14, 2022 7:18 PM
> To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] 回复: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
> 
> I would like to elaborate on some of the information in this cover
> letter to better emphasize why this should be included in the
> edk2-stable202211 stable tag.
> 
> These releases of edk2-pytool-library and edk2-pytool-extensions must be
> paired together. The edk2-pytool-library release already being used by
> edk2 (0.12.0) requires the edk2-pytool-extensions 0.20.0 release.
> 
> The updates in this series should be considered "required" as opposed to
> "recommended" to ensure compatibility in the stable tag release.
> 
> The reasoning for updating edk2-pytool-library from 0.12.0 to 0.12.1 is
> straightforward, it fixes the bug described in the cover letter.
> 
> The issue with not taking in the 0.20.0 edk2-pytool-extensions update is
> that PR Evaluation, which is used in CI to determine what packages to
> build, will not build the code in some cases causing build failures to
> potentially creep through.
> 
> For example, without this update, a PR with a file only changed outside
> a package, such as pip-requirements.txt or a file in .pytool, will not
> trigger a full build to test the change as a file is not modified within
> an edk2 package.
> 
> Thanks,
> Michael
> 
> On 11/14/2022 10:00 PM, gaoliming via groups.io wrote:
> > Michael:
> >    I have no comments to merge this patch set for the stable tag.
> >
> > Thanks
> > Liming
> >> -----邮件原件-----
> >> 发件人: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> >> 发送时间: 2022年11月15日 8:19
> >> 收件人: devel@edk2.groups.io
> >> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Michael Kubacki
> >> <mikuback@linux.microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> >> Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>
> >> 主题: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
> >>
> >> From: Michael Kubacki <michael.kubacki@microsoft.com>
> >>
> >> 1. Updates edk2-pytool-library to 0.12.1
> >>     - Picks up a minor bug fix
> >>
> >> 2. Updates edk2-pytool-extensions to 0.20.0
> >>     - Picks up a major release
> >>
> >> The changes in each update are in the respective patch commit
> >> messages.
> >>
> >> CI was run against both of these patches in this pull request:
> >> https://github.com/tianocore/edk2/pull/3632
> >>
> >> These changes are recommended to be included in the edk2-stable202211
> >> tag for the following reasons:
> >>
> >> 1. edk2-pytool-library 0.12.0 to 0.12.1 includes a single bug fix
> >>     that simply returns file paths from
> >>     Edk2Path.GetContainingModules() with the original case used by
> >>     the operating system. This allow case sensitive callers to match
> >>     paths returned by the function correctly.
> >>
> >>     This can impact flows such as PR Eval that use this function to
> >>     determine which modules were impacted by a code change. Without
> >>     this change PR eval may not return consistent/expected results
> >>     across operating systems.
> >>
> >> 2. The edk2-pytool-library change requires edk2-pytool-extensions
> >>     0.20.0. For this reason, edk2-pytool-extensions setup.py was
> >>     updated in 0.20.0 to specify 0.12.1 as the edk2-pytool-library
> >>     requirement. The logic of determining a package in pytool-library
> >>     (Edk2Path.GetContainingPackage()) needs a corresponding change in
> >>     the edk2-pytool-extensions 0.20.0 release.
> >>
> >>     Without this change, flows such as PR Eval will not have updated
> >>     logic for calling the function and return incorrect results.
> >>
> >> These changes have been tested against edk2 in pytool integration
> >> testing, the PR linked above, and against similar code in Mu.
> >>
> >> V2 changes:
> >>
> >> 1. Add stable tag to patch subject
> >> 2. Explain why changes should be included in stable tag
> >> 3. Add Reviewed-by tags to patches from v1
> >>
> >> Cc: Sean Brogan <sean.brogan@microsoft.com>
> >> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> >> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >> Cc: Andrew Fish <afish@apple.com>
> >> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> >> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> >>
> >> Michael Kubacki (2):
> >>    pip-requirements.txt: Update to edk2-pytool-library 0.12.1
> >>    pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0
> >>
> >>   pip-requirements.txt | 4 ++--
> >>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> --
> >> 2.28.0.windows.1
> >
> >
> >
> >
> >
> > 
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96378): https://edk2.groups.io/g/devel/message/96378
Mute This Topic: https://groups.io/mt/95036176/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] 回复: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
Posted by Michael Kubacki 2 weeks, 5 days ago
The pull request is rebased and the commits include all Reviewed-by tags.

https://github.com/tianocore/edk2/pull/3632

Thanks,
Michael

On 11/14/2022 10:45 PM, Michael D Kinney wrote:
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Approved for edk2-stable202211
> 
> Mike
> 
>> -----Original Message-----
>> From: Michael Kubacki <mikuback@linux.microsoft.com>
>> Sent: Monday, November 14, 2022 7:18 PM
>> To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
>> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>;
>> Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: Re: [edk2-devel] 回复: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
>>
>> I would like to elaborate on some of the information in this cover
>> letter to better emphasize why this should be included in the
>> edk2-stable202211 stable tag.
>>
>> These releases of edk2-pytool-library and edk2-pytool-extensions must be
>> paired together. The edk2-pytool-library release already being used by
>> edk2 (0.12.0) requires the edk2-pytool-extensions 0.20.0 release.
>>
>> The updates in this series should be considered "required" as opposed to
>> "recommended" to ensure compatibility in the stable tag release.
>>
>> The reasoning for updating edk2-pytool-library from 0.12.0 to 0.12.1 is
>> straightforward, it fixes the bug described in the cover letter.
>>
>> The issue with not taking in the 0.20.0 edk2-pytool-extensions update is
>> that PR Evaluation, which is used in CI to determine what packages to
>> build, will not build the code in some cases causing build failures to
>> potentially creep through.
>>
>> For example, without this update, a PR with a file only changed outside
>> a package, such as pip-requirements.txt or a file in .pytool, will not
>> trigger a full build to test the change as a file is not modified within
>> an edk2 package.
>>
>> Thanks,
>> Michael
>>
>> On 11/14/2022 10:00 PM, gaoliming via groups.io wrote:
>>> Michael:
>>>     I have no comments to merge this patch set for the stable tag.
>>>
>>> Thanks
>>> Liming
>>>> -----邮件原件-----
>>>> 发件人: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
>>>> 发送时间: 2022年11月15日 8:19
>>>> 收件人: devel@edk2.groups.io
>>>> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Michael Kubacki
>>>> <mikuback@linux.microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>>>> Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>
>>>> 主题: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
>>>>
>>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>
>>>> 1. Updates edk2-pytool-library to 0.12.1
>>>>      - Picks up a minor bug fix
>>>>
>>>> 2. Updates edk2-pytool-extensions to 0.20.0
>>>>      - Picks up a major release
>>>>
>>>> The changes in each update are in the respective patch commit
>>>> messages.
>>>>
>>>> CI was run against both of these patches in this pull request:
>>>> https://github.com/tianocore/edk2/pull/3632
>>>>
>>>> These changes are recommended to be included in the edk2-stable202211
>>>> tag for the following reasons:
>>>>
>>>> 1. edk2-pytool-library 0.12.0 to 0.12.1 includes a single bug fix
>>>>      that simply returns file paths from
>>>>      Edk2Path.GetContainingModules() with the original case used by
>>>>      the operating system. This allow case sensitive callers to match
>>>>      paths returned by the function correctly.
>>>>
>>>>      This can impact flows such as PR Eval that use this function to
>>>>      determine which modules were impacted by a code change. Without
>>>>      this change PR eval may not return consistent/expected results
>>>>      across operating systems.
>>>>
>>>> 2. The edk2-pytool-library change requires edk2-pytool-extensions
>>>>      0.20.0. For this reason, edk2-pytool-extensions setup.py was
>>>>      updated in 0.20.0 to specify 0.12.1 as the edk2-pytool-library
>>>>      requirement. The logic of determining a package in pytool-library
>>>>      (Edk2Path.GetContainingPackage()) needs a corresponding change in
>>>>      the edk2-pytool-extensions 0.20.0 release.
>>>>
>>>>      Without this change, flows such as PR Eval will not have updated
>>>>      logic for calling the function and return incorrect results.
>>>>
>>>> These changes have been tested against edk2 in pytool integration
>>>> testing, the PR linked above, and against similar code in Mu.
>>>>
>>>> V2 changes:
>>>>
>>>> 1. Add stable tag to patch subject
>>>> 2. Explain why changes should be included in stable tag
>>>> 3. Add Reviewed-by tags to patches from v1
>>>>
>>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>>> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
>>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>>> Cc: Andrew Fish <afish@apple.com>
>>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>
>>>> Michael Kubacki (2):
>>>>     pip-requirements.txt: Update to edk2-pytool-library 0.12.1
>>>>     pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0
>>>>
>>>>    pip-requirements.txt | 4 ++--
>>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> --
>>>> 2.28.0.windows.1
>>>
>>>
>>>
>>>
>>>
>>>
>>>
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96401): https://edk2.groups.io/g/devel/message/96401
Mute This Topic: https://groups.io/mt/95036176/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] 回复: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
Posted by Michael D Kinney 2 weeks, 3 days ago
Hi Liming,

Are you waiting for any additional input or approvals to merge this for edk2-stable202211?

Thanks,

Mike

> -----Original Message-----
> From: Michael Kubacki <mikuback@linux.microsoft.com>
> Sent: Tuesday, November 15, 2022 6:36 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>
> Subject: Re: [edk2-devel] 回复: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
> 
> The pull request is rebased and the commits include all Reviewed-by tags.
> 
> https://github.com/tianocore/edk2/pull/3632
> 
> Thanks,
> Michael
> 
> On 11/14/2022 10:45 PM, Michael D Kinney wrote:
> > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Approved for edk2-stable202211
> >
> > Mike
> >
> >> -----Original Message-----
> >> From: Michael Kubacki <mikuback@linux.microsoft.com>
> >> Sent: Monday, November 14, 2022 7:18 PM
> >> To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> >> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm'
> <quic_llindhol@quicinc.com>;
> >> Kinney, Michael D <michael.d.kinney@intel.com>
> >> Subject: Re: [edk2-devel] 回复: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
> >>
> >> I would like to elaborate on some of the information in this cover
> >> letter to better emphasize why this should be included in the
> >> edk2-stable202211 stable tag.
> >>
> >> These releases of edk2-pytool-library and edk2-pytool-extensions must be
> >> paired together. The edk2-pytool-library release already being used by
> >> edk2 (0.12.0) requires the edk2-pytool-extensions 0.20.0 release.
> >>
> >> The updates in this series should be considered "required" as opposed to
> >> "recommended" to ensure compatibility in the stable tag release.
> >>
> >> The reasoning for updating edk2-pytool-library from 0.12.0 to 0.12.1 is
> >> straightforward, it fixes the bug described in the cover letter.
> >>
> >> The issue with not taking in the 0.20.0 edk2-pytool-extensions update is
> >> that PR Evaluation, which is used in CI to determine what packages to
> >> build, will not build the code in some cases causing build failures to
> >> potentially creep through.
> >>
> >> For example, without this update, a PR with a file only changed outside
> >> a package, such as pip-requirements.txt or a file in .pytool, will not
> >> trigger a full build to test the change as a file is not modified within
> >> an edk2 package.
> >>
> >> Thanks,
> >> Michael
> >>
> >> On 11/14/2022 10:00 PM, gaoliming via groups.io wrote:
> >>> Michael:
> >>>     I have no comments to merge this patch set for the stable tag.
> >>>
> >>> Thanks
> >>> Liming
> >>>> -----邮件原件-----
> >>>> 发件人: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> >>>> 发送时间: 2022年11月15日 8:19
> >>>> 收件人: devel@edk2.groups.io
> >>>> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Michael Kubacki
> >>>> <mikuback@linux.microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> >>>> Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>
> >>>> 主题: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
> >>>>
> >>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
> >>>>
> >>>> 1. Updates edk2-pytool-library to 0.12.1
> >>>>      - Picks up a minor bug fix
> >>>>
> >>>> 2. Updates edk2-pytool-extensions to 0.20.0
> >>>>      - Picks up a major release
> >>>>
> >>>> The changes in each update are in the respective patch commit
> >>>> messages.
> >>>>
> >>>> CI was run against both of these patches in this pull request:
> >>>> https://github.com/tianocore/edk2/pull/3632
> >>>>
> >>>> These changes are recommended to be included in the edk2-stable202211
> >>>> tag for the following reasons:
> >>>>
> >>>> 1. edk2-pytool-library 0.12.0 to 0.12.1 includes a single bug fix
> >>>>      that simply returns file paths from
> >>>>      Edk2Path.GetContainingModules() with the original case used by
> >>>>      the operating system. This allow case sensitive callers to match
> >>>>      paths returned by the function correctly.
> >>>>
> >>>>      This can impact flows such as PR Eval that use this function to
> >>>>      determine which modules were impacted by a code change. Without
> >>>>      this change PR eval may not return consistent/expected results
> >>>>      across operating systems.
> >>>>
> >>>> 2. The edk2-pytool-library change requires edk2-pytool-extensions
> >>>>      0.20.0. For this reason, edk2-pytool-extensions setup.py was
> >>>>      updated in 0.20.0 to specify 0.12.1 as the edk2-pytool-library
> >>>>      requirement. The logic of determining a package in pytool-library
> >>>>      (Edk2Path.GetContainingPackage()) needs a corresponding change in
> >>>>      the edk2-pytool-extensions 0.20.0 release.
> >>>>
> >>>>      Without this change, flows such as PR Eval will not have updated
> >>>>      logic for calling the function and return incorrect results.
> >>>>
> >>>> These changes have been tested against edk2 in pytool integration
> >>>> testing, the PR linked above, and against similar code in Mu.
> >>>>
> >>>> V2 changes:
> >>>>
> >>>> 1. Add stable tag to patch subject
> >>>> 2. Explain why changes should be included in stable tag
> >>>> 3. Add Reviewed-by tags to patches from v1
> >>>>
> >>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
> >>>> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> >>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >>>> Cc: Andrew Fish <afish@apple.com>
> >>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> >>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> >>>>
> >>>> Michael Kubacki (2):
> >>>>     pip-requirements.txt: Update to edk2-pytool-library 0.12.1
> >>>>     pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0
> >>>>
> >>>>    pip-requirements.txt | 4 ++--
> >>>>    1 file changed, 2 insertions(+), 2 deletions(-)
> >>>>
> >>>> --
> >>>> 2.28.0.windows.1
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >
> >
> > 
> >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96439): https://edk2.groups.io/g/devel/message/96439
Mute This Topic: https://groups.io/mt/95036176/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


回复: [edk2-devel] 回复: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
Posted by gaoliming via groups.io 2 weeks, 3 days ago
Mike:
  I find this PR meets with some failure, and re-run it. Now, it passes CI and merged. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> 发送时间: 2022年11月17日 5:46
> 收件人: Michael Kubacki <mikuback@linux.microsoft.com>;
> devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Andrew Fish'
> <afish@apple.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>
> 主题: RE: [edk2-devel] 回复: [PATCH edk2-stable202211 v2 0/2] Update
> Pytool PIP Versions
> 
> Hi Liming,
> 
> Are you waiting for any additional input or approvals to merge this for
> edk2-stable202211?
> 
> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: Michael Kubacki <mikuback@linux.microsoft.com>
> > Sent: Tuesday, November 15, 2022 6:36 AM
> > To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Andrew Fish'
> <afish@apple.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>
> > Subject: Re: [edk2-devel] 回复: [PATCH edk2-stable202211 v2 0/2] Update
> Pytool PIP Versions
> >
> > The pull request is rebased and the commits include all Reviewed-by tags.
> >
> > https://github.com/tianocore/edk2/pull/3632
> >
> > Thanks,
> > Michael
> >
> > On 11/14/2022 10:45 PM, Michael D Kinney wrote:
> > > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> > >
> > > Approved for edk2-stable202211
> > >
> > > Mike
> > >
> > >> -----Original Message-----
> > >> From: Michael Kubacki <mikuback@linux.microsoft.com>
> > >> Sent: Monday, November 14, 2022 7:18 PM
> > >> To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> > >> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Andrew Fish'
> <afish@apple.com>; 'Leif Lindholm'
> > <quic_llindhol@quicinc.com>;
> > >> Kinney, Michael D <michael.d.kinney@intel.com>
> > >> Subject: Re: [edk2-devel] 回复: [PATCH edk2-stable202211 v2 0/2]
> Update Pytool PIP Versions
> > >>
> > >> I would like to elaborate on some of the information in this cover
> > >> letter to better emphasize why this should be included in the
> > >> edk2-stable202211 stable tag.
> > >>
> > >> These releases of edk2-pytool-library and edk2-pytool-extensions must
> be
> > >> paired together. The edk2-pytool-library release already being used by
> > >> edk2 (0.12.0) requires the edk2-pytool-extensions 0.20.0 release.
> > >>
> > >> The updates in this series should be considered "required" as opposed to
> > >> "recommended" to ensure compatibility in the stable tag release.
> > >>
> > >> The reasoning for updating edk2-pytool-library from 0.12.0 to 0.12.1 is
> > >> straightforward, it fixes the bug described in the cover letter.
> > >>
> > >> The issue with not taking in the 0.20.0 edk2-pytool-extensions update is
> > >> that PR Evaluation, which is used in CI to determine what packages to
> > >> build, will not build the code in some cases causing build failures to
> > >> potentially creep through.
> > >>
> > >> For example, without this update, a PR with a file only changed outside
> > >> a package, such as pip-requirements.txt or a file in .pytool, will not
> > >> trigger a full build to test the change as a file is not modified within
> > >> an edk2 package.
> > >>
> > >> Thanks,
> > >> Michael
> > >>
> > >> On 11/14/2022 10:00 PM, gaoliming via groups.io wrote:
> > >>> Michael:
> > >>>     I have no comments to merge this patch set for the stable tag.
> > >>>
> > >>> Thanks
> > >>> Liming
> > >>>> -----邮件原件-----
> > >>>> 发件人: mikuback@linux.microsoft.com
> <mikuback@linux.microsoft.com>
> > >>>> 发送时间: 2022年11月15日 8:19
> > >>>> 收件人: devel@edk2.groups.io
> > >>>> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Michael Kubacki
> > >>>> <mikuback@linux.microsoft.com>; Liming Gao
> <gaoliming@byosoft.com.cn>;
> > >>>> Andrew Fish <afish@apple.com>; Leif Lindholm
> <quic_llindhol@quicinc.com>
> > >>>> 主题: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP Versions
> > >>>>
> > >>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
> > >>>>
> > >>>> 1. Updates edk2-pytool-library to 0.12.1
> > >>>>      - Picks up a minor bug fix
> > >>>>
> > >>>> 2. Updates edk2-pytool-extensions to 0.20.0
> > >>>>      - Picks up a major release
> > >>>>
> > >>>> The changes in each update are in the respective patch commit
> > >>>> messages.
> > >>>>
> > >>>> CI was run against both of these patches in this pull request:
> > >>>> https://github.com/tianocore/edk2/pull/3632
> > >>>>
> > >>>> These changes are recommended to be included in the
> edk2-stable202211
> > >>>> tag for the following reasons:
> > >>>>
> > >>>> 1. edk2-pytool-library 0.12.0 to 0.12.1 includes a single bug fix
> > >>>>      that simply returns file paths from
> > >>>>      Edk2Path.GetContainingModules() with the original case used
> by
> > >>>>      the operating system. This allow case sensitive callers to match
> > >>>>      paths returned by the function correctly.
> > >>>>
> > >>>>      This can impact flows such as PR Eval that use this function to
> > >>>>      determine which modules were impacted by a code change.
> Without
> > >>>>      this change PR eval may not return consistent/expected results
> > >>>>      across operating systems.
> > >>>>
> > >>>> 2. The edk2-pytool-library change requires edk2-pytool-extensions
> > >>>>      0.20.0. For this reason, edk2-pytool-extensions setup.py was
> > >>>>      updated in 0.20.0 to specify 0.12.1 as the edk2-pytool-library
> > >>>>      requirement. The logic of determining a package in
> pytool-library
> > >>>>      (Edk2Path.GetContainingPackage()) needs a corresponding
> change in
> > >>>>      the edk2-pytool-extensions 0.20.0 release.
> > >>>>
> > >>>>      Without this change, flows such as PR Eval will not have
> updated
> > >>>>      logic for calling the function and return incorrect results.
> > >>>>
> > >>>> These changes have been tested against edk2 in pytool integration
> > >>>> testing, the PR linked above, and against similar code in Mu.
> > >>>>
> > >>>> V2 changes:
> > >>>>
> > >>>> 1. Add stable tag to patch subject
> > >>>> 2. Explain why changes should be included in stable tag
> > >>>> 3. Add Reviewed-by tags to patches from v1
> > >>>>
> > >>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
> > >>>> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> > >>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > >>>> Cc: Andrew Fish <afish@apple.com>
> > >>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > >>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > >>>>
> > >>>> Michael Kubacki (2):
> > >>>>     pip-requirements.txt: Update to edk2-pytool-library 0.12.1
> > >>>>     pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0
> > >>>>
> > >>>>    pip-requirements.txt | 4 ++--
> > >>>>    1 file changed, 2 insertions(+), 2 deletions(-)
> > >>>>
> > >>>> --
> > >>>> 2.28.0.windows.1
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >
> > >
> > > 
> > >
> > >




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96444): https://edk2.groups.io/g/devel/message/96444
Mute This Topic: https://groups.io/mt/95081856/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-