From nobody Thu Apr 25 02:07:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+96204+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96204+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1668104671; cv=none; d=zohomail.com; s=zohoarc; b=G4h40a2VZPRyw408oJ3Pri3svNYc4W26spsiHjZp7fYo767jmOXrBNW7suwMe8QBQrJXNCz6xSuyNFmihX0D1smwHLEpPOzSKGcgWYPA+Y+3Ou3laAZAvVBieGAGbJL4BQ0U1aCKGPiyA8RFi/qoOjdt44fFi6sBV5sk52Y9M/E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668104671; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=+b4mZ3G/CjiKd8HPeW/EDaxUCrknEhOavkxmErSAG+A=; b=f/8RKYnS9lH23ddkIJQPfRm8KShnuHJrs/ff1ZOrEtvAfv1hZHuXoc7bAEZDnrDmOTsb0ta9Ol70dkRuhI1g2CeDwMQ+vq1BPhDRlzR4veohgQuTYTrQizaMYCizFjKEN8gnXMu7/SfqOIONk4X/f/yRJwXv0xd3fLqO8vPsWQQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96204+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1668104671993597.0299491046064; Thu, 10 Nov 2022 10:24:31 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id z5kXYY1788612xdbkcyAOpSo; Thu, 10 Nov 2022 10:24:31 -0800 X-Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web09.144.1668104669851061615 for ; Thu, 10 Nov 2022 10:24:30 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="338156140" X-IronPort-AV: E=Sophos;i="5.96,154,1665471600"; d="scan'208";a="338156140" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 10:24:28 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="762383331" X-IronPort-AV: E=Sophos;i="5.96,154,1665471600"; d="scan'208";a="762383331" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.209.15.181]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 10:24:27 -0800 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Ray Ni , Rangasai V Chaganty , Isaac Oram , Ashraf Ali S Subject: [edk2-devel] [Patch edk2-platforms] IntelSiliconPkg/IntelVTdDxe: Fix CLANG detected incorrect return Date: Thu, 10 Nov 2022 10:24:21 -0800 Message-Id: <20221110182421.130-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com X-Gm-Message-State: uTWf1KE7cBS21rfkhzjt1Oe7x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1668104671; bh=rAebph1DR5j1cvFBet1swR9TqM7TPTabEpd2lvksaTk=; h=Cc:Date:From:Reply-To:Subject:To; b=P/ngZU9DOg17oHCDRu6tXDuca57JXoPWRipUva3InbTp7FXV+Zq03r/2ZJ0Nef6H4vK 9zDnHqvjUNHW7hOIzXUu8ovPt8m1hLwBDf0rYRwF4MhAjI2IfCdQ9oq8GguEM1+FD0BqH Nj6mR5bSTn9zbfopbEgMfQEYHqlWpJYbtsw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1668104673696100002 Content-Type: text/plain; charset="utf-8" CreateSecondLevelPagingEntryTable() has a return type of VTD_SECOND_LEVEL_PAGING_ENTRY * and an error condition returns a value of NULL. Change return value of EFI_SUCCESS (value 0) to NULL to address CLANG compiler detection of incorrect return type. Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Isaac Oram Cc: Ashraf Ali S Signed-off-by: Michael D Kinney Reviewed-by: S, Ashraf Ali Reviewed-by: Sai Chaganty --- .../IntelSiliconPkg/Feature/VTd/IntelVTdDxe/TranslationTable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/Translat= ionTable.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/Translat= ionTable.c index 3220789080..6788c86531 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/TranslationTabl= e.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/TranslationTabl= e.c @@ -196,7 +196,7 @@ CreateSecondLevelPagingEntryTable ( UINT64 EndAddress; =20 if (MemoryLimit =3D=3D 0) { - return EFI_SUCCESS; + return NULL; } =20 Lvl4PagesStart =3D 0; --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96204): https://edk2.groups.io/g/devel/message/96204 Mute This Topic: https://groups.io/mt/94942403/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-