From nobody Fri Dec 19 20:14:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+96154+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96154+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1668015211; cv=none; d=zohomail.com; s=zohoarc; b=Y2EgzvlUb/a9ggewutffH7TXe6n+AVwWXPsJwpUoqBhL3OcX3HrzcYiV1Nez5wjdIXGNATCFXQx/WRbAKMlUIBkmI4LNFTQGYyFEr16gJIVbe1Op5G9uSDqmjeg0Ab8PkZm/28jUqVR/+n8vDvvY0hAr86iR6FZqe5iud34+iXU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668015211; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=c2RnlnUVCoRbeGYBfmGOLsJH5xP8BdAUbCADvnXVHoE=; b=ir+XEjv4UbXP0MxzomLkKNLCprpKCFCHd2xYvjnlYiPrsF17BziI8UzpbykuTmnxUC6wAHeSN2d2EoZ0Q1RtNqQY8woxnzm8OCHG7jzoNG98C5p6WFYb2wI8yec+z7aS2aK8HchUfZDREDEJoMGybxxarVXdGuJGSgoaWPAjxjo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96154+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1668015211079650.5864369641133; Wed, 9 Nov 2022 09:33:31 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 825jYY1788612xM7GvGbKrqn; Wed, 09 Nov 2022 09:33:30 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.94.1668015209565223730 for ; Wed, 09 Nov 2022 09:33:29 -0800 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 94758205DC22; Wed, 9 Nov 2022 09:33:28 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 94758205DC22 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Erich McMillan , Michael D Kinney , Michael Kubacki , Ray Ni Subject: [edk2-devel] [PATCH v1 08/12] PcAtChipsetPkg: Fix conditionally uninitialized variables Date: Wed, 9 Nov 2022 12:32:42 -0500 Message-Id: <20221109173246.174-9-mikuback@linux.microsoft.com> In-Reply-To: <20221109173246.174-1-mikuback@linux.microsoft.com> References: <20221109173246.174-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: 1ZktZmW30AtvcVHkNNVtevmJx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1668015210; bh=pAmPzdCVPJ8TJYjMzEppE0VrWJS/1pjlbCDDVkeR5tw=; h=Cc:Date:From:Reply-To:Subject:To; b=bLvJmMZv+fmAYQ6XFctQ7V8acRaVV7U8JPjGXEYVhfzGHu3N/9MOhiRJwlgZQu8g6XT Vg1clcEF13y+/bkbJO4an8y3YoqWSzh2heLO4gTPL9WUawvfLo+0evTG412escYprURv/ fdJ4QINB3VjfstWF2bsBtbx2CHqScBu6y6E= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1668015212199100009 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki Fixes CodeQL alerts for CWE-457: https://cwe.mitre.org/data/definitions/457.html Cc: Erich McMillan Cc: Michael D Kinney Cc: Michael Kubacki Cc: Ray Ni Co-authored-by: Erich McMillan Signed-off-by: Michael Kubacki Reviewed-by: Michael D Kinney Reviewed-by: Ray Ni --- PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c b/PcAtChips= etPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c index 9242a2e82600..57ea3153aa6b 100644 --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c @@ -344,7 +344,7 @@ PcRtcInit ( // so we can use them to get and set wakeup time. // Status =3D PcRtcGetWakeupTime (&Enabled, &Pending, &Time, Global); - if ((Enabled) || (!EFI_ERROR (Status))) { + if ((!EFI_ERROR (Status)) || (Enabled)) { return EFI_SUCCESS; } =20 @@ -836,8 +836,11 @@ PcRtcSetWakeupTime ( // // Just support set alarm time within 24 hours // - PcRtcGetTime (&RtcTime, &Capabilities, Global); - Status =3D RtcTimeFieldsValid (&RtcTime); + Status =3D PcRtcGetTime (&RtcTime, &Capabilities, Global); + if (!EFI_ERROR (Status)) { + Status =3D RtcTimeFieldsValid (&RtcTime); + } + if (EFI_ERROR (Status)) { return EFI_DEVICE_ERROR; } --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96154): https://edk2.groups.io/g/devel/message/96154 Mute This Topic: https://groups.io/mt/94918099/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-