From nobody Fri Apr 19 06:43:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+96134+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96134+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1668006681; cv=none; d=zohomail.com; s=zohoarc; b=JOLbnkl5YOeUtgQYbAVO3w2u9yIWvbW6BPdXmQXct3FCs1e5vUB667Um8z8k6j+3qjpw7RLaGJl4QSNIkBlWNbnK212d2eOXiUhVGzbYqZJd8RSN+XJq54dB1qhBa2VMtvMpC9X8Siv8XtAkwVNCL6dchAEODi+B+etEMzvqOSA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668006681; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=K6LHxlU7yuWMD6VVu2Xn/LjVlLpQHiUiO6Dw+jYyJ5s=; b=dNRKMMP1Ypb9mU7yEU2gB0g7WzsZ8BvHlWx9wgUuB3Mppua7JTXjcdUVuEyL3PtbyZsGI4e4WfVi7HtYYXqH6Xz+MGH7PYpBVzvmxkGgChDsT+A81NK5G1cMMPJpEapDM/aLctfzk5DsZzjtRwAIZYy76Rnnc2BLL3nktctUXyk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+96134+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1668006681172920.2118621523595; Wed, 9 Nov 2022 07:11:21 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id FbhUYY1788612xNC2TKfJIiM; Wed, 09 Nov 2022 07:11:19 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.4430.1668006678810193585 for ; Wed, 09 Nov 2022 07:11:18 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 79CDD11FB; Wed, 9 Nov 2022 07:11:24 -0800 (PST) X-Received: from beelzebub.ast.arm.com (u203013-lin.austin.arm.com [10.118.30.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3970A3F73D; Wed, 9 Nov 2022 07:11:18 -0800 (PST) From: "Sam Kaynor" To: devel@edk2.groups.io Cc: Sam Kaynor , Leif Lindholm , Ard Biesheuvel , Sami Mujawar Subject: [edk2-devel] [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values Date: Wed, 9 Nov 2022 09:10:36 -0600 Message-Id: <20221109151036.2164337-2-sam.kaynor@arm.com> In-Reply-To: <20221109151036.2164337-1-sam.kaynor@arm.com> References: <20221109151036.2164337-1-sam.kaynor@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sam.kaynor@arm.com X-Gm-Message-State: 2BhjeMNeS528zIDbSsua4JCOx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1668006679; bh=yCf4+LM6gwR22pypA8dIyboy5IrygIi4wO+wCQr099Q=; h=Cc:Date:From:Reply-To:Subject:To; b=deEFj9HlMwoXU3bLIhHXa5GLByFz4GADzjnKAVm/0ubdegsbpN+2D+0vsXji67WEerk JJekYPcJ97wnWmtyt+w9zYh8n1IJkY/S4UbTiEC4lSyRXFXgNEucpo9YgTfebgwB3Ev2D AwdT0Xe8A98cnSxHJQFsLtmXs1MEqOGQxLA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1668006682719100001 Content-Type: text/plain; charset="utf-8" Current default value for DMI tables in uni files is "Not Specified". This causes an error when running FWTS tests. To avoid these errors, and align more accurately with the SMBIOS spec, this value should be changed to "". Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Sam Kaynor Reviewed-by: Rebecca Cran Reviewed-by: Sunny Wang --- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni = | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni = | 8 ++++---- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni = | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni= | 14 +++++++------- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni = | 10 +++++----- 5 files changed, 28 insertions(+), 28 deletions(-) diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass= Strings.uni b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClas= sStrings.uni index 22b3c64d9fe2..a86695ea3e29 100644 --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings= .uni +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings= .uni @@ -15,10 +15,10 @@ // // Processor Information // -#string STR_PROCESSOR_SOCKET_DESIGNATION #language en-US "Not Specifie= d" -#string STR_PROCESSOR_MANUFACTURE #language en-US "Not Specifie= d" -#string STR_PROCESSOR_VERSION #language en-US "Not Specifie= d" -#string STR_PROCESSOR_SERIAL_NUMBER #language en-US "Not Specifie= d" -#string STR_PROCESSOR_ASSET_TAG #language en-US "Not Specifie= d" -#string STR_PROCESSOR_PART_NUMBER #language en-US "Not Specifie= d" +#string STR_PROCESSOR_SOCKET_DESIGNATION #language en-US "" +#string STR_PROCESSOR_MANUFACTURE #language en-US "" +#string STR_PROCESSOR_VERSION #language en-US "" +#string STR_PROCESSOR_SERIAL_NUMBER #language en-US "" +#string STR_PROCESSOR_ASSET_TAG #language en-US "" +#string STR_PROCESSOR_PART_NUMBER #language en-US "" #string STR_PROCESSOR_UNKNOWN #language en-US "Unknown" diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.un= i b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni index a3f068cdcca2..6f1c360c0aaf 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni @@ -11,8 +11,8 @@ =20 /=3D# =20 -#string STR_MISC_BIOS_VENDOR #language en-US "Not Specified" -#string STR_MISC_BIOS_VERSION #language en-US "Not Specified" -#string STR_MISC_BIOS_RELEASE_DATE #language en-US "Not Specified" -#string STR_MISC_BIOS_VENDOR #language en-US "Not Specified" +#string STR_MISC_BIOS_VENDOR #language en-US "" +#string STR_MISC_BIOS_VERSION #language en-US "" +#string STR_MISC_BIOS_RELEASE_DATE #language en-US "" +#string STR_MISC_BIOS_VENDOR #language en-US "" #string STR_MISC_BIOS_RELEASE_DATE #language en-US "12/02/2020" diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufac= turer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufact= urer.uni index 2b3b19cab2ea..d8f73a3ffc74 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.u= ni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.u= ni @@ -11,9 +11,9 @@ =20 /=3D# =20 -#string STR_MISC_SYSTEM_MANUFACTURER #language en-US "Not Specified" -#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "Not Specified" -#string STR_MISC_SYSTEM_VERSION #language en-US "Not Specified" -#string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US "Not Specified" -#string STR_MISC_SYSTEM_SKU_NUMBER #language en-US "Not Specified" -#string STR_MISC_SYSTEM_FAMILY #language en-US "Not Specified" +#string STR_MISC_SYSTEM_MANUFACTURER #language en-US "" +#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "" +#string STR_MISC_SYSTEM_VERSION #language en-US "" +#string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US "" +#string STR_MISC_SYSTEM_SKU_NUMBER #language en-US "" +#string STR_MISC_SYSTEM_FAMILY #language en-US "" diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManu= facturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardMa= nufacturer.uni index 0f0fb1f93bbb..9f36e5ff1998 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= r.uni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= r.uni @@ -11,10 +11,10 @@ =20 /=3D# =20 -#string STR_MISC_BASE_BOARD_MANUFACTURER #language en-US "Not Specifi= ed" -#string STR_MISC_BASE_BOARD_PRODUCT_NAME #language en-US "Not Specifi= ed" -#string STR_MISC_BASE_BOARD_VERSION #language en-US "Not Specifi= ed" -#string STR_MISC_BASE_BOARD_SERIAL_NUMBER #language en-US "Not Specifi= ed" -#string STR_MISC_BASE_BOARD_ASSET_TAG #language en-US "Not Specifi= ed" -#string STR_MISC_BASE_BOARD_CHASSIS_LOCATION #language en-US "Not Specifi= ed" -#string STR_MISC_BASE_BOARD_SKU_NUMBER #language en-US "Not Specifi= ed" +#string STR_MISC_BASE_BOARD_MANUFACTURER #language en-US "" +#string STR_MISC_BASE_BOARD_PRODUCT_NAME #language en-US "" +#string STR_MISC_BASE_BOARD_VERSION #language en-US "" +#string STR_MISC_BASE_BOARD_SERIAL_NUMBER #language en-US "" +#string STR_MISC_BASE_BOARD_ASSET_TAG #language en-US "" +#string STR_MISC_BASE_BOARD_CHASSIS_LOCATION #language en-US "" +#string STR_MISC_BASE_BOARD_SKU_NUMBER #language en-US "" diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufa= cturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufa= cturer.uni index 9512b354fe9a..77cbe27d8f7a 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.= uni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.= uni @@ -11,8 +11,8 @@ =20 /=3D# =20 -#string STR_MISC_CHASSIS_MANUFACTURER #language en-US "Not Specified" -#string STR_MISC_CHASSIS_VERSION #language en-US "Not Specified" -#string STR_MISC_CHASSIS_SERIAL_NUMBER #language en-US "Not Specified" -#string STR_MISC_CHASSIS_ASSET_TAG #language en-US "Not Specified" -#string STR_MISC_CHASSIS_SKU_NUMBER #language en-US "Not Specified" +#string STR_MISC_CHASSIS_MANUFACTURER #language en-US "" +#string STR_MISC_CHASSIS_VERSION #language en-US "" +#string STR_MISC_CHASSIS_SERIAL_NUMBER #language en-US "" +#string STR_MISC_CHASSIS_ASSET_TAG #language en-US "" +#string STR_MISC_CHASSIS_SKU_NUMBER #language en-US "" --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96134): https://edk2.groups.io/g/devel/message/96134 Mute This Topic: https://groups.io/mt/94914659/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-