From nobody Tue Feb 10 15:29:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+95994+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95994+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1667720148; cv=none; d=zohomail.com; s=zohoarc; b=Nktd9Rsm2H8ulafsXunkoPZDG73agNR0V0DsSiV3cT97/GSxUrpt/1Mah5hzecRb4jv7KnM2oTOwrYXLqOIxhCR7k/pkMtMUjEX8FGsFeHLo2SB6X39f3F6RBYraJT4XtfqlCsjJUJgsaWtmtiLGYbfNIp54/SBuMk8NXW1PrDA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1667720148; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=uvPRhbsbct3AMgnN14SHkPTlu4apTJS56vTUsD/diR8=; b=I2emyDnw04A9vAMWxXDTdkblusRk6+OiuyvIuC+SydEpb3u7sByFIbS8zSNYxC3+/mq0JKOz0SHOFVhUR9J56UQS3lAJ8Z4RIHJvRAhmOnWaeHcL6j2qc61IgM8R/3lsvQW8Wwz4HdqeHgiNS49pxi91+oxKr4BwXT/QG4qjr/w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95994+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1667720148491174.08480799020572; Sun, 6 Nov 2022 00:35:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id egypYY1788612xZ3Wc1ek5wL; Sun, 06 Nov 2022 00:35:47 -0700 X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.14307.1667720143790244062 for ; Sun, 06 Nov 2022 00:35:44 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10522"; a="396534277" X-IronPort-AV: E=Sophos;i="5.96,142,1665471600"; d="scan'208";a="396534277" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2022 00:35:31 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10522"; a="810513476" X-IronPort-AV: E=Sophos;i="5.96,142,1665471600"; d="scan'208";a="810513476" X-Received: from jvang-mobl.amr.corp.intel.com ([10.209.139.244]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2022 00:35:31 -0700 From: "Judah Vang" To: devel@edk2.groups.io Cc: Jian J Wang , Jiewen Yao , Nishant C Mistry Subject: [edk2-devel] [PATCH v5 14/19] SecurityPkg: Fix GetVariableKey API Date: Sun, 6 Nov 2022 00:35:04 -0700 Message-Id: <20221106073509.3071-15-judah.vang@intel.com> In-Reply-To: <20221106073509.3071-1-judah.vang@intel.com> References: <20221106073509.3071-1-judah.vang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,judah.vang@intel.com X-Gm-Message-State: I7ZEkkp45l1yxbKRQhjJtJ6cx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1667720147; bh=bpjzz4jw7YJIoIHnqnR/wfrH6fcOln4pB+Mq2Tjt30A=; h=Cc:Date:From:Reply-To:Subject:To; b=dnPTbkN1lCWyHSpJt1JHZ6rdQKcb6Pe2xIVGkQz8CcbOMCC1TX0Gl424AWvwnCaUgGN wIEHZx2qNnOPTarpe0wrf+d8n9xPAR+e6UmiqWI+Ablo73/Cc6iv5B2VRbEgZc2NJifHW uO1fBnoA2sQB2K5csPlrYDF2bLA4Z5zPQC4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1667720148863100040 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2594 V4: Applied code review - function comments need to match function prototype. V1: Fix GetVariableKey API to match changes in header files. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c b/= SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c index a08def767b5f..2cf4b3cbf9f6 100644 --- a/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c +++ b/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c @@ -1,7 +1,7 @@ /** @file Null version of VariableKeyLib for build purpose. Don't use it in real p= roduct. =20 -Copyright (c) 2020, Intel Corporation. All rights reserved.
+Copyright (c) 2020 - 2022, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent Retrieves the key for integrity and/or confidentiality of variables. =20 @param[out] VariableKey A pointer to pointer for the variabl= e key buffer. - @param[in,out] VariableKeySize The size in bytes of the variable ke= y. + @param[in] VariableKeySize The size in bytes of the variable ke= y. =20 @retval EFI_SUCCESS The variable key was returned. @retval EFI_DEVICE_ERROR An error occurred while attempting= to get the variable key. @@ -22,8 +22,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent EFI_STATUS EFIAPI GetVariableKey ( - OUT VOID **VariableKey, - IN OUT UINTN *VariableKeySize + OUT VOID *VariableKey, + IN UINTN VariableKeySize ) { ASSERT (FALSE); --=20 2.35.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95994): https://edk2.groups.io/g/devel/message/95994 Mute This Topic: https://groups.io/mt/94840830/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-