From nobody Tue Feb 10 05:42:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+95701+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95701+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1666971249; cv=none; d=zohomail.com; s=zohoarc; b=cyBT/HCrwJCeyNv7sntxiugsdBHaOzgSKEhh78QVOZX0mrgn5D0zzd24LQr9Ryi9eejgtkyLSwBOSzK6Gvga3bq9GVIkd6YdAzWCM7sERpwFns4Mnpmu4ycWTyWDrIizp5Qt5ybktGRodmIUKVuQFFuRDLHTRyguX6E5mZbLRiw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666971249; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=+Ri2QfIgGqKDzQZr+A7ffVeX1DRkmtztVZyK03sHnKk=; b=YfFWlFG3msw3EwgvFcfHrsKovhgvoKjKdWbTQeXWVvmqf9EI9gfPv8AoqY0bHl8yt1QHASubzyFYP229rXAvdM245ihVhDmhkEm81NATHhyiukTEQWipfeDO9v1AA+BHEW8aSIXOBNYnHV9s5Pv74MPT8xwjlVXXMFkHDSqTFpk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95701+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1666971249183407.87964502943043; Fri, 28 Oct 2022 08:34:09 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id rnnZYY1788612xFV4vnOdNk2; Fri, 28 Oct 2022 08:34:05 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.911.1666971243518031733 for ; Fri, 28 Oct 2022 08:34:03 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7155C1FB; Fri, 28 Oct 2022 08:34:09 -0700 (PDT) X-Received: from pierre123.arm.com (unknown [10.57.3.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 082C23F534; Fri, 28 Oct 2022 08:34:00 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar , Leif Lindholm , Ard Biesheuvel , Rebecca Cran , Michael D Kinney , Liming Gao , Jiewen Yao , Jian J Wang Subject: [edk2-devel] [PATCH v9 16/19] SecurityPkg/RngDxe: Add debug warning for NULL PcdCpuRngSupportedAlgorithm Date: Fri, 28 Oct 2022 17:32:56 +0200 Message-Id: <20221028153259.397445-17-Pierre.Gondois@arm.com> In-Reply-To: <20221028153259.397445-1-Pierre.Gondois@arm.com> References: <20221028153259.397445-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 0jOw2vQbFxeF9f53kU4q1kk6x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1666971245; bh=Bpegb3cqlx4hM7kG/d/Ro9viyeMmsMcVUY2C7PcGKSk=; h=Cc:Date:From:Reply-To:Subject:To; b=iBzee/dWkDyf3YNOOBzDiATmdq1EihoQrDPxQGSdsNLwDis7u5FpUmaUd/hvY0zU1d4 6pwv+uHxFfd0qHGSNN05zgumBW5Gs/iMT4JYADqRsuw2Ev5OMKxid6meZ9Qa3dv40OpaM aSzeIou6fhxcoQsd3WfYN8PtouYbQFErMSA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1666971251275100007 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois PcdCpuRngSupportedAlgorithm should allow to identify the the algorithm used by the RNDR CPU instruction to generate a random number. Add a debug warning if the Pcd is not set. Signed-off-by: Pierre Gondois --- .../RandomNumberGenerator/RngDxe/AArch64/RngDxe.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c b/Se= curityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c index ceddc8f08a45..318876d69330 100644 --- a/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c +++ b/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c @@ -67,6 +67,16 @@ GetAvailableAlgorithms ( sizeof (EFI_RNG_ALGORITHM) ); mAvailableAlgoArrayCount++; + + DEBUG_CODE_BEGIN (); + if (IsZeroGuid (PcdGetPtr (PcdCpuRngSupportedAlgorithm))) { + DEBUG (( + DEBUG_WARN, + "PcdCpuRngSupportedAlgorithm should be a non-zero GUID\n" + )); + } + + DEBUG_CODE_END (); } =20 // Raw algorithm (Trng) --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95701): https://edk2.groups.io/g/devel/message/95701 Mute This Topic: https://groups.io/mt/94629269/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-