From nobody Sun May 5 17:19:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+95662+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95662+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1666925922; cv=none; d=zohomail.com; s=zohoarc; b=dqrp8kXB00vB8y6qcC+ZnyNy8soeXoERO+vSJR5BbrRcQdrDKcWl3wyVEsjyQ0+5mu/ttkKCNE8BmK4nrgk40cORaiCQKuHcGLv6j4Fp9GgUELWZF/nSB5BWYtCetj93P5v00XaWXlanIl4wbiHKEum3Rk4WcRBHr5WoSAVEaZs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666925922; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=BBTJQCt5x55Sf+zQTM2pM9g7hHnbvZHWoaQKB+YOxhA=; b=dT+2EsZFhWRMvV1UdLIWgw9MIAxm2RrpNLHY34zA1Ze1l2xjjROrVfAQgbVktsgkh0QfVCZRd4tab/IOmeVtGlYzKRoQGgvat4JAI3n7kkW3B0H3jbXYSRRIQRUoHt38aTCh2i7kI6Ex8mg9OjyTz3ubGvn7zF1fC7w9W1zErj8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95662+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 166692592280029.238871953289504; Thu, 27 Oct 2022 19:58:42 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id r41mYY1788612xPIGyidYRgN; Thu, 27 Oct 2022 19:58:42 -0700 X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.2172.1666925921569295620 for ; Thu, 27 Oct 2022 19:58:41 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="394708938" X-IronPort-AV: E=Sophos;i="5.95,219,1661842800"; d="scan'208";a="394708938" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 19:58:40 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="696056774" X-IronPort-AV: E=Sophos;i="5.95,219,1661842800"; d="scan'208";a="696056774" X-Received: from cchiu4-mobl.gar.corp.intel.com ([10.251.7.172]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 19:58:40 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: Update Function header to support IA32/X64. Date: Thu, 27 Oct 2022 19:58:29 -0700 Message-Id: <20221028025829.1033-1-chasel.chiu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com X-Gm-Message-State: NH2NxK6ASwa5lhk8UfGDPj93x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1666925922; bh=OrW3eKZJh2/7QGCNp3/efoQDNLULq5W+P82Ttu2a+AY=; h=Cc:Date:From:Reply-To:Subject:To; b=mSaw01LjniYWX6Fnt9HyZsb21wDNkP/ryvR8eA7PThxoUgdz4B56LSRItxDn33108kW BfT4vPtymtlvkWKlSfWwLiR0OipMorodwH4vtExexXT5OxrTtDBUMbPggA5dXckZmBnsr Sq5tqjGxFXH5mR8aEvKEOMMFitfNev8W3RA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1666925923169100001 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4126 Common functions will have either 32bit or 64bit instances which having different return code size. Function header should support both scenarios. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu Reviewed-by: Nate DeSimone --- IntelFsp2Pkg/FspSecCore/SecFsp.h | 4 ++-- IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/IntelFsp2Pkg/FspSecCore/SecFsp.h b/IntelFsp2Pkg/FspSecCore/Sec= Fsp.h index e84528b378..d7a5976c12 100644 --- a/IntelFsp2Pkg/FspSecCore/SecFsp.h +++ b/IntelFsp2Pkg/FspSecCore/SecFsp.h @@ -70,7 +70,7 @@ FspDataPointerFixUp ( @return FSP binary base address. =20 **/ -UINT32 +UINTN EFIAPI AsmGetFspBaseAddress ( VOID @@ -82,7 +82,7 @@ AsmGetFspBaseAddress ( @return FSP binary base address. =20 **/ -UINT32 +UINTN EFIAPI AsmGetFspInfoHeader ( VOID diff --git a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h b/IntelFsp2Pk= g/Include/Library/FspSecPlatformLib.h index c91ea4a78f..598fdb9ec5 100644 --- a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h +++ b/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h @@ -17,10 +17,10 @@ The callee should not use XMM6/XMM7. The return address is saved in MM7. =20 - @retval in saved in EAX - 0 means platform initialization success. + @retval in saved in EAX/RAX - 0 means platform initialization success. other means platform initialization fail. **/ -UINT32 +UINTN EFIAPI SecPlatformInit ( VOID @@ -37,10 +37,10 @@ SecPlatformInit ( =20 @param[in] FsptUpdDataPtr Address pointer to the FSPT_UPD data struc= ture. It is saved in ESP. =20 - @retval in saved in EAX - 0 means Microcode is loaded successfully. + @retval in saved in EAX/RAX - 0 means Microcode is loaded successfully. other means Microcode is not loaded successful= ly. **/ -UINT32 +UINTN EFIAPI LoadMicrocode ( IN VOID *FsptUpdDataPtr @@ -56,10 +56,10 @@ LoadMicrocode ( =20 @param[in] FsptUpdDataPtr Address pointer to the FSPT_UPD data struc= ture. It is saved in ESP. =20 - @retval in saved in EAX - 0 means CAR initialization success. + @retval in saved in EAX/RAX - 0 means CAR initialization success. other means CAR initialization fail. **/ -UINT32 +UINTN EFIAPI SecCarInit ( IN VOID *FsptUpdDataPtr --=20 2.35.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95662): https://edk2.groups.io/g/devel/message/95662 Mute This Topic: https://groups.io/mt/94619463/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-