From nobody Sat Feb 7 08:02:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+95104+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95104+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1665584206; cv=none; d=zohomail.com; s=zohoarc; b=Zf+oS1NSZbVTwT8N08NlQH56Ck5BM0mmZU5F3b0CpMVrajh4cPzeF9nX7nikIH7pXiredYqxlLZbiErTql3voEMrgvjQhqu486uz7p/HCGMn7GctO7BIfmCCqxQAHRF8pm98NBwQaneBoDOxbISl6iihlRIvvNcxdMBsbfhlY00= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665584206; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=1Qdi9axccHXnn0xbUp1hdR7TcGO3elx10DWRtonB2f8=; b=RpEh1R900NQxl27ssd5xgh6w6x1nBPDMBT16tdWT8LfFaLsws9CZLU9q9pjtWaDB0DPENA8UOT2JslpB5/YbqtOjLp7nzNBpFFNV65q5au6yp5XzWduHfM4emaSm2ffhxEtd4lAWd9d8u642K+u3fvZqen/abMrUoOIpfILm23A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95104+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1665584206666142.81268860499313; Wed, 12 Oct 2022 07:16:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id dEbwYY1788612xDOW1pVdcuT; Wed, 12 Oct 2022 07:16:45 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.20541.1665584199794430971 for ; Wed, 12 Oct 2022 07:16:39 -0700 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id D240B20F0F67; Wed, 12 Oct 2022 07:16:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D240B20F0F67 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Sai Chaganty , Nate DeSimone , Heng Luo Subject: [edk2-devel] [edk2-platforms][PATCH v2 3/3] TigerlakeSiliconPkg: Fix invalid debug macros Date: Wed, 12 Oct 2022 10:16:10 -0400 Message-Id: <20221012141610.668-4-mikuback@linux.microsoft.com> In-Reply-To: <20221012141610.668-1-mikuback@linux.microsoft.com> References: <20221012141610.668-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: ZntPNdKqDNp8sNmJNnb4z5BMx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1665584205; bh=oJ7SNGRY2Ryz8gzoPi2/tbdqq6d7VSJa3ckPy/Zs504=; h=Cc:Date:From:Reply-To:Subject:To; b=NM+0RsqBh1kTDNZ7kMoDkIsOgILzgLUrV/z3J5KWOPmckxJW46e4YklcceEdTXUd5J4 h6eQOKUE7AgSpU64gcWZkjsM12nREey0nZwVMQPIrrzHzEnwwB4ye3eCP3rg9jdqa4gqn LUt4vltLEPy9EmrNakPWK75iuzh/UKkVGt0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1665584208037100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4095 Updates several debug macros in TigerlakeSiliconPkg to correctly match print specifiers to actual arguments. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Michael Kubacki --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSmmGbeM= diLib/GbeMdiLib.c | 2 +- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpress= HelpersLibrary/PciExpressHelpersLibrary.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/P= eiDxeSmmGbeMdiLib/GbeMdiLib.c b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/G= be/LibraryPrivate/PeiDxeSmmGbeMdiLib/GbeMdiLib.c index 791747440662..71361a88272f 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSm= mGbeMdiLib/GbeMdiLib.c +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSm= mGbeMdiLib/GbeMdiLib.c @@ -323,7 +323,7 @@ GbeMdiGetLanPhyRevision ( Status =3D EFI_DEVICE_ERROR; goto phy_exit; } - DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. = Overriding LANPHYPC\n", Status)); + DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. = Overriding LANPHYPC. Status: %r\n", Status)); // // Taking over LANPHYPC // 1. SW signal override - 1st cycle. diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivat= e/PciExpressHelpersLibrary/PciExpressHelpersLibrary.c b/Silicon/Intel/Tiger= lakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpressHelpersLibrary/PciEx= pressHelpersLibrary.c index 401a9fbe7b8a..0dfe019d70f9 100644 --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciEx= pressHelpersLibrary/PciExpressHelpersLibrary.c +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciEx= pressHelpersLibrary/PciExpressHelpersLibrary.c @@ -1227,7 +1227,7 @@ RecursiveIoApicCheck ( IoApicPresent =3D FALSE; =20 if (IsIoApicDevice (SbdfToBase (Sbdf))) { - DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev, = Sbdf.Func)); + DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Seg, Sbdf.Bus, = Sbdf.Dev, Sbdf.Func)); return TRUE; } if (HasChildBus (Sbdf, &ChildSbdf)) { --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95104): https://edk2.groups.io/g/devel/message/95104 Mute This Topic: https://groups.io/mt/94281683/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-