From nobody Sat Feb 7 08:02:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+95103+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95103+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1665584198; cv=none; d=zohomail.com; s=zohoarc; b=McuAGn/4aMaTx9TsFDByTmMWQWZPvOK8ynQRD/228t1o6ul7eKTArsx3/QRX6dRDZFANJLhGWnZfpxqbghwTSRKljtIe/n/JJKozigoVseyYhK3OHbnAhN0e92iMqbU1/pozWuyYYHwcpobLE/SXQpGxjrrDOZln8PofwaO2UOg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665584198; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Kf3syTUYPVRwxGeMSlk1SKW2L2vlMldKcFyKCdDwWAc=; b=nw9mrqRUdUuGZgGNwhzQSyLN8GkTEi85FJup37Avr/UMiUMID5aW+joDOU4DByqH+dbnD2NrUzzy0ZdnyUv+cmeqrtLzumbVrExEA7pYhAgQMiDCuge3UcoXXb5KfahVgnY8Ukkn7QCkTIgbJaxSXLAfNy7R+sDwa8yPYpOgJCA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95103+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 166558419821478.09192351396689; Wed, 12 Oct 2022 07:16:38 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ULiFYY1788612x2Nysql1zdM; Wed, 12 Oct 2022 07:16:37 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.20672.1665584197007975174 for ; Wed, 12 Oct 2022 07:16:37 -0700 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 1E79120F0F63; Wed, 12 Oct 2022 07:16:36 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1E79120F0F63 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Sai Chaganty , Nate DeSimone Subject: [edk2-devel] [edk2-platforms][PATCH v2 2/3] KabylakeSiliconPkg: Fix invalid debug macros Date: Wed, 12 Oct 2022 10:16:09 -0400 Message-Id: <20221012141610.668-3-mikuback@linux.microsoft.com> In-Reply-To: <20221012141610.668-1-mikuback@linux.microsoft.com> References: <20221012141610.668-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: GrhdTfTCwd6PSWRoUAGQV93xx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1665584197; bh=JNsSM0fHLffr8CGosA8XFqoUOj7ugGnrUZk0jH5X2xA=; h=Cc:Date:From:Reply-To:Subject:To; b=o0ppqun++3jGQpMMvWu+7ea6iOPIQ+/TPbR+5/ClsGWododBGfMcxFysRWwn3U8FAzB y4f+jPWSWFFKi1M564VXqCITE4A19b990LXOGmQNvo2/YXV6tAH7ksNcKVWdrJ8OUEgs+ w6uMjQZjXETl99YKnRj0rIgCFjR+akFb0S4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1665584200207100002 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4095 Updates several debug macros in KabylakeSiliconPkg to correctly match print specifiers to actual arguments. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrintPolic= y.c | 19 +++++++++++-------- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c = | 4 ++-- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/C= puPrintPolicy.c b/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicy= Lib/CpuPrintPolicy.c index f13ca92661ae..d20945b7cae3 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrint= Policy.c +++ b/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrint= Policy.c @@ -39,13 +39,16 @@ CpuPowerMgmtBasicConfigPrint ( ) { DEBUG ((DEBUG_INFO, "------------------ CPU Power Mgmt Basic Config ----= --------------\n")); - DEBUG ((DEBUG_INFO, " CPU_POWER_MGMT_BASIC_CONFIG : OneCoreRatioLimit : = 0x%X , TwoCoreRatioLimit =3D 0x%X , ThreeCoreRatioLimit =3D 0x%X , FourCore= RatioLimit =3D 0x%X \n", CpuPowerMgmtBasicConfig->OneCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->TwoCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->ThreeCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->FourCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->FiveCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->SixCoreRatioLimit, \ - CpuPowerMgmtBasicConfig->SevenCoreRatioLimit, \ + DEBUG ((DEBUG_INFO, + " CPU_POWER_MGMT_BASIC_CONFIG : OneCoreRatioLimit : 0x%X , TwoCo= reRatioLimit =3D 0x%X , ThreeCoreRatioLimit =3D 0x%X , FourCoreRatioLimit = =3D 0x%X\n" + " FiveCoreRatioLimit : 0x%X , SixC= oreRatioLimit =3D 0x%X , SevenCoreRatioLimit =3D 0x%X , EightCoreRatioLimit= =3D 0x%X\n", + CpuPowerMgmtBasicConfig->OneCoreRatioLimit, + CpuPowerMgmtBasicConfig->TwoCoreRatioLimit, + CpuPowerMgmtBasicConfig->ThreeCoreRatioLimit, + CpuPowerMgmtBasicConfig->FourCoreRatioLimit, + CpuPowerMgmtBasicConfig->FiveCoreRatioLimit, + CpuPowerMgmtBasicConfig->SixCoreRatioLimit, + CpuPowerMgmtBasicConfig->SevenCoreRatioLimit, CpuPowerMgmtBasicConfig->EightCoreRatioLimit)); DEBUG ((DEBUG_INFO, " CPU_POWER_MGMT_BASIC_CONFIG: Hwp : 0x%x\n", CpuPow= erMgmtBasicConfig->Hwp)); DEBUG ((DEBUG_INFO, " CPU_POWER_MGMT_BASIC_CONFIG: SkipSetBootPState : 0= x%x\n", CpuPowerMgmtBasicConfig->SkipSetBootPState)); @@ -151,7 +154,7 @@ CpuPidTestConfigPrint ( { UINT32 Index =3D 0; DEBUG ((DEBUG_INFO, "------------------ CPU PID Test Config ------------= ------\n")); - DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", Index, = CpuPidTestConfig->PidTuning)); + DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", CpuPidT= estConfig->PidTuning)); if ( CpuPidTestConfig->PidTuning =3D=3D 1) { for (Index =3D PID_DOMAIN_KP; Index <=3D PID_DOMAIN_KD; Index++) { DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : Ratl[%X] : 0x%X\n", In= dex, CpuPidTestConfig->Ratl[Index])); diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOc= WdtLib.c b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWd= tLib.c index e8c8dab6e7ad..467f71bff92b 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c @@ -75,7 +75,7 @@ OcWdtResetCheck ( /// Timeout status bits are cleared by writing '1' /// if (Readback & (B_PCH_OC_WDT_CTL_ICCSURV_STS | B_PCH_OC_WDT_CTL_NO_ICCSU= RV_STS)) { - DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected.\n", Readback)); + DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected. Read back =3D 0x%08x\= n", Readback)); Readback |=3D B_PCH_OC_WDT_CTL_FAILURE_STS; Readback |=3D (B_PCH_OC_WDT_CTL_ICCSURV_STS | B_PCH_OC_WDT_CTL_NO_ICCS= URV_STS); Readback &=3D ~(B_PCH_OC_WDT_CTL_UNXP_RESET_STS); @@ -102,7 +102,7 @@ OcWdtResetCheck ( /// /// No WDT expiration and no unexpected reset - clear Failure status /// - DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n", Readback)); + DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n")); Readback &=3D ~(B_PCH_OC_WDT_CTL_FAILURE_STS); Readback |=3D (B_PCH_OC_WDT_CTL_ICCSURV_STS | B_PCH_OC_WDT_CTL_NO_IC= CSURV_STS); } --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95103): https://edk2.groups.io/g/devel/message/95103 Mute This Topic: https://groups.io/mt/94281682/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-