From nobody Sat Feb 7 08:02:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+95102+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95102+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1665584195; cv=none; d=zohomail.com; s=zohoarc; b=gE3qg4v/YzcweY3WQ7Y1BsRbib6XAZEaaqw+2foEqeRrKb8lp34wqjccKhURpZXkH4JyNE3/3Cfu7IDCZHSiQ9vWk4U6f47RkeRsvfoHig3jIOhqimmvrvIQhaqiKddsgaKwV+y+xPYxN79w4PVQ2g91cxCaiCS6vGclp+MfPv4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665584195; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=0+aH67/gWifA+2EM8PX3qTH3A8HpCg55f+q4gLt0wBo=; b=mN+dTeK92/XnhF+wQWO54XIBWS8Lh8bcgFkzMhjQ3QukITiqP9vVI63UTOOWTgKIzYQoFlQEhjj3rGWhJpH2hrIjpkw1q3UdkTVI55PS2EM/vYPqzwO1OlslH/kXmj4KEG9zGuC3IG9JAl98SqafvXj6toTC9fH8mxMBp9fdLRw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95102+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1665584195402112.0070344073381; Wed, 12 Oct 2022 07:16:35 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id rarjYY1788612x94xfssTFoR; Wed, 12 Oct 2022 07:16:35 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.20671.1665584194296859719 for ; Wed, 12 Oct 2022 07:16:34 -0700 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 5E92920F0F63; Wed, 12 Oct 2022 07:16:33 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5E92920F0F63 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Sai Chaganty Subject: [edk2-devel] [edk2-platforms][PATCH v2 1/3] CoffeelakeSiliconPkg: Fix invalid debug macros Date: Wed, 12 Oct 2022 10:16:08 -0400 Message-Id: <20221012141610.668-2-mikuback@linux.microsoft.com> In-Reply-To: <20221012141610.668-1-mikuback@linux.microsoft.com> References: <20221012141610.668-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: 3yd5VDbYQVfgvh7qesK6G0Vmx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1665584195; bh=MH8T4FpGiUCZXidMiSy+D2W3Tu6n6kw25pUXDdU9TPY=; h=Cc:Date:From:Reply-To:Subject:To; b=uiefyQBZyuBslQn5yDEpYo0N4SYxoVdZDYQ0mFMKp2LD9LfwddlxPULv2KiHxCZWdBL BygCKvetxwtlGbOUF5/n+KPCnCP+NWDwarDLpaMwK4K0DMc5dLWbz/Z3cXY4yPQjz685G Ux7QNVOxwaQpeHzQWEV1CDhdmSrFX1pxzek= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1665584196021100005 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4095 Updates several debug macros in CoffeelakeSiliconPkg to correctly match print specifiers to actual arguments. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Michael Kubacki --- Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrintPol= icy.c | 2 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/GbeMdiLi= b.c | 2 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c = | 4 ++-- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPciExpr= essHelpersLib/PchPciExpressHelpersLibrary.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib= /CpuPrintPolicy.c b/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPo= licyLib/CpuPrintPolicy.c index 38cf383e8da2..2e50068ba193 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPri= ntPolicy.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPri= ntPolicy.c @@ -161,7 +161,7 @@ CpuPidTestConfigPrint ( { UINT32 Index =3D 0; DEBUG ((DEBUG_INFO, "------------------ CPU PID Test Config ------------= ------\n")); - DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", Index, = CpuPidTestConfig->PidTuning)); + DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : PidTuning : 0x%X\n", CpuPidT= estConfig->PidTuning)); if ( CpuPidTestConfig->PidTuning =3D=3D 1) { for (Index =3D PID_DOMAIN_KP; Index <=3D PID_DOMAIN_KD; Index++) { DEBUG ((DEBUG_INFO, " CPU_PID_TEST_CONFIG : Ratl[%X] : 0x%X\n", In= dex, CpuPidTestConfig->Ratl[Index])); diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdi= Lib/GbeMdiLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmG= beMdiLib/GbeMdiLib.c index e5aa10de3b7b..70e8f7bb6f50 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/Gbe= MdiLib.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/Gbe= MdiLib.c @@ -335,7 +335,7 @@ GbeMdiGetLanPhyRevision ( Status =3D EFI_DEVICE_ERROR; goto PHY_EXIT; } - DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. = Overriding LANPHYPC\n", Status)); + DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. = Overriding LANPHYPC. Status: %r\n", Status)); // // Taking over LANPHYPC // 1. SW signal override - 1st cycle. diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/Pei= OcWdtLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/Pei= OcWdtLib.c index 22f6fb215fcc..e2014f97e58c 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLi= b.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLi= b.c @@ -71,7 +71,7 @@ OcWdtResetCheck ( /// Timeout status bits are cleared by writing '1' /// if (Readback & (B_ACPI_IO_OC_WDT_CTL_ICCSURV_STS | B_ACPI_IO_OC_WDT_CTL_= NO_ICCSURV_STS)) { - DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected.\n", Readback)); + DEBUG ((DEBUG_ERROR, "(WDT) Expiration detected. Read back =3D 0x%08x\= n", Readback)); Readback |=3D B_ACPI_IO_OC_WDT_CTL_FAILURE_STS; Readback |=3D (B_ACPI_IO_OC_WDT_CTL_ICCSURV_STS | B_ACPI_IO_OC_WDT_CTL= _NO_ICCSURV_STS); Readback &=3D ~(B_ACPI_IO_OC_WDT_CTL_UNXP_RESET_STS); @@ -98,7 +98,7 @@ OcWdtResetCheck ( /// /// No WDT expiration and no unexpected reset - clear Failure status /// - DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n", Readback)); + DEBUG ((DEBUG_INFO, "(WDT) Status OK.\n")); Readback &=3D ~(B_ACPI_IO_OC_WDT_CTL_FAILURE_STS); Readback |=3D (B_ACPI_IO_OC_WDT_CTL_ICCSURV_STS | B_ACPI_IO_OC_WDT_C= TL_NO_ICCSURV_STS); } diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeS= mmPchPciExpressHelpersLib/PchPciExpressHelpersLibrary.c b/Silicon/Intel/Cof= feelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPciExpressHelpersLib/PchP= ciExpressHelpersLibrary.c index dcb43285b73e..120d0d1ec29b 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPc= iExpressHelpersLib/PchPciExpressHelpersLibrary.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPc= iExpressHelpersLib/PchPciExpressHelpersLibrary.c @@ -1800,7 +1800,7 @@ RecursiveIoApicCheck ( IoApicPresent =3D FALSE; =20 if (IsIoApicDevice (SbdfToBase (Sbdf))) { - DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev, = Sbdf.Func)); + DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Seg, Sbdf.Bus, = Sbdf.Dev, Sbdf.Func)); return TRUE; } if (HasChildBus (Sbdf, &ChildSbdf)) { --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95102): https://edk2.groups.io/g/devel/message/95102 Mute This Topic: https://groups.io/mt/94281681/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-