From nobody Tue Feb 10 01:50:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+95079+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95079+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1665571557; cv=none; d=zohomail.com; s=zohoarc; b=jTIBe5o3noPlPvnzsYpqBwWuODGPHTRXkisdLjD5jgTVdTYnqvCdgcHgSTHSKr/930YFp6hZYbSH7AgNf3klkqC+Ly+145LenKpCkwHgpX/EY8Z/cZ1+u6O2IvrYQlZkofbyoMkhh7FnNK//7Z14Cl6SPB4a9rXoLjETqwtiodE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665571557; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=umZAgTwhBcnX6gij0cHG38i94vjOOEJp3Jz4oRf0bBU=; b=HS59UKyWJSMBcY3KCwqTglRGPv1GS5IEDBx3590X/iE697eEivheBeSPo8g2JBXbHUt5gLEGeT0lDOay6w5hctoSfYmizGwYlb9OQ6aO/1aXNbpdjoaIOMLk7ND7wJOQ7XotA8MnwsOLXZ5G52AtqFjikTs+fezEkDzvRbd0oqs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+95079+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1665571557304621.9351061026548; Wed, 12 Oct 2022 03:45:57 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id UWDkYY1788612xHoKuuLAA0L; Wed, 12 Oct 2022 03:45:56 -0700 X-Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mx.groups.io with SMTP id smtpd.web11.18724.1665571556207065452 for ; Wed, 12 Oct 2022 03:45:56 -0700 X-Received: by mail-pj1-f45.google.com with SMTP id q10-20020a17090a304a00b0020b1d5f6975so1692304pjl.0 for ; Wed, 12 Oct 2022 03:45:56 -0700 (PDT) X-Gm-Message-State: daOR6wRiAVRVrFEOpSxbiVyzx1787277AA= X-Google-Smtp-Source: AMsMyM5yLM7axRwugDnBbKoMDBCbPv9xYlBfH9kCqexAI15vM+TegfJLL6vZHQKuQYMcovAtsc0Edw== X-Received: by 2002:a17:902:e547:b0:178:43de:acac with SMTP id n7-20020a170902e54700b0017843deacacmr29468389plf.39.1665571550687; Wed, 12 Oct 2022 03:45:50 -0700 (PDT) X-Received: from localhost.localdomain ([49.206.13.138]) by smtp.gmail.com with ESMTPSA id z4-20020aa79e44000000b0054223a0185asm10812221pfq.161.2022.10.12.03.45.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 03:45:49 -0700 (PDT) From: "Sunil V L" To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Rahul Kumar Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V2 15/33] UefiCpuPkg/CpuExceptionHandlerLib: Refactor to allow other architectures Date: Wed, 12 Oct 2022 16:14:38 +0530 Message-Id: <20221012104456.1393376-16-sunilvl@ventanamicro.com> In-Reply-To: <20221012104456.1393376-1-sunilvl@ventanamicro.com> References: <20221012104456.1393376-1-sunilvl@ventanamicro.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1665571557; bh=oUsDmXA6HbStZ4nsHXgw+3T3o2y29DoqhQDNtAdFKSg=; h=Cc:Date:From:Reply-To:Subject:To; b=XOpweAQKYx1mGKJETS2JZza/UkhxpJRWKkECDS+u1eC067Yf4GQxePxFUIxeGKDFT9h lbUyzcQg9d1q4pe5IR0fs7t47IXwYzdIsHbM4MsFLL/YW9MqMm3TfDuGq5Lgr61MUPInR OAH5Vt0FfjjgUSsUdoWgpaSIZxj54dhP7Y0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1665571558631100002 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4076 Currently, the CpuExceptionHandlerLib library supports only X86. Refactor the library to allow adding other CPU architectures. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Sunil V L --- .../DxeCpuExceptionHandlerLib.inf | 14 ++++++++------ .../PeiCpuExceptionHandlerLib.inf | 8 ++++---- .../SecPeiCpuExceptionHandlerLib.inf | 12 +++++++----- .../SmmCpuExceptionHandlerLib.inf | 8 ++++---- .../Xcode5SecPeiCpuExceptionHandlerLib.inf | 6 +++--- .../{ =3D> Ia32_X64}/CpuExceptionCommon.h | 0 .../{ =3D> Ia32_X64}/CpuExceptionCommon.c | 0 .../{ =3D> Ia32_X64}/DxeException.c | 0 .../{ =3D> Ia32_X64}/PeiCpuException.c | 0 .../{ =3D> Ia32_X64}/PeiDxeSmmCpuException.c | 0 .../{ =3D> Ia32_X64}/SecPeiCpuException.c | 0 .../{ =3D> Ia32_X64}/SmmException.c | 0 12 files changed, 26 insertions(+), 22 deletions(-) rename UefiCpuPkg/Library/CpuExceptionHandlerLib/{ =3D> Ia32_X64}/CpuExcep= tionCommon.h (100%) rename UefiCpuPkg/Library/CpuExceptionHandlerLib/{ =3D> Ia32_X64}/CpuExcep= tionCommon.c (100%) rename UefiCpuPkg/Library/CpuExceptionHandlerLib/{ =3D> Ia32_X64}/DxeExcep= tion.c (100%) rename UefiCpuPkg/Library/CpuExceptionHandlerLib/{ =3D> Ia32_X64}/PeiCpuEx= ception.c (100%) rename UefiCpuPkg/Library/CpuExceptionHandlerLib/{ =3D> Ia32_X64}/PeiDxeSm= mCpuException.c (100%) rename UefiCpuPkg/Library/CpuExceptionHandlerLib/{ =3D> Ia32_X64}/SecPeiCp= uException.c (100%) rename UefiCpuPkg/Library/CpuExceptionHandlerLib/{ =3D> Ia32_X64}/SmmExcep= tion.c (100%) diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandl= erLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandle= rLib.inf index e7a81bebdb13..ef07b05c080a 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.i= nf +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.i= nf @@ -32,11 +32,11 @@ [Sources.X64] X64/ArchExceptionHandler.c X64/ArchInterruptDefs.h =20 -[Sources.common] - CpuExceptionCommon.h - CpuExceptionCommon.c - PeiDxeSmmCpuException.c - DxeException.c +[Sources.IA32, Sources.X64] + Ia32_X64/CpuExceptionCommon.h + Ia32_X64/CpuExceptionCommon.c + Ia32_X64/PeiDxeSmmCpuException.c + Ia32_X64/DxeException.c =20 [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard @@ -56,8 +56,10 @@ [LibraryClasses] SerialPortLib PrintLib SynchronizationLib - LocalApicLib PeCoffGetEntryPointLib MemoryAllocationLib DebugLib + +[LibraryClasses.IA32, LibraryClasses.X64] + LocalApicLib VmgExitLib diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandl= erLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandle= rLib.inf index 7c2ec3b2db4c..7e7e1a4296de 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.i= nf +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.i= nf @@ -33,10 +33,10 @@ [Sources.X64] X64/ArchInterruptDefs.h =20 [Sources.common] - CpuExceptionCommon.h - CpuExceptionCommon.c - PeiCpuException.c - PeiDxeSmmCpuException.c + Ia32_X64/CpuExceptionCommon.h + Ia32_X64/CpuExceptionCommon.c + Ia32_X64/PeiCpuException.c + Ia32_X64/PeiDxeSmmCpuException.c =20 [Packages] MdePkg/MdePkg.dec diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHa= ndlerLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuException= HandlerLib.inf index 6a170286c8fc..28341abd4493 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLi= b.inf +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLi= b.inf @@ -32,10 +32,10 @@ [Sources.X64] X64/ArchExceptionHandler.c X64/ArchInterruptDefs.h =20 -[Sources.common] - CpuExceptionCommon.h - CpuExceptionCommon.c - SecPeiCpuException.c +[Sources.IA32, Sources.X64] + Ia32_X64/CpuExceptionCommon.h + Ia32_X64/CpuExceptionCommon.c + Ia32_X64/SecPeiCpuException.c =20 [Packages] MdePkg/MdePkg.dec @@ -46,8 +46,10 @@ [LibraryClasses] BaseLib SerialPortLib PrintLib - LocalApicLib PeCoffGetEntryPointLib + +[LibraryClasses.IA32, LibraryClasses.X64] + LocalApicLib VmgExitLib =20 [Pcd] diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandl= erLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandle= rLib.inf index 9dde07612a04..b7f395f45ab4 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.i= nf +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.i= nf @@ -33,10 +33,10 @@ [Sources.X64] X64/ArchInterruptDefs.h =20 [Sources.common] - CpuExceptionCommon.h - CpuExceptionCommon.c - PeiDxeSmmCpuException.c - SmmException.c + Ia32_X64/CpuExceptionCommon.h + Ia32_X64/CpuExceptionCommon.c + Ia32_X64/PeiDxeSmmCpuException.c + Ia32_X64/SmmException.c =20 [Packages] MdePkg/MdePkg.dec diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExcep= tionHandlerLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPei= CpuExceptionHandlerLib.inf index 6d2f66504a5b..7830b3e6663f 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHan= dlerLib.inf +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHan= dlerLib.inf @@ -38,9 +38,9 @@ [Sources.X64] X64/ArchInterruptDefs.h =20 [Sources.common] - CpuExceptionCommon.h - CpuExceptionCommon.c - SecPeiCpuException.c + Ia32_X64/CpuExceptionCommon.h + Ia32_X64/CpuExceptionCommon.c + Ia32_X64/SecPeiCpuException.c =20 [Packages] MdePkg/MdePkg.dec diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.h= b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/CpuExceptionCommon.h similarity index 100% rename from UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.h rename to UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/CpuExceptionCo= mmon.h diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c= b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/CpuExceptionCommon.c similarity index 100% rename from UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c rename to UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/CpuExceptionCo= mmon.c diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c b/Uef= iCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/DxeException.c similarity index 100% rename from UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c rename to UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/DxeException.c diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c b/= UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/PeiCpuException.c similarity index 100% rename from UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c rename to UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/PeiCpuExceptio= n.c diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuExceptio= n.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/PeiDxeSmmCpuExcept= ion.c similarity index 100% rename from UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException= .c rename to UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/PeiDxeSmmCpuEx= ception.c diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuException.c= b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/SecPeiCpuException.c similarity index 100% rename from UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuException.c rename to UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/SecPeiCpuExcep= tion.c diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c b/Uef= iCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/SmmException.c similarity index 100% rename from UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c rename to UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32_X64/SmmException.c --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95079): https://edk2.groups.io/g/devel/message/95079 Mute This Topic: https://groups.io/mt/94278075/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-