From nobody Wed Feb 11 04:19:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94890+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94890+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1665393687; cv=none; d=zohomail.com; s=zohoarc; b=hXfDcIg1+IqsK9Wcw98Hycjg4GktPrGEgh8sz6zw1/IWiQEWAIGaQSUYN3fe+7kcCrggGgABCh7k/qWa4w4uN7tcjStciKXbM43F+RNHJ/+F4oJeUDLtOji/A/3IRnU8XX8RadpQtUGz2dr4QF0PK89854PneEuci87VSdWkYsE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1665393687; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=vazmsIN0FT5sO1e1C5PbAEjLjU7LLWWmr8eHTKDVXdk=; b=eIo/WvoNXZR0P55st3Bmkyark32yc96sBNqt1E7HRsVWsJj6J3iDUz3s/fo+3nlUG5MF3I+ZJhhDnGpTDfzGVnUimRV7riAeR7XYLV3d4jHMmsS5iEVdwnQGvkR+Au2aeOSGXuKwsPrihDb6+QjvWEYV/UqtiQV/mFEqDWkN4ls= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94890+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1665393687848748.3258472545169; Mon, 10 Oct 2022 02:21:27 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id OysHYY1788612xM6rN6ifN6n; Mon, 10 Oct 2022 02:21:27 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.4231.1665393686833861912 for ; Mon, 10 Oct 2022 02:21:26 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B283C1AED; Mon, 10 Oct 2022 02:21:32 -0700 (PDT) X-Received: from pierre123.arm.com (unknown [10.57.34.234]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BE4B53F792; Mon, 10 Oct 2022 02:21:25 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar , Alexei Fedorov Subject: [edk2-devel] [PATCH 09/14] DynamicTablesPkg: Fix Ssdt PCI generation comments Date: Mon, 10 Oct 2022 11:20:53 +0200 Message-Id: <20221010092058.118714-10-Pierre.Gondois@arm.com> In-Reply-To: <20221010092058.118714-1-Pierre.Gondois@arm.com> References: <20221010092058.118714-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: vaY0w4aLeevCxT5ZRJV4lkdGx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1665393687; bh=cbjFB7qOI4BwoRV/5P/3DEjcJJQBGqVYhG0T9ugkZpY=; h=Cc:Date:From:Reply-To:Subject:To; b=dkp6PgqgOWIgniyHVcVLZ2Rfp0d8AticXQQEVKgQ6XyhDrTRF9dSC75KJEC6Lkr4IsH +m4UAC/FUcIw5edZyJdIqKpRd7hIzyfJyzqMa3sOnkuHyehD4oJOLrbeeAEIlzE/HTmX7 WFJ1ANzBnK5x4lI2qEoWTEWiKHyUBS39dXg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1665393689484100037 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois The second model of the _PRT object is used. Indeed: - the interrupts described are not re-configurable - OSes are aware of the polarity of PCI legacy interrupts, so there is no need to accurately describe the polarity. Also, fix a comment for the CM_ARM_PCI_INTERRUPT_MAP_INFO obj. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 2 +- .../Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTables= Pkg/Include/ArmNameSpaceObjects.h index cd39e609d6c4..d711f3ec5938 100644 --- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h +++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h @@ -1014,7 +1014,7 @@ typedef struct CmArmPciInterruptMapInfo { /// Value on 8 bits (max 255). UINT8 PciBus; =20 - /// Pci Bus. + /// Pci Device. /// Value on 5 bits (max 31). UINT8 PciDevice; =20 diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieG= enerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieG= enerator.c index 85098752c614..c54ae6f551f6 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerato= r.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerato= r.c @@ -288,12 +288,6 @@ GeneratePciDeviceInfo ( =20 Cf. ACPI 6.4 specification, s6.2.13 "_PRT (PCI Routing Table)" =20 - The first model (defining a _CRS object) is used. This is necessary beca= use - PCI legacy interrupts are active low and GICv2 SPI interrupts are active - high. - Even though PCI interrupts cannot be re-routed, only the first model all= ows - to specify the activation state (low/high). - @param [in] Generator The SSDT Pci generator. @param [in] CfgMgrProtocol Pointer to the Configuration Manager Protocol interface. @@ -397,6 +391,8 @@ GeneratePrt ( High word-Device #, Low word-Function #. (for example, device 3, function 2 is 0x00030002). To refer to all the functions on a devic= e #, use a function number of FFFF). + + Use the second model for _PRT object and describe a hardwired interr= upt. */ Status =3D AmlAddPrtEntry ( (IrqMapInfo->PciDevice << 16) | 0xFFFF, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94890): https://edk2.groups.io/g/devel/message/94890 Mute This Topic: https://groups.io/mt/94232528/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-