From nobody Wed Feb 11 06:14:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94651+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94651+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1664782553; cv=none; d=zohomail.com; s=zohoarc; b=mK2wRiZbjwgEqVFielFIjiX20hq2pbO84l9lZFPS8jwgKWlBEUG/rfcBlVyL5N7GIEr5EZwZqwmqdA8L21gNUXXkPQRltI1XvkmFemzAA2e6gvp6HBILYw/se1AP5MXO7RZ5oxo6VdtUc6VE5KnUamoprh1vD3KWRSf5NpGLSRQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1664782553; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=wr8TdkCL5D/oHlv+f6rFK/0d8Q1Msx/rRqblsWRzj0k=; b=Hy6e92wXMkhPnJVB3DcAqkxC8TyKwh7wkkczuJhApDs1OOt2MU96F95Pf5OkADZNPeGD80bHvmvOYSsX31DbnX7P/Xlee0jHCAvP832y2F8JoxSPA1/82AEyw32rRtq9Fz7ShJLY6XAC0QpWzC5KXFQwLZvGDJIyr84zj3v73dc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94651+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1664782553225106.0570838217526; Mon, 3 Oct 2022 00:35:53 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id HMZBYY1788612xftW5PZvOPb; Mon, 03 Oct 2022 00:35:51 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.16221.1664782551193478329 for ; Mon, 03 Oct 2022 00:35:51 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9CF5313D5; Mon, 3 Oct 2022 00:35:57 -0700 (PDT) X-Received: from pierre123.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 81AFD3F73B; Mon, 3 Oct 2022 00:35:48 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar , Leif Lindholm , Ard Biesheuvel , Rebecca Cran , Michael D Kinney , Liming Gao , Jiewen Yao , Jian J Wang Subject: [edk2-devel] [PATCH v7 16/19] SecurityPkg/RngDxe: Add debug warning for NULL PcdCpuRngSupportedAlgorithm Date: Mon, 3 Oct 2022 09:35:00 +0200 Message-Id: <20221003073503.2937059-17-Pierre.Gondois@arm.com> In-Reply-To: <20221003073503.2937059-1-Pierre.Gondois@arm.com> References: <20221003073503.2937059-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 8AeGCTAUwODW8c8VB0TFXciux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1664782551; bh=+8z3C1Nhl+SylYqNQfsqT8ksQYIxbuVpRkRFg/feemI=; h=Cc:Date:From:Reply-To:Subject:To; b=r7pujwKlWj+A4AjtT4i2dyfIiy3lw4ytM/C25W+EWwOky4ZKF8vsGcqAGfZhhygtYhJ 2fFjX9mdj8PdYYlms3is0edY/WDsGSAExgOGtYRwsEwcWnlk77OpBfGF6/eBs8Hi9RjLB iMK4VzLK8EItGw4WeQL7lrBsyTPNITBd/qk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1664782554059100001 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois PcdCpuRngSupportedAlgorithm should allow to identify the the algorithm used by the RNDR CPU instruction to generate a random number. Add a debug warning if the Pcd is not set. Signed-off-by: Pierre Gondois --- .../RandomNumberGenerator/RngDxe/AArch64/RngDxe.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c b/Se= curityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c index f5910e3b999f..0d853720ecb1 100644 --- a/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c +++ b/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c @@ -67,6 +67,16 @@ GetAvailableAlgorithms ( sizeof (EFI_RNG_ALGORITHM) ); mAvailableAlgoArrayCount++; + + DEBUG_CODE_BEGIN (); + if (IsZeroGuid (PcdGetPtr (PcdCpuRngSupportedAlgorithm))) { + DEBUG (( + DEBUG_WARN, + "PcdCpuRngSupportedAlgorithm should be a non-zero GUID\n" + )); + } + + DEBUG_CODE_END (); } =20 // Raw algorithm (Trng) --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94651): https://edk2.groups.io/g/devel/message/94651 Mute This Topic: https://groups.io/mt/94085860/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-