From nobody Sat Apr 27 04:41:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94107+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94107+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 166382687231145.153785178448516; Wed, 21 Sep 2022 23:07:52 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id xvIjYY1788612xElLjhWBYTP; Wed, 21 Sep 2022 23:07:52 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.79]) by mx.groups.io with SMTP id smtpd.web12.4091.1663826871075045611 for ; Wed, 21 Sep 2022 23:07:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XzIvtjgS5v3tlt95Ep+IJ9+afNmnRhjU5nJJLD5Suj/tTdyG9TI8E1dwNNLPC5CUk7cEsO/fHYNCyaLFrcPwguSlw96pA267q1V6vZ89nGDO7cExnYXuqP5fcyvugPgj7mMkQBgU+oy2v3ThaMAdo90kbGFY8jK+mlhC6PIKyRz9wqE7FHlB3MeGY904xmBujAMsc3mMmUJ8SySNkCGObpoGUtKAyEReOMJiiKTnoPqEQTHe9XFT/yeJ93JozJ2gnlTlD5TYaqFEa0F+dUlunDb/IDvQobi8xE1pr8jNfN4QFMDB8m88Xu2i/X/D+/qqmVqpGayOVDsKGAXwBLlUFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ynIcS/PPRnH2/Y5hj8TT1Rx9Vq5j0OEbZxmh1k0dslU=; b=mDkUQiS8uQweg6qHtK+txPQXUxvFZwhWrDunTK/NAzA5VjP53Wxu73XTRM9LFkhSJck5eliGUosMcWkkebLm0TUTIhiAgpBTflB5uoi60BmFCYC4QXJAz2u2tLQO0IxSOsWh5MAmrPV7hYNWK0X2rYspnkoyE9BA/0yY2dAj6aWDTulwv/mpQj/K/G6gLyxHYqm1jXuBlJxInC9oCVhY9oUjIfR+ly/oovnDuX19fjpyZM3noVtou4PITccjv/IRQnWqpW+PzdKxXuDtpHwNRYAATRRcp/3zvgQIGbSiRthZeTFo39nnpKCPKuOQPZN+8jiRaSGZEu6uaNJ8LeB93w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from BN9PR12MB5305.namprd12.prod.outlook.com (2603:10b6:408:102::5) by CO6PR12MB5443.namprd12.prod.outlook.com (2603:10b6:303:13a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18; Thu, 22 Sep 2022 06:07:49 +0000 X-Received: from BN9PR12MB5305.namprd12.prod.outlook.com ([fe80::2d3d:180b:df02:3433]) by BN9PR12MB5305.namprd12.prod.outlook.com ([fe80::2d3d:180b:df02:3433%9]) with mapi id 15.20.5654.018; Thu, 22 Sep 2022 06:07:49 +0000 From: "Ying-Tsun Huang via groups.io" To: devel@edk2.groups.io CC: Jian J Wang , Dandan Bi , Liming Gao Subject: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/Core: Fix the potential hang of calling SetTimer. Date: Thu, 22 Sep 2022 14:07:13 +0800 Message-ID: <20220922060713.14217-2-ying-tsun.huang@amd.com> In-Reply-To: <20220922060713.14217-1-ying-tsun.huang@amd.com> References: <20220922060713.14217-1-ying-tsun.huang@amd.com> X-ClientProxiedBy: SG2PR04CA0167.apcprd04.prod.outlook.com (2603:1096:4::29) To BN9PR12MB5305.namprd12.prod.outlook.com (2603:10b6:408:102::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN9PR12MB5305:EE_|CO6PR12MB5443:EE_ X-MS-Office365-Filtering-Correlation-Id: a3fdf27a-ef78-494c-d13a-08da9c60c676 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: epC6bWSKx8PTGD5CRZghKn0lVEYH7Eot4khpYECUZeqtlN4JqPfJ6BVxDRgEBILOD4CvT+zmyECjyc/mUU6EoiKtlaAX0tkXfhDzCIgs7PSZAhl/7/Sz/ihe4jeBhDqep8wfNTQCHQgkQ8h8n5rAVRx/4fy1AhijZE8SkHsrLFt9550Poh6I3TPB6WZjgMDvPkSY/2aEHZz+LfkuDqwbKi7hlKO7uOYPLFghQTUA8alX/MFglb40sXOf8CQGy4RaNlwT5+Sc8F6tSXNXFpRyhUVTpyFlkmoXMQ38Rpi+yN7jsLOu/ONmiNFuNdZts4h99q7gBMWp9g4CKhZGSzt3UQ4/h7QqEkkaWDiyxldTUs6BvLPLYNO/en1UaYHPbBsv4t7XA3BMzT9fJQgTlR0bFLX8vedoipz597EddDikHP1+MZ0+oQUBZf5fr5HPYfMs4TyM2WR/wtEh7Sjs/HPnNRh5DBncKRx+3hB3iHSrpnLsb0N8h1Z25K68MNj/d8WK8dydgTXL+xaVFrS5uL9VZzwaNWsMf0s15Iewpm79ALjdzcpmLpfkjOCzfpRN0SBo77FKxpg2KeQLZzsyzGnhxhxM1FLos03xfskwJDKLKW/S3kujo2po/FUBKhomL7lS/wlY+O06BKruVGXBma8HMx1Bw97cnlUzuLv9thzh9WSczowoVmOtlJ8O1cBQgcndYeHU6us8MLeRMlGcS+PjItsWQP6aVprFHkyoViLpCyv0V7gg4xosVZMEOGUPFJgmJW29aK/O8VicTOhf53sCTQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FKWLyCErsY1Tc31Xnr/pqb8XvQbLkzKF9hFTDuMSkTg1Qy7mnU/Jxl/jxgTE?= =?us-ascii?Q?CnDZzYcS0f7RXkQ+qWAf3186FOBJlyAlD2vbZJYUEvqaynWxoqyZOYLKKu4S?= =?us-ascii?Q?vuf8Jp08/QSvX9u4fVabrClUNoexiqyGnj5CVV8JQZS7NDsLRjqJHFaIy5iY?= =?us-ascii?Q?N79nyCd9gLxRVIbK0LQ+UUVnTGGpp6/g6Cxs9i1rPSHoWHteVpjJ+vGajI6A?= =?us-ascii?Q?iM+40T1wKXBIwHYwC5KYG1kMgRTpQWazRKzd0XgAlsgewk0aG/og5QTJ+jxK?= =?us-ascii?Q?572yx6ul3CVXrUM+FfKVpMWG8pkay3an8Y1K56yvdpR2zwfv1in64LAZZ8ed?= =?us-ascii?Q?aJYTPLWclU4Ziq1oDmkucV/656k2s4ZQZC4N6k5lf3t0Zpo1ywyTjLz0sDad?= =?us-ascii?Q?7TBzdHpT/eB4QadP4fQecT00mslbVXD8yYye4pSJE/f4joduSuPFFZtOpFZT?= =?us-ascii?Q?Vtmuwwq1vkBRDiwol/ZhOSRjTGmi9wSOtDoc7KuJGT80WyQ2/a4YF+YilFnU?= =?us-ascii?Q?lMrWDCQ0uoy04rTgs3bY2IpzUbn79qGZRLe2R1Q++3Z2m5eKRNVL5o8IvGsb?= =?us-ascii?Q?v28NhCX2bmV9KcbDON6loRaCqh7LNN8tIKntRLhjjSb1fRRsMB7uMDpSR9f9?= =?us-ascii?Q?M4cbTqaeq8wNk2xurAJFT/w6TllFN0YDYgNHbPiFwQGvYI9qMObThk9K78iv?= =?us-ascii?Q?DXBwB2JEsDjYdTfbd3HmvFMTgNa1rnZG0L2bZ+tV86uULscUyN5Kin/W/DU5?= =?us-ascii?Q?Za3pluJn1UVlJXXpvj7fMy7Scm+m/rIt6miAUVJXp5ntQDXss63Hsug1ubAj?= =?us-ascii?Q?7WhGPt67pX+LkkU3kJPY9NHa6HLYYdcj4+IDHx2zmcZ0NOKMuMjBVXVRS8gw?= =?us-ascii?Q?tYlaV9SBj6V0YbjXkQCMYUF1PLV1MWyG9ky+IsfA92yMasriFh2FrJTBEmSO?= =?us-ascii?Q?sQ3I+emGbfEJtH6NPlzub1ZDdycdv2LLmCPQKGLvAvIIOXjmDGEOiVR3Ksdn?= =?us-ascii?Q?uhOdN9r4GLDkYZAkQqP6SC2t4+p1nUfV1iPyx4kquwjQQ49uc2YuSg6EatB+?= =?us-ascii?Q?Cx7LHcioSQp6sLvbf7WHaArhuiJmvuHh8s5kvf8CYQV7dFrxcMkU1GG6TnZz?= =?us-ascii?Q?5WeVec4tv6Mdrc398+PGYJcVqQDV+CD8wRaIEGCeTs8EGmdZ+3OBrNk7o2MV?= =?us-ascii?Q?yw1j5dp12oJGEOndU1xNe/bxIxsSvu59BVkMljQKt003hFmZgMpVH2hVsiao?= =?us-ascii?Q?5zhAMUDyfiugtogYUKk/gwRjh6uh4/N2/ePvm39fN+f6VPxspnkOFtb4N+zc?= =?us-ascii?Q?7x8i8oH5ddSfE1/b3coJ8cA1gCc4IgAfwJjc+LIoD7CU5DTidjIhrw0mCWki?= =?us-ascii?Q?BdApQAPXAoKfqUcrAOEb5MZnvWX9k22fPgYntat59WkW7O5IJ/AXPppbgyFY?= =?us-ascii?Q?KI0zTbwxtJJKeoAZGY0T9N2kjJWd0kbsZfoSuafC1WL2VupFw3BXfLjurMVD?= =?us-ascii?Q?4s1aud6Y2+tHvm7Y0JNpCuqzH010ZvQcw+AAEmhR9W0wkSSK5fWL8+ZAlUeJ?= =?us-ascii?Q?c3kNrn93236R+hwo/H0lxNM3FFtYI9+XAvAywnXq?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3fdf27a-ef78-494c-d13a-08da9c60c676 X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5305.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 06:07:48.9918 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TlH65Z8Pszwpw8ZiJjHH7s/3AtTA3sxhWN5nd6vADFYbgfQ3N6l93gGkzqsG75Gn7Xkq3ODpygcNQfosTTb2KA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5443 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ying-tsun.huang@amd.com X-Gm-Message-State: qZnR7Riso718bvZje3LwvTZ4x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1663826872; bh=h4OB94AgA+JampAA0HUoCQkOaBUFp6XwQCFwZDhpBsg=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=VWjh6hcT18iXMbVIxLl+wG7JSIPJp7zI/f1k92Jx7QikTpAohX/NtBJBc1hSOBz7Ro1 mAeT60usXVoU0bP5zQ3aWPYgk5aj8PMn4MrtNN+HLAsejpYcqVbSPhTpu+esNbd71FEGG ElZtR2vEUhitNfq/5ncfFKTyb67hA+XIvxY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1663826873464100001 Content-Type: text/plain; charset="utf-8" When calling SetTimer with Type is not TimerCancel and TriggerTime is 0, gTimer is used to get the timer period. However, gTimer is NULL before EFI_TIMER_ARCH_PROTOCOL is installed. Adding the check of gTimer and return EFI_NOT_READY to avoid the hang. Cc: Jian J Wang Cc: Dandan Bi Cc: Liming Gao Signed-off-by: Ying-Tsun Huang --- MdeModulePkg/Core/Dxe/DxeMain.h | 3 +++ MdeModulePkg/Core/Dxe/Event/Timer.c | 17 +++++++++++++---- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Core/Dxe/DxeMain.h b/MdeModulePkg/Core/Dxe/DxeMai= n.h index 815a6b4bd844..182d9c3537ad 100644 --- a/MdeModulePkg/Core/Dxe/DxeMain.h +++ b/MdeModulePkg/Core/Dxe/DxeMain.h @@ -3,6 +3,7 @@ internal structure and functions used by DxeCore module. =20 Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2022, AMD Incorporated. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -1538,6 +1539,8 @@ CoreCreateEventInternal ( @retval EFI_SUCCESS The event has been set to be signaled at = the requested time @retval EFI_INVALID_PARAMETER Event or Type is not valid + @retval EFI_NOT_READY Type is not TimerCancel, TriggerTime is 0= , but + EFI_TIMER_ARCH_PROTOCOL is not installed = yet =20 **/ EFI_STATUS diff --git a/MdeModulePkg/Core/Dxe/Event/Timer.c b/MdeModulePkg/Core/Dxe/Ev= ent/Timer.c index 29e507c67c50..f630cf5dad61 100644 --- a/MdeModulePkg/Core/Dxe/Event/Timer.c +++ b/MdeModulePkg/Core/Dxe/Event/Timer.c @@ -2,6 +2,7 @@ Core Timer Services =20 Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.
+Copyright (c) 2022, AMD Incorporated. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -229,6 +230,8 @@ CoreTimerTick ( @retval EFI_SUCCESS The event has been set to be signaled at = the requested time @retval EFI_INVALID_PARAMETER Event or Type is not valid + @retval EFI_NOT_READY Type is not TimerCancel, TriggerTime is 0= , but + EFI_TIMER_ARCH_PROTOCOL is not installed = yet =20 **/ EFI_STATUS @@ -255,6 +258,16 @@ CoreSetTimer ( return EFI_INVALID_PARAMETER; } =20 + if ((Type !=3D TimerCancel) && (TriggerTime =3D=3D 0)) { + if (gTimer) { + gTimer->GetTimerPeriod (gTimer, &TriggerTime); + } else { + DEBUG ((DEBUG_ERROR, "EFI_TIMER_ARCH_PROTOCOL is not installed. Unab= le to get timer period.\n")); + ASSERT (FALSE); + return EFI_NOT_READY; + } + } + CoreAcquireLock (&mEfiTimerLock); =20 // @@ -270,10 +283,6 @@ CoreSetTimer ( =20 if (Type !=3D TimerCancel) { if (Type =3D=3D TimerPeriodic) { - if (TriggerTime =3D=3D 0) { - gTimer->GetTimerPeriod (gTimer, &TriggerTime); - } - Event->Timer.Period =3D TriggerTime; } =20 --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94107): https://edk2.groups.io/g/devel/message/94107 Mute This Topic: https://groups.io/mt/93843297/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-