From nobody Fri Apr 19 21:40:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94088+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94088+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1663793105; cv=none; d=zohomail.com; s=zohoarc; b=bsWL4HeGPbV/or2OrM3v5Uz4aE8cLbnbffBt2wKwcie82zM8wpnKQ4bgL894tt6NOcWMud2WXvEblXLAQvqFB2T3iaSp4CU1TLdZeVJBek+nciPdkj3zGQz0vThx8A9EPzdBY/uNDebQJqvZzNPU5I/aWztJmRu6aJDMUMg5ryA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663793105; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=kXoo3QVbTrkvfyJc9ORjAtDSk1uI3v9IWyl+6PKGFQ0=; b=M9H1N02JT3s7362VAYDNsJf0uqMQu52i0P4SdMuR2HCOqiumMf9LdI25XRWY7bZ3+293heOcHHA7/tmX4GfQDG8lY0KIe48tKw+9pu7/4Zi/LALZDItup2rO2Kv4CSkyo2c6TZFmRxzh75xNxdtsz71HF0s1tuE5gfM+OSfAY8E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94088+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1663793105248234.93725689705866; Wed, 21 Sep 2022 13:45:05 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZTURYY1788612xjq3WB46Cef; Wed, 21 Sep 2022 13:45:04 -0700 X-Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mx.groups.io with SMTP id smtpd.web08.11532.1663793104123889500 for ; Wed, 21 Sep 2022 13:45:04 -0700 X-Received: by mail-pj1-f42.google.com with SMTP id p1-20020a17090a2d8100b0020040a3f75eso6680pjd.4 for ; Wed, 21 Sep 2022 13:45:04 -0700 (PDT) X-Gm-Message-State: AFU7Qr2XrgcpbTX4qued3Ax8x1787277AA= X-Google-Smtp-Source: AMsMyM4VtbUhJoWDGU0/P4XENxEro0FF4zQM4++8qCeB4JZ3xNSvkK6dAEFjyOhR68pBn7k9SN8EHQ== X-Received: by 2002:a17:902:ccc2:b0:178:29f9:5c5e with SMTP id z2-20020a170902ccc200b0017829f95c5emr6252510ple.21.1663793103409; Wed, 21 Sep 2022 13:45:03 -0700 (PDT) X-Received: from MININT-0U7P5GU.redmond.corp.microsoft.com ([2001:4898:80e8:a:c76:5dc:f08f:1975]) by smtp.gmail.com with ESMTPSA id 78-20020a630551000000b0041bcd8f3958sm2358069pgf.44.2022.09.21.13.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 13:45:03 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Yuwei Chen , Sean Brogan Subject: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long Date: Wed, 21 Sep 2022 13:44:59 -0700 Message-Id: <20220921204459.821-2-kuqin12@gmail.com> In-Reply-To: <20220921204459.821-1-kuqin12@gmail.com> References: <20220921204459.821-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1663793104; bh=6GS0ifOz8JuWOTylKN2SaSoyl1FyCDQr00UoWyba6+0=; h=Cc:Date:From:Reply-To:Subject:To; b=MiXCekwi2mlbvcdfRcXnlg0fUGKDoZuRpAjOETMPMu2O9boT4zAb/Im5MH1D6N3fZy5 fRmarbjkgZdZ7bWx8QjyV4DOaAtsIg4JvrFAuvYx0axVLqhvmX4TPe8fLCt8gPbP/3Rjl m+6Slj0LBnOluu9HyrJ+RK7F1lTL8ZgEOBE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1663793107409100005 Content-Type: text/plain; charset="utf-8" From: Sean Brogan Current implementation of looking up toolchain will _insert_ the findings from vsvarsall.bat to existing path and potentially stuff the variable to exceed the length of maximal path length accepted by Windows. This change updated the logic to use the discovered shell varialbes to replace the existing path, which is desirable in the specific use case. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Co-authored-by: Sean Brogan Signed-off-by: Kun Qin Reviewed-by: Bob Feng Reviewed-by:=C2=A0 Sean Brogan --- BaseTools/Edk2ToolsBuild.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Edk2ToolsBuild.py b/BaseTools/Edk2ToolsBuild.py index 1ea8187de693..f862468ce275 100644 --- a/BaseTools/Edk2ToolsBuild.py +++ b/BaseTools/Edk2ToolsBuild.py @@ -122,7 +122,7 @@ class Edk2ToolsBuild(BaseAbstractInvocable): for key in vc_vars.keys(): logging.debug(f"Var - {key} =3D {vc_vars[key]}") if key.lower() =3D=3D 'path': - shell_env.insert_path(vc_vars[key]) + shell_env.set_path(vc_vars[key]) else: shell_env.set_shell_var(key, vc_vars[key]) =20 --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94088): https://edk2.groups.io/g/devel/message/94088 Mute This Topic: https://groups.io/mt/93835889/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-