From nobody Mon Feb 9 23:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93961+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93961+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1663615392; cv=none; d=zohomail.com; s=zohoarc; b=E2Zk9FZe1zSQmEbXRDQYz8ieEqv36LTeIma4gsF2j59RvjM3eM6TI4ODNNNDGPEhK1jaioiw4NmA9cRi2k9ttGMRJnfwvPx2wDI0l2PyrcLtWaxG9qWewoWqjuLxcAT3D9dwnM6g5r/DyjpRR1fu5rYzCu8ceQ/0CFFUZOESzFk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663615392; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=/xyLRj8qal5Pr3TU7YwJMQu+niBUBNb8bE1xg3RzxSM=; b=bQ4mUEJmWbOubXc8mVZXr1wtrs0CpnBAH9Jq8gKs/Hwg5JRbs7Zr5cMhpS/X8E+OZlUu/h9CGjqdwQNeX/kE8WwRIAEbIb9kmfbQ6rFdrbW8LCUY6ypsdKKM1/KUdAYI7gn9vemaYPTVpz/7uD1Gp1zZc5nenYQwSYhdv+XVSQk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93961+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1663615392058136.3366399618261; Mon, 19 Sep 2022 12:23:12 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id BL51YY1788612xr4G1knWgsj; Mon, 19 Sep 2022 12:23:11 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.3246.1663615390959792513 for ; Mon, 19 Sep 2022 12:23:11 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 324871424; Mon, 19 Sep 2022 12:23:17 -0700 (PDT) X-Received: from pierre123.arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 94B623F73B; Mon, 19 Sep 2022 12:23:08 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar , Leif Lindholm , Ard Biesheuvel , Rebecca Cran , Michael D Kinney , Liming Gao , Jiewen Yao , Jian J Wang Subject: [edk2-devel] [PATCH v5 18/21] SecurityPkg/RngDxe: Add debug warning for NULL PcdCpuRngSupportedAlgorithm Date: Mon, 19 Sep 2022 21:22:04 +0200 Message-Id: <20220919192207.637786-19-Pierre.Gondois@arm.com> In-Reply-To: <20220919192207.637786-1-Pierre.Gondois@arm.com> References: <20220919192207.637786-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 3Hrz7BzXk8Ly00vmlAhdpJkJx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1663615391; bh=WuWS5CX2hIS6GrVzJkF4B9pzDN17rxGcBaIHTrpr9Lc=; h=Cc:Date:From:Reply-To:Subject:To; b=hqmWyM77YXuqC7J2pDvlEB1CQZdPJH5zyWCKgd857Xs5Ev8wknpg3ui8yWE6j7BqJwx 28twTeI1RYECzY6RJWvOxADy4yPzo34CRgvwmjZg+NNxEk0vVN6acD3htGkAF/OQXQcwB UbKjxW3qUrDrn5IOzK9XI7/I5/zt3Dc6kuc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1663615392973100021 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois PcdCpuRngSupportedAlgorithm should allow to identify the the algorithm used by the RNDR CPU instruction to generate a random number. Add a debug warning if the Pcd is not set. Signed-off-by: Pierre Gondois --- .../RandomNumberGenerator/RngDxe/AArch64/RngDxe.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c b/Se= curityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c index f5910e3b999f..0d853720ecb1 100644 --- a/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c +++ b/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c @@ -67,6 +67,16 @@ GetAvailableAlgorithms ( sizeof (EFI_RNG_ALGORITHM) ); mAvailableAlgoArrayCount++; + + DEBUG_CODE_BEGIN (); + if (IsZeroGuid (PcdGetPtr (PcdCpuRngSupportedAlgorithm))) { + DEBUG (( + DEBUG_WARN, + "PcdCpuRngSupportedAlgorithm should be a non-zero GUID\n" + )); + } + + DEBUG_CODE_END (); } =20 // Raw algorithm (Trng) --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93961): https://edk2.groups.io/g/devel/message/93961 Mute This Topic: https://groups.io/mt/93788897/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-