From nobody Mon Feb 9 23:44:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93862+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93862+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1663268141; cv=none; d=zohomail.com; s=zohoarc; b=IF7uyN9itb/Ynd6AWSB/u+kwnbl7QOIo8lMeKU5I0fVrIYYy34LHKsb0avlMlCccbfNMH9isV3FPuF78h+EupbWCDRo8R2aBruv1dCZw4bLCT6/Z350Hfnvf6JWKIzuKZycLaJq/MZ2S/FT0FAg/rFtTKPSd3a1akhd3/pktp0I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663268141; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=gUxIjmXWP1Am8J/AhNPhGTkESsqw3dnui3egalo4prM=; b=HtUiMWCsaVcdPr6jJgMoqMVQa/yz+AqVMC4+kScmF+cbrhftbosjLZc5A75Tgo3IMFlH49mU4DnqUBtVJ+OVQ5u4qy8hrbyCb4a0cQV7MKl6rtY4xdHiyDOZhyrAZqs6JO9R1QIzYvWhRIoKbW1GhqyvTVJMMLLAXZQ1LPWWq+M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93862+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1663268141142592.3075848860344; Thu, 15 Sep 2022 11:55:41 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 0GyAYY1788612xP9VNDT8ae6; Thu, 15 Sep 2022 11:55:40 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.14229.1663268140149772318 for ; Thu, 15 Sep 2022 11:55:40 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 5099620B929C; Thu, 15 Sep 2022 11:55:39 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5099620B929C From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [edk2-devel] [PATCH v2 3/6] IntelFsp2Pkg: Add CI YAML file Date: Thu, 15 Sep 2022 14:55:05 -0400 Message-Id: <20220915185508.997-4-mikuback@linux.microsoft.com> In-Reply-To: <20220915185508.997-1-mikuback@linux.microsoft.com> References: <20220915185508.997-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: lQ737kGIkjVL9ylCK9ooTHZ3x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1663268140; bh=tUJgAAHgtloetr+P3jkouuz1jB8kakgh/uKVjWMQrvA=; h=Cc:Date:From:Reply-To:Subject:To; b=EMVejvonKRS8ngi/G5EJtVudB0wyCXTK8mvmwrDHILCVgqjaza5+vxrXDtmBbNkHsm4 o73oiwGrwURgvdS8CYlfR2993elkf0M2m5xtUymcfBN4ju0oHnWB/zEcIuidMZ7k7qEUZ PyQ8D/OZjlAjSBDp6iclwro2OV4VSFgmpJs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1663268142498100005 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 Adds IntelFsp2Pkg to the list of supported build packages for edk2 CI and defines an initial set of CI configuration options. The compiler plugin is disabled as the package currently does not build due to some changes in the FSP 2.4 interface addition. Specifically, in commit df25a54 "Fsp24SecCore.inf" files were added to IntelFspPkg.dsc but the actual files were not added. Simply removing these files from the DSC exposes a linker failure. Recommendation: 1. Enable package CI (accept this change) 2. Add IntelFsp2Pkg.dsc to the "CompilerPlugin" "DscPath" in IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml to enable compilation 3. Verify compilation and all currently enabled package CI checks pass 4. Check-in fixes in (3) with change in (2) Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Michael Kubacki --- .pytool/CISettings.py | 1 + IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml | 90 ++++++++++++++++++++ 2 files changed, 91 insertions(+) diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index cf9e0d77b19b..0205c26a58f8 100644 --- a/.pytool/CISettings.py +++ b/.pytool/CISettings.py @@ -54,6 +54,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsMana= ger, SetupSettingsManag "ArmVirtPkg", "DynamicTablesPkg", "EmulatorPkg", + "IntelFsp2Pkg", "MdePkg", "MdeModulePkg", "NetworkPkg", diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml b/IntelFsp2Pkg/IntelFsp2Pkg.= ci.yaml new file mode 100644 index 000000000000..9ce401b20164 --- /dev/null +++ b/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml @@ -0,0 +1,90 @@ +## @file +# Core CI configuration for IntelFsp2Pkg +# +# Copyright (c) Microsoft Corporation +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +## +{ + ## options defined .pytool/Plugin/LicenseCheck + "LicenseCheck": { + "IgnoreFiles": [] + }, + + "EccCheck": { + ## Exception sample looks like below: + ## "ExceptionList": [ + ## "", "" + ## ] + "ExceptionList": [ + ], + ## Both file path and directory path are accepted. + "IgnoreFiles": [] + }, + + ## options defined .pytool/Plugin/CompilerPlugin + "CompilerPlugin": { + "DscPath": "IntelFsp2Pkg.dsc" + }, + + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin + "HostUnitTestCompilerPlugin": { + "DscPath": "" # Don't support this test + }, + + ## options defined .pytool/Plugin/CharEncodingCheck + "CharEncodingCheck": { + "IgnoreFiles": [] + }, + + ## options defined .pytool/Plugin/DependencyCheck + "DependencyCheck": { + "AcceptableDependencies": [ + "IntelFsp2Pkg/IntelFsp2Pkg.dec", + "MdeModulePkg/MdeModulePkg.dec", + "MdePkg/MdePkg.dec", + "UefiCpuPkg/UefiCpuPkg.dec" + ], + # For host based unit tests + "AcceptableDependencies-HOST_APPLICATION":[ + "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec" + ], + # For UEFI shell based apps + "AcceptableDependencies-UEFI_APPLICATION":[], + "IgnoreInf": [] + }, + + ## options defined .pytool/Plugin/DscCompleteCheck + "DscCompleteCheck": { + "IgnoreInf": [""], + "DscPath": "IntelFsp2Pkg.dsc" + }, + + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck + "HostUnitTestDscCompleteCheck": { + "IgnoreInf": [""], + "DscPath": "" # Don't support this test + }, + + ## options defined .pytool/Plugin/GuidCheck + "GuidCheck": { + "IgnoreGuidName": [], + "IgnoreGuidValue": [], + "IgnoreFoldersAndFiles": [], + "IgnoreDuplicates": [], + }, + + ## options defined .pytool/Plugin/LibraryClassCheck + "LibraryClassCheck": { + "IgnoreHeaderFile": [] + }, + + ## options defined .pytool/Plugin/SpellCheck + "SpellCheck": { + "AuditOnly": True, # Fails right now with over 270 errors + "IgnoreFiles": [], # use gitignore syntax to ignore erro= rs in matching files + "ExtendWords": [], # words to extend to the dictionary f= or this package + "IgnoreStandardPaths": [], # Standard Plugin defined paths that = should be ignore + "AdditionalIncludePaths": [] # Additional paths to spell check (wi= ldcards supported) + } +} --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93862): https://edk2.groups.io/g/devel/message/93862 Mute This Topic: https://groups.io/mt/93707365/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-