From nobody Sat Feb 7 12:29:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93309+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93309+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662518246; cv=none; d=zohomail.com; s=zohoarc; b=HZiBz9x1RtUr1emsxw3gmUenWHIJNFMxFeWw4CYbhcea645u5i6inMatClY5C/XL6/GGOkHBYDw1jApf7fImXH6sG6268vJT6S8ulEJSnXClEchxXBOZ8cXnfgekh6xMBB9MAPSmRfby8dkg4devStMKcKBWMVyc87E8VStpRRo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662518246; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=u6KZJgreCs8ahTybJ032u/bA3Qte2AWe/Ubzkv4F230=; b=YxvnQmhYiFG7QosODJvNnF51l6pJ+ERjFojP+xDl1PlAHts2o935w0TFOiEcidlCzsGWHy+9AoP+BQVIyP1dRKtxpurSEzR54c2/d0J3YR5RzV6VJnWiiEBzQQu2E4QN8QXTauHLIAyMGxckIm0tfN5CM/k44u5pssdYtpv4gZM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93309+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662518246376793.4404848697786; Tue, 6 Sep 2022 19:37:26 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id FYqFYY1788612xN7yD7f1lRC; Tue, 06 Sep 2022 19:37:26 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.3332.1662518245388727683 for ; Tue, 06 Sep 2022 19:37:25 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 548DA20B929D; Tue, 6 Sep 2022 19:37:24 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 548DA20B929D From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer Subject: [edk2-devel] [PATCH v1 1/3] EmbeddedPkg/AcpiLib: Fix code formatting errors Date: Tue, 6 Sep 2022 22:36:47 -0400 Message-Id: <20220907023649.312-2-mikuback@linux.microsoft.com> In-Reply-To: <20220907023649.312-1-mikuback@linux.microsoft.com> References: <20220907023649.312-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: LTiXU4ZCdNzusxZoYZuZPhAMx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662518246; bh=WkfZoCl2aWRrnx9PFLl+rjkgzwZPAVYbpICebFWijQ8=; h=Cc:Date:From:Reply-To:Subject:To; b=oj/cI7edkH5IZ1YYzF3IPLHkZ+RtQ3hYo23REi6ha3sg8mYWUgcz6lMka8bV1EyJqkr chQdtMpp8CiqP4wAQ+K7k7dJrowlfK2BpGO01vbp/4w2AGi+aX+c732PHmFrjZh8uE2X9 3nzhn9aqc5N8wdAgwQCAydEJjPrfGV91D80= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662518246744100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4046 This package did not have CI enabled so code changes were merged that fail uncrustify formatting. This change updates those files to include uncustify formatting. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Michael Kubacki --- EmbeddedPkg/Library/AcpiLib/AcpiLib.c | 88 ++++++++++---------- EmbeddedPkg/Include/Library/AcpiLib.h | 22 ++--- 2 files changed, 56 insertions(+), 54 deletions(-) diff --git a/EmbeddedPkg/Library/AcpiLib/AcpiLib.c b/EmbeddedPkg/Library/Ac= piLib/AcpiLib.c index ea2ad63b2039..cb593a7b2a3a 100644 --- a/EmbeddedPkg/Library/AcpiLib/AcpiLib.c +++ b/EmbeddedPkg/Library/AcpiLib/AcpiLib.c @@ -192,13 +192,13 @@ LocateAndInstallAcpiFromFv ( EFI_STATUS EFIAPI AcpiUpdateChecksum ( - IN OUT UINT8 *Buffer, - IN UINTN Size + IN OUT UINT8 *Buffer, + IN UINTN Size ) { - UINTN ChecksumOffset; + UINTN ChecksumOffset; =20 - if (Buffer =3D=3D NULL || Size =3D=3D 0) { + if ((Buffer =3D=3D NULL) || (Size =3D=3D 0)) { return EFI_INVALID_PARAMETER; } =20 @@ -237,11 +237,11 @@ AcpiUpdateChecksum ( EFI_STATUS EFIAPI AcpiLocateTableBySignature ( - IN EFI_ACPI_SDT_PROTOCOL *AcpiSdtProtocol, - IN UINT32 TableSignature, - IN OUT UINTN *Index, - OUT EFI_ACPI_DESCRIPTION_HEADER **Table, - OUT UINTN *TableKey + IN EFI_ACPI_SDT_PROTOCOL *AcpiSdtProtocol, + IN UINT32 TableSignature, + IN OUT UINTN *Index, + OUT EFI_ACPI_DESCRIPTION_HEADER **Table, + OUT UINTN *TableKey ) { EFI_STATUS Status; @@ -249,9 +249,10 @@ AcpiLocateTableBySignature ( EFI_ACPI_TABLE_VERSION TableVersion; UINTN TableIndex; =20 - if (AcpiSdtProtocol =3D=3D NULL - || Table =3D=3D NULL - || TableKey =3D=3D NULL) { + if ( (AcpiSdtProtocol =3D=3D NULL) + || (Table =3D=3D NULL) + || (TableKey =3D=3D NULL)) + { return EFI_INVALID_PARAMETER; } =20 @@ -261,7 +262,7 @@ AcpiLocateTableBySignature ( // Search for ACPI Table with matching signature // TableVersion =3D 0; - TableIndex =3D *Index; + TableIndex =3D *Index; while (!EFI_ERROR (Status)) { Status =3D AcpiSdtProtocol->GetAcpiTable ( TableIndex, @@ -301,26 +302,26 @@ AcpiLocateTableBySignature ( EFI_STATUS EFIAPI AcpiAmlObjectUpdateInteger ( - IN EFI_ACPI_SDT_PROTOCOL *AcpiSdtProtocol, - IN EFI_ACPI_HANDLE TableHandle, - IN CHAR8 *AsciiObjectPath, - IN UINTN Value + IN EFI_ACPI_SDT_PROTOCOL *AcpiSdtProtocol, + IN EFI_ACPI_HANDLE TableHandle, + IN CHAR8 *AsciiObjectPath, + IN UINTN Value ) { - EFI_STATUS Status; - EFI_ACPI_HANDLE ObjectHandle; - EFI_ACPI_HANDLE DataHandle; - EFI_ACPI_DATA_TYPE DataType; - UINT8 *Buffer; - UINTN BufferSize; - UINTN DataSize; + EFI_STATUS Status; + EFI_ACPI_HANDLE ObjectHandle; + EFI_ACPI_HANDLE DataHandle; + EFI_ACPI_DATA_TYPE DataType; + UINT8 *Buffer; + UINTN BufferSize; + UINTN DataSize; =20 - if (AcpiSdtProtocol =3D=3D NULL || AsciiObjectPath =3D=3D NULL) { + if ((AcpiSdtProtocol =3D=3D NULL) || (AsciiObjectPath =3D=3D NULL)) { return EFI_INVALID_PARAMETER; } =20 ObjectHandle =3D NULL; - DataHandle =3D NULL; + DataHandle =3D NULL; =20 Status =3D AcpiSdtProtocol->FindPath (TableHandle, AsciiObjectPath, &Obj= ectHandle); if (EFI_ERROR (Status)) { @@ -332,6 +333,7 @@ AcpiAmlObjectUpdateInteger ( Status =3D EFI_NOT_FOUND; goto Exit; } + ASSERT (DataType =3D=3D EFI_ACPI_DATA_TYPE_OPCODE); ASSERT (Buffer !=3D NULL); =20 @@ -350,7 +352,7 @@ AcpiAmlObjectUpdateInteger ( ASSERT (DataType =3D=3D EFI_ACPI_DATA_TYPE_OPCODE); ASSERT (Buffer !=3D NULL); =20 - if (Buffer[0] =3D=3D AML_ZERO_OP || Buffer[0] =3D=3D AML_ONE_OP) { + if ((Buffer[0] =3D=3D AML_ZERO_OP) || (Buffer[0] =3D=3D AML_ONE_OP)) { Status =3D AcpiSdtProtocol->SetOption (DataHandle, 0, (VOID *)&Value, = sizeof (UINT8)); ASSERT_EFI_ERROR (Status); } else { @@ -358,26 +360,26 @@ AcpiAmlObjectUpdateInteger ( // Check the size of data object // switch (Buffer[0]) { - case AML_BYTE_PREFIX: - DataSize =3D sizeof (UINT8); - break; + case AML_BYTE_PREFIX: + DataSize =3D sizeof (UINT8); + break; =20 - case AML_WORD_PREFIX: - DataSize =3D sizeof (UINT16); - break; + case AML_WORD_PREFIX: + DataSize =3D sizeof (UINT16); + break; =20 - case AML_DWORD_PREFIX: - DataSize =3D sizeof (UINT32); - break; + case AML_DWORD_PREFIX: + DataSize =3D sizeof (UINT32); + break; =20 - case AML_QWORD_PREFIX: - DataSize =3D sizeof (UINT64); - break; + case AML_QWORD_PREFIX: + DataSize =3D sizeof (UINT64); + break; =20 - default: - // The data type of the ACPI object is not an integer - Status =3D EFI_INVALID_PARAMETER; - goto Exit; + default: + // The data type of the ACPI object is not an integer + Status =3D EFI_INVALID_PARAMETER; + goto Exit; } =20 Status =3D AcpiSdtProtocol->SetOption (DataHandle, 1, (VOID *)&Value, = DataSize); diff --git a/EmbeddedPkg/Include/Library/AcpiLib.h b/EmbeddedPkg/Include/Li= brary/AcpiLib.h index 9dbacd85b0ef..29137a4a53df 100644 --- a/EmbeddedPkg/Include/Library/AcpiLib.h +++ b/EmbeddedPkg/Include/Library/AcpiLib.h @@ -144,8 +144,8 @@ LocateAndInstallAcpiFromFv ( EFI_STATUS EFIAPI AcpiUpdateChecksum ( - IN OUT UINT8 *Buffer, - IN UINTN Size + IN OUT UINT8 *Buffer, + IN UINTN Size ); =20 /** @@ -168,11 +168,11 @@ AcpiUpdateChecksum ( EFI_STATUS EFIAPI AcpiLocateTableBySignature ( - IN EFI_ACPI_SDT_PROTOCOL *AcpiSdtProtocol, - IN UINT32 TableSignature, - IN OUT UINTN *Index, - OUT EFI_ACPI_DESCRIPTION_HEADER **Table, - OUT UINTN *TableKey + IN EFI_ACPI_SDT_PROTOCOL *AcpiSdtProtocol, + IN UINT32 TableSignature, + IN OUT UINTN *Index, + OUT EFI_ACPI_DESCRIPTION_HEADER **Table, + OUT UINTN *TableKey ); =20 /** @@ -193,10 +193,10 @@ AcpiLocateTableBySignature ( EFI_STATUS EFIAPI AcpiAmlObjectUpdateInteger ( - IN EFI_ACPI_SDT_PROTOCOL *AcpiSdtProtocol, - IN EFI_ACPI_HANDLE TableHandle, - IN CHAR8 *AsciiObjectPath, - IN UINTN Value + IN EFI_ACPI_SDT_PROTOCOL *AcpiSdtProtocol, + IN EFI_ACPI_HANDLE TableHandle, + IN CHAR8 *AsciiObjectPath, + IN UINTN Value ); =20 #endif // __ACPI_LIB_H__ --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93309): https://edk2.groups.io/g/devel/message/93309 Mute This Topic: https://groups.io/mt/93517520/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-