From nobody Sun Feb 8 12:39:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93105+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93105+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1662157359; cv=none; d=zohomail.com; s=zohoarc; b=X/2T8J5znPfs+v+vSJtnaFICEMavxHjYs9eDhnnPIXys4gvKCrhR9yfyBtGKBXQgf3jd7rf8cDa8+Vh8d09Hkj909eeO/EFhxIkxTMyMSsHjllBIgv/LrmwRfnA/y/itXGgylX9qhyJvVGoA7PZcdmn7coNil/U0troMZt/QBTQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662157359; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=i5VIKvrZdYKxARn3x6jsW0Uds2xEO8U9lnwZvYCC9FE=; b=A8WkKs4u57LlFc1Th1rlVyRAdg1eUsoO0Ul7dpXY5fAk2+QPc7lkAJ24j8vfDtbMEYdseJ9ECaQRagQdaOFSF7noylpmvvu1TrVvP6LJgvapI44rJ+DCM3LoPwzovp2Wksxv+JagbsPHbp0xlP8JZaucp/mc5NENczHnU2S6aqY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93105+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662157359966532.40254439563; Fri, 2 Sep 2022 15:22:39 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ySXzYY1788612xtqjKjaRngs; Fri, 02 Sep 2022 15:22:39 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.4505.1662157359107048533 for ; Fri, 02 Sep 2022 15:22:39 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 2C54020477A0; Fri, 2 Sep 2022 15:22:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2C54020477A0 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Ard Biesheuvel Subject: [edk2-devel] [PATCH v3 1/8] ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier Date: Fri, 2 Sep 2022 18:21:59 -0400 Message-Id: <20220902222206.1509-2-mikuback@linux.microsoft.com> In-Reply-To: <20220902222206.1509-1-mikuback@linux.microsoft.com> References: <20220902222206.1509-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: tJtUrTmnLZKYQyzi7y7IjbJAx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662157359; bh=8ZMk3ElTnbh6yckO70YFOfr0T+/6cWgub/qKg634pRQ=; h=Cc:Date:From:Reply-To:Subject:To; b=ufjAhTN6e9YCeyWNXT7Qkz/a8Jf6uhhpv0oqrxYV1i8wNCnDyZgg2kNF/lqEp8z/Xge f7kdwwGw0UE3aYFZq6DoRvWptA58Slhns/sISKWPksk3DttU4htSFHkSFEHMWClZNJKPr a6yoXQvxoVuBu6iHlNzXjW7xn2nFfb69mhw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662157361684100003 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki These debug messages are repeated in both NorFlashBlockIoReadBlocks() and NorFlashBlockIoWriteBlocks(): "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%ld, BufferSize=3D0x%x" "bytes (%d kB), BufferPtr @ 0x%08x)\n" Although this requires 5 arguments, only 4 are provided. The kilobyte value was never given. This change removes that specifier so the 4 arguments match the 4 specifiers in the debug macro. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Michael Kubacki Reviewed-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c b/ArmP= latformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c index 5afab0a79fa2..9d4732c6905a 100644 --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c @@ -54,7 +54,7 @@ NorFlashBlockIoReadBlocks ( Instance =3D INSTANCE_FROM_BLKIO_THIS (This); Media =3D This->Media; =20 - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=3D0x%x, Lba=3D%l= d, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba, B= ufferSizeInBytes, Buffer)); + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=3D0x%x, Lba=3D%l= d, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba, B= ufferSizeInBytes, BufferSizeInBytes, Buffer)); =20 if (!Media) { Status =3D EFI_INVALID_PARAMETER; @@ -89,7 +89,7 @@ NorFlashBlockIoWriteBlocks ( =20 Instance =3D INSTANCE_FROM_BLKIO_THIS (This); =20 - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%= ld, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba, = BufferSizeInBytes, Buffer)); + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%= ld, BufferSize=3D0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba, BufferSi= zeInBytes, Buffer)); =20 if ( !This->Media->MediaPresent ) { Status =3D EFI_NO_MEDIA; --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93105): https://edk2.groups.io/g/devel/message/93105 Mute This Topic: https://groups.io/mt/93429908/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-